You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Quanlong Huang (Code Review)" <ge...@cloudera.org> on 2019/02/24 00:00:22 UTC
[Impala-ASF-CR](2.x) IMPALA-7140 (part 5): support fetching file info for FS tables
Hello Vuk Ercegovac, Impala Public Jenkins,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/12569
to review the following change.
Change subject: IMPALA-7140 (part 5): support fetching file info for FS tables
......................................................................
IMPALA-7140 (part 5): support fetching file info for FS tables
This adds support for fetching file information and creating file
descriptors.
With this patch, I'm able to connect and run queries. Most planner tests
still fail because of missing column stats resulting in different join
orders compared to the existing implementation.
Change-Id: I42d67ab754872fad094c7dacdd2e1182de1bf3e8
Reviewed-on: http://gerrit.cloudera.org:8080/10749
Reviewed-by: Vuk Ercegovac <ve...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/src/main/java/org/apache/impala/catalog/FeFsTable.java
M fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/catalog/local/DirectMetaProvider.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalFsPartition.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalFsTable.java
M fe/src/main/java/org/apache/impala/catalog/local/MetaProvider.java
M fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java
8 files changed, 187 insertions(+), 49 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/69/12569/1
--
To view, visit http://gerrit.cloudera.org:8080/12569
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I42d67ab754872fad094c7dacdd2e1182de1bf3e8
Gerrit-Change-Number: 12569
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
[Impala-ASF-CR](2.x) IMPALA-7140 (part 5): support fetching file info for FS tables
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12569 )
Change subject: IMPALA-7140 (part 5): support fetching file info for FS tables
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3824/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/12569
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I42d67ab754872fad094c7dacdd2e1182de1bf3e8
Gerrit-Change-Number: 12569
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Sun, 24 Feb 2019 01:16:08 +0000
Gerrit-HasComments: No
[Impala-ASF-CR](2.x) IMPALA-7140 (part 5): support fetching file info for FS tables
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12569 )
Change subject: IMPALA-7140 (part 5): support fetching file info for FS tables
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2227/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12569
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I42d67ab754872fad094c7dacdd2e1182de1bf3e8
Gerrit-Change-Number: 12569
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Sun, 24 Feb 2019 01:36:50 +0000
Gerrit-HasComments: No
[Impala-ASF-CR](2.x) IMPALA-7140 (part 5): support fetching file info for FS tables
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Hello Fredy Wijaya, Vuk Ercegovac, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12569
to look at the new patch set (#2).
Change subject: IMPALA-7140 (part 5): support fetching file info for FS tables
......................................................................
IMPALA-7140 (part 5): support fetching file info for FS tables
This adds support for fetching file information and creating file
descriptors.
With this patch, I'm able to connect and run queries. Most planner tests
still fail because of missing column stats resulting in different join
orders compared to the existing implementation.
Change-Id: I42d67ab754872fad094c7dacdd2e1182de1bf3e8
Reviewed-on: http://gerrit.cloudera.org:8080/10749
Reviewed-by: Vuk Ercegovac <ve...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/src/main/java/org/apache/impala/catalog/FeFsTable.java
M fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/catalog/local/DirectMetaProvider.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalFsPartition.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalFsTable.java
M fe/src/main/java/org/apache/impala/catalog/local/MetaProvider.java
M fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java
8 files changed, 188 insertions(+), 50 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/69/12569/2
--
To view, visit http://gerrit.cloudera.org:8080/12569
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I42d67ab754872fad094c7dacdd2e1182de1bf3e8
Gerrit-Change-Number: 12569
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
[Impala-ASF-CR](2.x) IMPALA-7140 (part 5): support fetching file info for FS tables
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/12569 )
Change subject: IMPALA-7140 (part 5): support fetching file info for FS tables
......................................................................
Patch Set 1:
Thank you, Fredy!
--
To view, visit http://gerrit.cloudera.org:8080/12569
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I42d67ab754872fad094c7dacdd2e1182de1bf3e8
Gerrit-Change-Number: 12569
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Sun, 24 Feb 2019 00:11:50 +0000
Gerrit-HasComments: No
[Impala-ASF-CR](2.x) IMPALA-7140 (part 5): support fetching file info for FS tables
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12569 )
Change subject: IMPALA-7140 (part 5): support fetching file info for FS tables
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3823/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/12569
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I42d67ab754872fad094c7dacdd2e1182de1bf3e8
Gerrit-Change-Number: 12569
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Sun, 24 Feb 2019 00:12:56 +0000
Gerrit-HasComments: No
[Impala-ASF-CR](2.x) IMPALA-7140 (part 5): support fetching file info for FS tables
Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12569 )
Change subject: IMPALA-7140 (part 5): support fetching file info for FS tables
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12569
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I42d67ab754872fad094c7dacdd2e1182de1bf3e8
Gerrit-Change-Number: 12569
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Sun, 24 Feb 2019 00:08:59 +0000
Gerrit-HasComments: No
[Impala-ASF-CR](2.x) IMPALA-7140 (part 5): support fetching file info for FS tables
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/12569 )
Change subject: IMPALA-7140 (part 5): support fetching file info for FS tables
......................................................................
Patch Set 2: Code-Review+2
Sorry for the mistake. Carry on the +2.
--
To view, visit http://gerrit.cloudera.org:8080/12569
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I42d67ab754872fad094c7dacdd2e1182de1bf3e8
Gerrit-Change-Number: 12569
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Sun, 24 Feb 2019 01:21:10 +0000
Gerrit-HasComments: No
[Impala-ASF-CR](2.x) IMPALA-7140 (part 5): support fetching file info for FS tables
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/12569 )
Change subject: IMPALA-7140 (part 5): support fetching file info for FS tables
......................................................................
Patch Set 1:
(1 comment)
Only one conflicts in fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
440 public static List<FileDescriptor> createFileDescriptors(
441 FileSystem fs,
442 RemoteIterator<LocatedFileStatus> fileStatusIter,
443 ListMap<TNetworkAddress> hostIndex,
444 FileMetadataLoadStats loadStats) throws IOException {
445 boolean supportsBlocks = FileSystemUtil.supportsStorageIds(fs);
446 Reference<Long> numUnknownDiskIds = new Reference<Long>(Long.valueOf(0));
447 List<FileDescriptor> newFileDescs = Lists.newArrayList();
448 while (fileStatusIter.hasNext()) {
449 LocatedFileStatus fileStatus = fileStatusIter.next();
450 if (!FileSystemUtil.isValidDataFile(fileStatus)) {
451 ++loadStats.hiddenFiles;
452 continue;
453 }
454 FileDescriptor fd;
455 if (supportsBlocks) {
456 fd = FileDescriptor.create(fileStatus, fileStatus.getBlockLocations(), fs,
457 <<<<<<< HEAD
458 hostIndex_, numUnknownDiskIds);
459 =======
460 hostIndex, HdfsShim.isErasureCoded(fileStatus), numUnknownDiskIds);
461 >>>>>>> 64e6719... IMPALA-7140 (part 5): support fetching file info for FS tables
462 } else {
463 fd = FileDescriptor.createWithNoBlocks(fileStatus);
464 }
465 newFileDescs.add(fd);
466 ++loadStats.loadedFiles;
467 }
468 loadStats.unknownDiskIds += numUnknownDiskIds.getRef();
469 return newFileDescs;
470 }
http://gerrit.cloudera.org:8080/#/c/12569/1/fe/src/main/java/org/apache/impala/catalog/local/LocalFsTable.java
File fe/src/main/java/org/apache/impala/catalog/local/LocalFsTable.java:
http://gerrit.cloudera.org:8080/#/c/12569/1/fe/src/main/java/org/apache/impala/catalog/local/LocalFsTable.java@134
PS1, Line 134: // TODO(todd): this is slow because it requires loading all partitions. Remove if possible.
> line too long (95 > 90)
Ignore this to avoid conflicts in later cherrypicks
--
To view, visit http://gerrit.cloudera.org:8080/12569
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I42d67ab754872fad094c7dacdd2e1182de1bf3e8
Gerrit-Change-Number: 12569
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Sun, 24 Feb 2019 00:11:11 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR](2.x) IMPALA-7140 (part 5): support fetching file info for FS tables
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12569 )
Change subject: IMPALA-7140 (part 5): support fetching file info for FS tables
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12569/2/fe/src/main/java/org/apache/impala/catalog/local/LocalFsTable.java
File fe/src/main/java/org/apache/impala/catalog/local/LocalFsTable.java:
http://gerrit.cloudera.org:8080/#/c/12569/2/fe/src/main/java/org/apache/impala/catalog/local/LocalFsTable.java@134
PS2, Line 134: // TODO(todd): this is slow because it requires loading all partitions. Remove if possible.
line too long (95 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/12569
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I42d67ab754872fad094c7dacdd2e1182de1bf3e8
Gerrit-Change-Number: 12569
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Sun, 24 Feb 2019 01:14:37 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR](2.x) IMPALA-7140 (part 5): support fetching file info for FS tables
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12569 )
Change subject: IMPALA-7140 (part 5): support fetching file info for FS tables
......................................................................
Patch Set 1: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/3823/
--
To view, visit http://gerrit.cloudera.org:8080/12569
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I42d67ab754872fad094c7dacdd2e1182de1bf3e8
Gerrit-Change-Number: 12569
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Sun, 24 Feb 2019 01:20:09 +0000
Gerrit-HasComments: No
[Impala-ASF-CR](2.x) IMPALA-7140 (part 5): support fetching file info for FS tables
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12569 )
Change subject: IMPALA-7140 (part 5): support fetching file info for FS tables
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/12569
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I42d67ab754872fad094c7dacdd2e1182de1bf3e8
Gerrit-Change-Number: 12569
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Sun, 24 Feb 2019 05:14:09 +0000
Gerrit-HasComments: No
[Impala-ASF-CR](2.x) IMPALA-7140 (part 5): support fetching file info for FS tables
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12569 )
Change subject: IMPALA-7140 (part 5): support fetching file info for FS tables
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12569/1/fe/src/main/java/org/apache/impala/catalog/local/LocalFsTable.java
File fe/src/main/java/org/apache/impala/catalog/local/LocalFsTable.java:
http://gerrit.cloudera.org:8080/#/c/12569/1/fe/src/main/java/org/apache/impala/catalog/local/LocalFsTable.java@134
PS1, Line 134: // TODO(todd): this is slow because it requires loading all partitions. Remove if possible.
line too long (95 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/12569
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I42d67ab754872fad094c7dacdd2e1182de1bf3e8
Gerrit-Change-Number: 12569
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Sun, 24 Feb 2019 00:01:05 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR](2.x) IMPALA-7140 (part 5): support fetching file info for FS tables
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12569 )
Change subject: IMPALA-7140 (part 5): support fetching file info for FS tables
......................................................................
IMPALA-7140 (part 5): support fetching file info for FS tables
This adds support for fetching file information and creating file
descriptors.
With this patch, I'm able to connect and run queries. Most planner tests
still fail because of missing column stats resulting in different join
orders compared to the existing implementation.
Change-Id: I42d67ab754872fad094c7dacdd2e1182de1bf3e8
Reviewed-on: http://gerrit.cloudera.org:8080/10749
Reviewed-by: Vuk Ercegovac <ve...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-on: http://gerrit.cloudera.org:8080/12569
Reviewed-by: Quanlong Huang <hu...@gmail.com>
---
M fe/src/main/java/org/apache/impala/catalog/FeFsTable.java
M fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/catalog/local/DirectMetaProvider.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalFsPartition.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalFsTable.java
M fe/src/main/java/org/apache/impala/catalog/local/MetaProvider.java
M fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java
8 files changed, 188 insertions(+), 50 deletions(-)
Approvals:
Quanlong Huang: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/12569
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I42d67ab754872fad094c7dacdd2e1182de1bf3e8
Gerrit-Change-Number: 12569
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
[Impala-ASF-CR](2.x) IMPALA-7140 (part 5): support fetching file info for FS tables
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12569 )
Change subject: IMPALA-7140 (part 5): support fetching file info for FS tables
......................................................................
Patch Set 1:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/2224/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/12569
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I42d67ab754872fad094c7dacdd2e1182de1bf3e8
Gerrit-Change-Number: 12569
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Sun, 24 Feb 2019 00:40:33 +0000
Gerrit-HasComments: No