You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/08/30 11:54:25 UTC
[GitHub] [tvm] Icemist opened a new pull request, #12647: Define memory_info for global.texture*
Icemist opened a new pull request, #12647:
URL: https://github.com/apache/tvm/pull/12647
There are now many warnings in the tuning process about undefined memory information when using textures. A definition is required as textures* are tagged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] csullivan commented on a diff in pull request #12647: Define memory_info for global.texture*
Posted by GitBox <gi...@apache.org>.
csullivan commented on code in PR #12647:
URL: https://github.com/apache/tvm/pull/12647#discussion_r958658461
##########
python/tvm/topi/adreno/utils.py:
##########
@@ -571,6 +572,39 @@ def get_texture_storage(shape):
return "global.texture-weight"
+@register_func("tvm.info.mem.global.texture")
+def mem_info_global_texture():
+ return tvm.ir.make_node(
+ "MemoryInfo",
+ unit_bits=16,
+ max_num_bits=16384 * 16384 * 4 * 32,
+ max_simd_bits=4 * 32,
+ head_address=None,
+ )
Review Comment:
This looks to be repeated in each mem_info function so perhaps a common function called in each to prevent accidental changes in one and not the others.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Icemist commented on a diff in pull request #12647: Define memory_info for global.texture*
Posted by GitBox <gi...@apache.org>.
Icemist commented on code in PR #12647:
URL: https://github.com/apache/tvm/pull/12647#discussion_r960069147
##########
python/tvm/topi/adreno/utils.py:
##########
@@ -571,6 +572,46 @@ def get_texture_storage(shape):
return "global.texture-weight"
+# global texture variants has the same memory info
+gt_unit_bits = 16
Review Comment:
Remade
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Icemist commented on pull request #12647: Define memory_info for global.texture*
Posted by GitBox <gi...@apache.org>.
Icemist commented on PR #12647:
URL: https://github.com/apache/tvm/pull/12647#issuecomment-1231563771
CC @csullivan @elvin-n
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] csullivan merged pull request #12647: [Adreno] Define memory_info for global.texture*
Posted by GitBox <gi...@apache.org>.
csullivan merged PR #12647:
URL: https://github.com/apache/tvm/pull/12647
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Icemist commented on a diff in pull request #12647: Define memory_info for global.texture*
Posted by GitBox <gi...@apache.org>.
Icemist commented on code in PR #12647:
URL: https://github.com/apache/tvm/pull/12647#discussion_r958703925
##########
python/tvm/topi/adreno/utils.py:
##########
@@ -571,6 +572,39 @@ def get_texture_storage(shape):
return "global.texture-weight"
+@register_func("tvm.info.mem.global.texture")
+def mem_info_global_texture():
+ return tvm.ir.make_node(
+ "MemoryInfo",
+ unit_bits=16,
+ max_num_bits=16384 * 16384 * 4 * 32,
+ max_simd_bits=4 * 32,
+ head_address=None,
+ )
Review Comment:
Good point, I moved this to the separate variables above .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] elvin-n commented on a diff in pull request #12647: Define memory_info for global.texture*
Posted by GitBox <gi...@apache.org>.
elvin-n commented on code in PR #12647:
URL: https://github.com/apache/tvm/pull/12647#discussion_r959200627
##########
python/tvm/topi/adreno/utils.py:
##########
@@ -571,6 +572,46 @@ def get_texture_storage(shape):
return "global.texture-weight"
+# global texture variants has the same memory info
+gt_unit_bits = 16
Review Comment:
it's better to create function calling tvm.ir.make_node once and put all stuff inside this function instead of creation the global variables
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org