You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@orc.apache.org by GitBox <gi...@apache.org> on 2022/11/27 05:17:49 UTC
[GitHub] [orc] wgtmac opened a new pull request, #1324: ORC-1315: [C++] Fix test failure when unsigned char is in effect
wgtmac opened a new pull request, #1324:
URL: https://github.com/apache/orc/pull/1324
### What changes were proposed in this pull request?
Previous fix of ORC-1315 is not complete yet. This is a follow up commit to fix the remaining issues where unsigned chars may produce unexpected behavior.
### Why are the changes needed?
In the debian docker images, several test cases fail like below:
```
[----------] Global test environment tear-down
[==========] 87 tests from 10 test cases ran. (8039 ms total)
[ PASSED ] 83 tests.
[ FAILED ] 4 tests, listed below:
[ FAILED ] TestMatch.selectColumns
[ FAILED ] TestMatchParam/FileParam.Contents/7, where GetParam() = TestOrcFile.testSeek.orc
[ FAILED ] TestMatchParam/FileParam.Contents/18, where GetParam() = nulls-at-end-snappy.orc
[ FAILED ] TestMatchParam/FileParam.Contents/23, where GetParam() = over1k_bloom.orc
```
### How was this patch tested?
- Add `-funsigned-char` flat to compile manually to make sure all tests pass.
- All test cases pass on the debian docker images.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] wgtmac merged pull request #1324: ORC-1315: [C++] Fix test failure when unsigned char is in effect
Posted by GitBox <gi...@apache.org>.
wgtmac merged PR #1324:
URL: https://github.com/apache/orc/pull/1324
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] wgtmac commented on pull request #1324: ORC-1315: [C++] Fix test failure when unsigned char is in effect
Posted by GitBox <gi...@apache.org>.
wgtmac commented on PR #1324:
URL: https://github.com/apache/orc/pull/1324#issuecomment-1328239969
> LGTM. Should we explicitly use `int_8` and `uint_8` instead of `char` in other places? Maybe we can cleanup this in a follow-up JIRA.
That is a good suggestion! I plan to do it later as a separate change since it may affect a larger scope than the current quick fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] wgtmac commented on pull request #1324: ORC-1315: [C++] Fix test failure when unsigned char is in effect
Posted by GitBox <gi...@apache.org>.
wgtmac commented on PR #1324:
URL: https://github.com/apache/orc/pull/1324#issuecomment-1328181795
cc @coderex2522 @luffy-zh
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org