[GitHub] [druid] QazerLab opened a new pull request #11964: Make dsql discard unfinished input on Ctrl-C.

[GitBox <gi...@apache.org>]

QazerLab opened a new pull request #11964:
URL: https://github.com/apache/druid/pull/11964


   ### Description
   
   There are many interactive CLI tools which discard unfinished input when user hits Ctrl-C: shells, REPLs (`jshell`, `python`, etc.), interactive clients (`psql`, `openstack`, etc.). On the contrary, `dsql` does not behave like this and just quits once Ctrl-C is hit.
   
   Due to the vast multitude of interactive tools which handle Ctrl-C the first way, `dsql`'s behavior feels unexpected and counter-intuitive.
   
   This PR makes `dsql` handle Ctrl-C like many other interactive tools:
   
   ```
   dsql> select count(*) fro
   ^C
   dsql> select 1;
   ┌────────┐
   │ EXPR$0 │
   ├────────┤
   │      1 │
   └────────┘
   Retrieved 1 row in 0.04s.
   ```
   
   ---
   
   This PR has:
   - [x] been self-reviewed.
   - [ ] added documentation for new or modified features or behaviors.
   - [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
   - [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
   - [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
   - [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met.
   - [ ] added integration tests.
   - [ ] been tested in a test Druid cluster.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org