You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by si...@apache.org on 2011/04/06 08:11:48 UTC
svn commit: r1089311 - in /commons/proper/discovery/trunk/src: changes/
java/org/apache/commons/discovery/ java/org/apache/commons/discovery/jdk/
java/org/apache/commons/discovery/resource/
java/org/apache/commons/discovery/resource/classes/ java/org/a...
Author: simonetripodi
Date: Wed Apr 6 06:11:47 2011
New Revision: 1089311
URL: http://svn.apache.org/viewvc?rev=1089311&view=rev
Log:
DISCOVERY-16 - The setLog() methods are not thread-safe and should be deprecated
Modified:
commons/proper/discovery/trunk/src/changes/changes.xml
commons/proper/discovery/trunk/src/java/org/apache/commons/discovery/ResourceClass.java
commons/proper/discovery/trunk/src/java/org/apache/commons/discovery/jdk/JDK12Hooks.java
commons/proper/discovery/trunk/src/java/org/apache/commons/discovery/resource/DiscoverResources.java
commons/proper/discovery/trunk/src/java/org/apache/commons/discovery/resource/classes/DiscoverClasses.java
commons/proper/discovery/trunk/src/java/org/apache/commons/discovery/resource/names/DiscoverMappedNames.java
commons/proper/discovery/trunk/src/java/org/apache/commons/discovery/resource/names/DiscoverNamesInAlternateManagedProperties.java
commons/proper/discovery/trunk/src/java/org/apache/commons/discovery/resource/names/DiscoverNamesInDictionary.java
commons/proper/discovery/trunk/src/java/org/apache/commons/discovery/resource/names/DiscoverNamesInFile.java
commons/proper/discovery/trunk/src/java/org/apache/commons/discovery/resource/names/DiscoverNamesInManagedProperties.java
commons/proper/discovery/trunk/src/java/org/apache/commons/discovery/resource/names/DiscoverNamesInSystemProperties.java
commons/proper/discovery/trunk/src/java/org/apache/commons/discovery/resource/names/NameDiscoverers.java
commons/proper/discovery/trunk/src/java/org/apache/commons/discovery/tools/ClassUtils.java
commons/proper/discovery/trunk/src/java/org/apache/commons/discovery/tools/ManagedProperties.java
Modified: commons/proper/discovery/trunk/src/changes/changes.xml
URL: http://svn.apache.org/viewvc/commons/proper/discovery/trunk/src/changes/changes.xml?rev=1089311&r1=1089310&r2=1089311&view=diff
==============================================================================
--- commons/proper/discovery/trunk/src/changes/changes.xml (original)
+++ commons/proper/discovery/trunk/src/changes/changes.xml Wed Apr 6 06:11:47 2011
@@ -34,6 +34,9 @@
Custom org.apache.commons.discovery.log.Log implementation replaced by
default commons-logging behavior.
</action>
+ <action dev="simonetripodi" type="update" issue="DISCOVERY-16">
+ The setLog() methods are not thread-safe and should be deprecated.
+ </action>
</release>
</body>
</document>
Modified: commons/proper/discovery/trunk/src/java/org/apache/commons/discovery/ResourceClass.java
URL: http://svn.apache.org/viewvc/commons/proper/discovery/trunk/src/java/org/apache/commons/discovery/ResourceClass.java?rev=1089311&r1=1089310&r2=1089311&view=diff
==============================================================================
--- commons/proper/discovery/trunk/src/java/org/apache/commons/discovery/ResourceClass.java (original)
+++ commons/proper/discovery/trunk/src/java/org/apache/commons/discovery/ResourceClass.java Wed Apr 6 06:11:47 2011
@@ -40,7 +40,9 @@ public class ResourceClass<T> extends Re
* Sets the {@code Log} for this class.
*
* @param _log This class {@code Log}
+ * @deprecated This method is not thread-safe
*/
+ @Deprecated
public static void setLog(Log _log) {
log = _log;
}
Modified: commons/proper/discovery/trunk/src/java/org/apache/commons/discovery/jdk/JDK12Hooks.java
URL: http://svn.apache.org/viewvc/commons/proper/discovery/trunk/src/java/org/apache/commons/discovery/jdk/JDK12Hooks.java?rev=1089311&r1=1089310&r2=1089311&view=diff
==============================================================================
--- commons/proper/discovery/trunk/src/java/org/apache/commons/discovery/jdk/JDK12Hooks.java (original)
+++ commons/proper/discovery/trunk/src/java/org/apache/commons/discovery/jdk/JDK12Hooks.java Wed Apr 6 06:11:47 2011
@@ -43,7 +43,9 @@ public class JDK12Hooks extends JDKHooks
* Sets the {@code Log} for this class.
*
* @param _log This class {@code Log}
+ * @deprecated This method is not thread-safe
*/
+ @Deprecated
public static void setLog(Log _log) {
log = _log;
}
Modified: commons/proper/discovery/trunk/src/java/org/apache/commons/discovery/resource/DiscoverResources.java
URL: http://svn.apache.org/viewvc/commons/proper/discovery/trunk/src/java/org/apache/commons/discovery/resource/DiscoverResources.java?rev=1089311&r1=1089310&r2=1089311&view=diff
==============================================================================
--- commons/proper/discovery/trunk/src/java/org/apache/commons/discovery/resource/DiscoverResources.java (original)
+++ commons/proper/discovery/trunk/src/java/org/apache/commons/discovery/resource/DiscoverResources.java Wed Apr 6 06:11:47 2011
@@ -37,7 +37,9 @@ public class DiscoverResources extends R
* Sets the {@code Log} for this class.
*
* @param _log This class {@code Log}
+ * @deprecated This method is not thread-safe
*/
+ @Deprecated
public static void setLog(Log _log) {
log = _log;
}
Modified: commons/proper/discovery/trunk/src/java/org/apache/commons/discovery/resource/classes/DiscoverClasses.java
URL: http://svn.apache.org/viewvc/commons/proper/discovery/trunk/src/java/org/apache/commons/discovery/resource/classes/DiscoverClasses.java?rev=1089311&r1=1089310&r2=1089311&view=diff
==============================================================================
--- commons/proper/discovery/trunk/src/java/org/apache/commons/discovery/resource/classes/DiscoverClasses.java (original)
+++ commons/proper/discovery/trunk/src/java/org/apache/commons/discovery/resource/classes/DiscoverClasses.java Wed Apr 6 06:11:47 2011
@@ -40,7 +40,9 @@ public class DiscoverClasses<T> extends
* Sets the {@code Log} for this class.
*
* @param _log This class {@code Log}
+ * @deprecated This method is not thread-safe
*/
+ @Deprecated
public static void setLog(Log _log) {
log = _log;
}
Modified: commons/proper/discovery/trunk/src/java/org/apache/commons/discovery/resource/names/DiscoverMappedNames.java
URL: http://svn.apache.org/viewvc/commons/proper/discovery/trunk/src/java/org/apache/commons/discovery/resource/names/DiscoverMappedNames.java?rev=1089311&r1=1089310&r2=1089311&view=diff
==============================================================================
--- commons/proper/discovery/trunk/src/java/org/apache/commons/discovery/resource/names/DiscoverMappedNames.java (original)
+++ commons/proper/discovery/trunk/src/java/org/apache/commons/discovery/resource/names/DiscoverMappedNames.java Wed Apr 6 06:11:47 2011
@@ -42,7 +42,9 @@ public class DiscoverMappedNames extends
* Sets the {@code Log} for this class.
*
* @param _log This class {@code Log}
+ * @deprecated This method is not thread-safe
*/
+ @Deprecated
public static void setLog(Log _log) {
log = _log;
}
Modified: commons/proper/discovery/trunk/src/java/org/apache/commons/discovery/resource/names/DiscoverNamesInAlternateManagedProperties.java
URL: http://svn.apache.org/viewvc/commons/proper/discovery/trunk/src/java/org/apache/commons/discovery/resource/names/DiscoverNamesInAlternateManagedProperties.java?rev=1089311&r1=1089310&r2=1089311&view=diff
==============================================================================
--- commons/proper/discovery/trunk/src/java/org/apache/commons/discovery/resource/names/DiscoverNamesInAlternateManagedProperties.java (original)
+++ commons/proper/discovery/trunk/src/java/org/apache/commons/discovery/resource/names/DiscoverNamesInAlternateManagedProperties.java Wed Apr 6 06:11:47 2011
@@ -45,7 +45,9 @@ public class DiscoverNamesInAlternateMan
* Sets the {@code Log} for this class.
*
* @param _log This class {@code Log}
+ * @deprecated This method is not thread-safe
*/
+ @Deprecated
public static void setLog(Log _log) {
log = _log;
}
Modified: commons/proper/discovery/trunk/src/java/org/apache/commons/discovery/resource/names/DiscoverNamesInDictionary.java
URL: http://svn.apache.org/viewvc/commons/proper/discovery/trunk/src/java/org/apache/commons/discovery/resource/names/DiscoverNamesInDictionary.java?rev=1089311&r1=1089310&r2=1089311&view=diff
==============================================================================
--- commons/proper/discovery/trunk/src/java/org/apache/commons/discovery/resource/names/DiscoverNamesInDictionary.java (original)
+++ commons/proper/discovery/trunk/src/java/org/apache/commons/discovery/resource/names/DiscoverNamesInDictionary.java Wed Apr 6 06:11:47 2011
@@ -39,7 +39,9 @@ public class DiscoverNamesInDictionary e
* Sets the {@code Log} for this class.
*
* @param _log This class {@code Log}
+ * @deprecated This method is not thread-safe
*/
+ @Deprecated
public static void setLog(Log _log) {
log = _log;
}
Modified: commons/proper/discovery/trunk/src/java/org/apache/commons/discovery/resource/names/DiscoverNamesInFile.java
URL: http://svn.apache.org/viewvc/commons/proper/discovery/trunk/src/java/org/apache/commons/discovery/resource/names/DiscoverNamesInFile.java?rev=1089311&r1=1089310&r2=1089311&view=diff
==============================================================================
--- commons/proper/discovery/trunk/src/java/org/apache/commons/discovery/resource/names/DiscoverNamesInFile.java (original)
+++ commons/proper/discovery/trunk/src/java/org/apache/commons/discovery/resource/names/DiscoverNamesInFile.java Wed Apr 6 06:11:47 2011
@@ -53,7 +53,9 @@ public class DiscoverNamesInFile extends
* Sets the {@code Log} for this class.
*
* @param _log This class {@code Log}
+ * @deprecated This method is not thread-safe
*/
+ @Deprecated
public static void setLog(Log _log) {
log = _log;
}
Modified: commons/proper/discovery/trunk/src/java/org/apache/commons/discovery/resource/names/DiscoverNamesInManagedProperties.java
URL: http://svn.apache.org/viewvc/commons/proper/discovery/trunk/src/java/org/apache/commons/discovery/resource/names/DiscoverNamesInManagedProperties.java?rev=1089311&r1=1089310&r2=1089311&view=diff
==============================================================================
--- commons/proper/discovery/trunk/src/java/org/apache/commons/discovery/resource/names/DiscoverNamesInManagedProperties.java (original)
+++ commons/proper/discovery/trunk/src/java/org/apache/commons/discovery/resource/names/DiscoverNamesInManagedProperties.java Wed Apr 6 06:11:47 2011
@@ -34,7 +34,9 @@ public class DiscoverNamesInManagedPrope
* Sets the {@code Log} for this class.
*
* @param _log This class {@code Log}
+ * @deprecated This method is not thread-safe
*/
+ @Deprecated
public static void setLog(Log _log) {
log = _log;
}
Modified: commons/proper/discovery/trunk/src/java/org/apache/commons/discovery/resource/names/DiscoverNamesInSystemProperties.java
URL: http://svn.apache.org/viewvc/commons/proper/discovery/trunk/src/java/org/apache/commons/discovery/resource/names/DiscoverNamesInSystemProperties.java?rev=1089311&r1=1089310&r2=1089311&view=diff
==============================================================================
--- commons/proper/discovery/trunk/src/java/org/apache/commons/discovery/resource/names/DiscoverNamesInSystemProperties.java (original)
+++ commons/proper/discovery/trunk/src/java/org/apache/commons/discovery/resource/names/DiscoverNamesInSystemProperties.java Wed Apr 6 06:11:47 2011
@@ -32,7 +32,9 @@ public class DiscoverNamesInSystemProper
* Sets the {@code Log} for this class.
*
* @param _log This class {@code Log}
+ * @deprecated This method is not thread-safe
*/
+ @Deprecated
public static void setLog(Log _log) {
log = _log;
}
Modified: commons/proper/discovery/trunk/src/java/org/apache/commons/discovery/resource/names/NameDiscoverers.java
URL: http://svn.apache.org/viewvc/commons/proper/discovery/trunk/src/java/org/apache/commons/discovery/resource/names/NameDiscoverers.java?rev=1089311&r1=1089310&r2=1089311&view=diff
==============================================================================
--- commons/proper/discovery/trunk/src/java/org/apache/commons/discovery/resource/names/NameDiscoverers.java (original)
+++ commons/proper/discovery/trunk/src/java/org/apache/commons/discovery/resource/names/NameDiscoverers.java Wed Apr 6 06:11:47 2011
@@ -38,7 +38,9 @@ public class NameDiscoverers extends Res
* Sets the {@code Log} for this class.
*
* @param _log This class {@code Log}
+ * @deprecated This method is not thread-safe
*/
+ @Deprecated
public static void setLog(Log _log) {
log = _log;
}
Modified: commons/proper/discovery/trunk/src/java/org/apache/commons/discovery/tools/ClassUtils.java
URL: http://svn.apache.org/viewvc/commons/proper/discovery/trunk/src/java/org/apache/commons/discovery/tools/ClassUtils.java?rev=1089311&r1=1089310&r2=1089311&view=diff
==============================================================================
--- commons/proper/discovery/trunk/src/java/org/apache/commons/discovery/tools/ClassUtils.java (original)
+++ commons/proper/discovery/trunk/src/java/org/apache/commons/discovery/tools/ClassUtils.java Wed Apr 6 06:11:47 2011
@@ -36,7 +36,9 @@ public class ClassUtils {
* Sets the {@code Log} for this class.
*
* @param _log This class {@code Log}
+ * @deprecated This method is not thread-safe
*/
+ @Deprecated
public static void setLog(Log _log) {
log = _log;
}
Modified: commons/proper/discovery/trunk/src/java/org/apache/commons/discovery/tools/ManagedProperties.java
URL: http://svn.apache.org/viewvc/commons/proper/discovery/trunk/src/java/org/apache/commons/discovery/tools/ManagedProperties.java?rev=1089311&r1=1089310&r2=1089311&view=diff
==============================================================================
--- commons/proper/discovery/trunk/src/java/org/apache/commons/discovery/tools/ManagedProperties.java (original)
+++ commons/proper/discovery/trunk/src/java/org/apache/commons/discovery/tools/ManagedProperties.java Wed Apr 6 06:11:47 2011
@@ -83,7 +83,9 @@ public class ManagedProperties {
* Sets the {@code Log} for this class.
*
* @param _log This class {@code Log}
+ * @deprecated This method is not thread-safe
*/
+ @Deprecated
public static void setLog(Log _log) {
log = _log;
}