You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Nitin Galave <ni...@gmail.com> on 2019/04/08 10:53:58 UTC

Review Request 70424: RANGER-2399:User's listing page hits users API call twice from UI

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70424/
-----------------------------------------------------------

Review request for ranger, Mehul Parikh, Nikhil P, Pradeep Agrawal, and Velmurugan Periasamy.


Bugs: RANGER-2399
    https://issues.apache.org/jira/browse/RANGER-2399


Repository: ranger


Description
-------

Steps: Login and go to users/group tab
1. Click on username name link and open user update page
2. And go back to user's listing page.
See user API call hit twice. The unnecessary call needs to be removed from UI


Diffs
-----

  security-admin/src/main/webapp/scripts/controllers/Controller.js 934a1a2 
  security-admin/src/main/webapp/scripts/views/security_zone/SecurityZone.js a1e9716 
  security-admin/src/main/webapp/scripts/views/users/GroupCreate.js a764387 
  security-admin/src/main/webapp/scripts/views/users/UserCreate.js e1afff1 
  security-admin/src/main/webapp/scripts/views/users/UserTableLayout.js 94afd75 
  security-admin/src/main/webapp/styles/xa.css f90f21b 
  security-admin/src/main/webapp/templates/common/breadcrumbs.html 8de0ad3 
  security-admin/src/main/webapp/templates/security_zone/SecurityZone_tmpl.html f0b2572 


Diff: https://reviews.apache.org/r/70424/diff/1/


Testing
-------

1. Verified that multiple API Call does not get generated for single request. e.g. On creation/edit/cancel of User/Group.
2. Zone name title displays properly in case of having long zone name, Verified on Zone listing page, Zone name header, Zone breadcrumb.


Thanks,

Nitin Galave


Re: Review Request 70424: RANGER-2399:User's listing page hits users API call twice from UI

Posted by Pradeep Agrawal <pr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70424/#review214520
-----------------------------------------------------------


Ship it!




Ship It!

- Pradeep Agrawal


On April 8, 2019, 10:58 a.m., Nitin Galave wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70424/
> -----------------------------------------------------------
> 
> (Updated April 8, 2019, 10:58 a.m.)
> 
> 
> Review request for ranger, Mehul Parikh, Nikhil P, Pradeep Agrawal, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2399
>     https://issues.apache.org/jira/browse/RANGER-2399
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> #issue 1
> Steps: Login and go to users/group tab
> 1. Click on username name link and open user update page
> 2. And go back to user's listing page.
> See user API call hit twice. The unnecessary call needs to be removed from UI
> 
> #issue 2
> 2. Zonename title placement on zone listing page to be checked when zone name is long
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/webapp/scripts/controllers/Controller.js 934a1a2 
>   security-admin/src/main/webapp/scripts/views/security_zone/SecurityZone.js a1e9716 
>   security-admin/src/main/webapp/scripts/views/users/GroupCreate.js a764387 
>   security-admin/src/main/webapp/scripts/views/users/UserCreate.js e1afff1 
>   security-admin/src/main/webapp/scripts/views/users/UserTableLayout.js 94afd75 
>   security-admin/src/main/webapp/styles/xa.css f90f21b 
>   security-admin/src/main/webapp/templates/common/breadcrumbs.html 8de0ad3 
>   security-admin/src/main/webapp/templates/security_zone/SecurityZone_tmpl.html f0b2572 
> 
> 
> Diff: https://reviews.apache.org/r/70424/diff/1/
> 
> 
> Testing
> -------
> 
> 1. Verified that multiple API Call does not get generated for single request. e.g. On creation/edit/cancel of User/Group.
> 2. Zone name title displays properly in case of having long zone name, Verified on Zone listing page, Zone name header, Zone breadcrumb.
> 
> 
> Thanks,
> 
> Nitin Galave
> 
>


Re: Review Request 70424: RANGER-2399:User's listing page hits users API call twice from UI

Posted by Mehul Parikh <me...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70424/#review214494
-----------------------------------------------------------


Ship it!




Ship It!

- Mehul Parikh


On April 8, 2019, 10:58 a.m., Nitin Galave wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70424/
> -----------------------------------------------------------
> 
> (Updated April 8, 2019, 10:58 a.m.)
> 
> 
> Review request for ranger, Mehul Parikh, Nikhil P, Pradeep Agrawal, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2399
>     https://issues.apache.org/jira/browse/RANGER-2399
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> #issue 1
> Steps: Login and go to users/group tab
> 1. Click on username name link and open user update page
> 2. And go back to user's listing page.
> See user API call hit twice. The unnecessary call needs to be removed from UI
> 
> #issue 2
> 2. Zonename title placement on zone listing page to be checked when zone name is long
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/webapp/scripts/controllers/Controller.js 934a1a2 
>   security-admin/src/main/webapp/scripts/views/security_zone/SecurityZone.js a1e9716 
>   security-admin/src/main/webapp/scripts/views/users/GroupCreate.js a764387 
>   security-admin/src/main/webapp/scripts/views/users/UserCreate.js e1afff1 
>   security-admin/src/main/webapp/scripts/views/users/UserTableLayout.js 94afd75 
>   security-admin/src/main/webapp/styles/xa.css f90f21b 
>   security-admin/src/main/webapp/templates/common/breadcrumbs.html 8de0ad3 
>   security-admin/src/main/webapp/templates/security_zone/SecurityZone_tmpl.html f0b2572 
> 
> 
> Diff: https://reviews.apache.org/r/70424/diff/1/
> 
> 
> Testing
> -------
> 
> 1. Verified that multiple API Call does not get generated for single request. e.g. On creation/edit/cancel of User/Group.
> 2. Zone name title displays properly in case of having long zone name, Verified on Zone listing page, Zone name header, Zone breadcrumb.
> 
> 
> Thanks,
> 
> Nitin Galave
> 
>


Re: Review Request 70424: RANGER-2399:User's listing page hits users API call twice from UI

Posted by Nitin Galave <ni...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70424/
-----------------------------------------------------------

(Updated April 8, 2019, 10:58 a.m.)


Review request for ranger, Mehul Parikh, Nikhil P, Pradeep Agrawal, and Velmurugan Periasamy.


Bugs: RANGER-2399
    https://issues.apache.org/jira/browse/RANGER-2399


Repository: ranger


Description (updated)
-------

#issue 1
Steps: Login and go to users/group tab
1. Click on username name link and open user update page
2. And go back to user's listing page.
See user API call hit twice. The unnecessary call needs to be removed from UI

#issue 2
2. Zonename title placement on zone listing page to be checked when zone name is long


Diffs
-----

  security-admin/src/main/webapp/scripts/controllers/Controller.js 934a1a2 
  security-admin/src/main/webapp/scripts/views/security_zone/SecurityZone.js a1e9716 
  security-admin/src/main/webapp/scripts/views/users/GroupCreate.js a764387 
  security-admin/src/main/webapp/scripts/views/users/UserCreate.js e1afff1 
  security-admin/src/main/webapp/scripts/views/users/UserTableLayout.js 94afd75 
  security-admin/src/main/webapp/styles/xa.css f90f21b 
  security-admin/src/main/webapp/templates/common/breadcrumbs.html 8de0ad3 
  security-admin/src/main/webapp/templates/security_zone/SecurityZone_tmpl.html f0b2572 


Diff: https://reviews.apache.org/r/70424/diff/1/


Testing
-------

1. Verified that multiple API Call does not get generated for single request. e.g. On creation/edit/cancel of User/Group.
2. Zone name title displays properly in case of having long zone name, Verified on Zone listing page, Zone name header, Zone breadcrumb.


Thanks,

Nitin Galave