[jira] [Commented] (ZOOKEEPER-1269) Multi deserialization issues

["Camille Fournier (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13138796#comment-13138796 ] 

Camille Fournier commented on ZOOKEEPER-1269:
---------------------------------------------

The test here is a little bit vague, because I don't really understand how a "proper" but broken multitxn would look. Handling the error codes in FileTxnSnapLog is also a bit fuzzy. But I think the general refactor should fix the issue. Would be great if Marshall could take a look at this to verify.
                
> Multi deserialization issues
> ----------------------------
>
>                 Key: ZOOKEEPER-1269
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1269
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: server
>    Affects Versions: 3.4.0
>            Reporter: Camille Fournier
>         Attachments: ZOOKEEPER-1269.patch
>
>
> From the mailing list:
> FileTxnSnapLog.restore contains a code block handling a NODEEXISTS failure during deserialization. The problem is explained there in a code comment. The code block however is only executed for a CREATE txn, not for a multiTxn containing a CREATE.
> Even if the mentioned code block would also be executed for multi transactions, it needs adaption for multi transactions. What, if after the first failed transaction in a multi txn during deserialization, there would be subsequent transactions in the same multi that would also have failed?
> We don't know, since the first failed transaction hides the information about the remaining transactions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira