You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/01/16 12:26:56 UTC
[GitHub] GJL commented on a change in pull request #7447: [FLINK-11294]
[test] Remove legacy JobInfo usage in valid tests
GJL commented on a change in pull request #7447: [FLINK-11294] [test] Remove legacy JobInfo usage in valid tests
URL: https://github.com/apache/flink/pull/7447#discussion_r248261125
##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/jobmanager/ZooKeeperSubmittedJobGraphsStoreITCase.java
##########
@@ -114,7 +112,7 @@ public void testPutAndRemoveJobGraph() throws Exception {
verifyJobGraphs(jobGraph, jobGraphs.recoverJobGraph(jobId));
// Update (same ID)
- jobGraph = createSubmittedJobGraph(jobGraph.getJobId(), 1);
+ jobGraph = createSubmittedJobGraph(jobGraph.getJobId(), "Updated JobName");
Review comment:
Is it important to change the job name for this test?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services