[GitHub] [incubator-devlake] mindlesscloud opened a new pull request, #2654: fix: add NoPKModel to commit_parents

[GitBox <gi...@apache.org>]

mindlesscloud opened a new pull request, #2654:
URL: https://github.com/apache/incubator-devlake/pull/2654

   # Summary
   
   fix #2650 ([Bug][GitExtractor] Some commits are missing during collectGitCommits)
   When the first `commit` came in,
   several lines of buggy code hid an error.
   ```go
   if err != r.storeParentCommits(commitSha, commit) {
             return err
   }
   ```
   Which caused an interruption in the execution process. So the first `commit` can not be saved to the database.
   It won't happen again from the second `commit`, due to the nature of `BatchSaveDivider.ForType`
   
   
   ### Does this close any open issues?
   close #2650 
   
   ### Screenshots
   Include any relevant screenshots here.
   
   ### Other Information
   Any other information that is important to this PR.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-devlake] klesh merged pull request #2654: fix: add NoPKModel to commit_parents

[GitBox <gi...@apache.org>]

klesh merged PR #2654:
URL: https://github.com/apache/incubator-devlake/pull/2654


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org