[GitHub] [cassandra] dcapwell commented on a change in pull request #772: Fix NPEs when 3.0 messages get re-serialized for filtering on 4.0 nod…

[GitBox <gi...@apache.org>]

dcapwell commented on a change in pull request #772:
URL: https://github.com/apache/cassandra/pull/772#discussion_r503613235



##########
File path: test/distributed/org/apache/cassandra/distributed/upgrade/UpgradeTest.java
##########
@@ -53,4 +50,32 @@ public void upgradeTest() throws Throwable
                        row(1, 3, 3));
         }).run();
     }
+
+    @Test
+    public void reserializationDuringUpgradeFrom30() throws Throwable

Review comment:
       this test is a dup of the previous test, the only diff is it only upgrades a single node rather than one at a time.  Can we remove this?  The other test replicated the issue being fixed so don't think we need this.

##########
File path: test/distributed/org/apache/cassandra/distributed/upgrade/UpgradeTest.java
##########
@@ -34,10 +35,6 @@ public void upgradeTest() throws Throwable
         .upgrade(Versions.Major.v22, Versions.Major.v30, Versions.Major.v3X)
         .upgrade(Versions.Major.v30, Versions.Major.v3X, Versions.Major.v4)
         .setup((cluster) -> {
-            //TODO fix - this is a jvm-dtest bug where we get null when we want the NoPayload object

Review comment:
       glad you saw that =)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org