You are viewing a plain text version of this content. The canonical link for it is here.
Posted to general@incubator.apache.org by peacewong <pe...@apache.org> on 2022/05/11 07:12:30 UTC

[VOTE] Release Apache Linkis (Incubating) 1.1.1-RC1

Hello Incubator Community,

    This is a call for a vote to release Apache Linkis(Incubating) version
1.1.1-RC1

    The Apache Linkis community has voted on and approved a proposal to release
    Apache Linkis(Incubating) version  1.1.1-RC1

    We now kindly request the Incubator PMC members review and vote on this
    incubator release.

    Linkis community vote thread:
        • https://lists.apache.org/thread/2dfjxbslwtftmo151wx4zrrs78zctk5t
<https://lists.apache.org/thread/2dfjxbslwtftmo151wx4zrrs78zctk5t>

    Vote result thread:
        • https://lists.apache.org/thread/xlndh0p9bk4w5v72nmbjqoqmt6sbwtf0

    The release candidate:
        • https://dist.apache.org/repos/dist/dev/incubator/linkis/1.1.1-RC1/
<https://dist.apache.org/repos/dist/dev/incubator/linkis/1.1.1-RC1/>

    Git tag for the release:
        •
https://github.com/apache/incubator-linkis/releases/tag/release-1.1.1-rc1

    Release notes:
        •  https://linkis.apache.org/docs/1.1.1/release-notes-1.1.1/

    The artifacts signed with PGP key [ 38C76105 ], corresponding to [
peacewong@apache.com], that can be found in keys file:
        • https://downloads.apache.org/incubator/linkis/KEYS



This is the first non DISCLAIMER-WIP version after joining the ASF incubator


    The vote will be open for at least 72 hours or until necessary
number of votes are reached.

    Please vote accordingly:

    [ ] +1 approve
    [ ] +0 no opinion
    [ ] -1 disapprove with the reason

    More detail checklist  please refer:
        •
https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist

    Steps to validate the release,Please refer to:
        • https://linkis.apache.org/community/how-to-verify

Thanks,
On behalf of Apache Linkis(Incubating) community

Re: [VOTE] Release Apache Linkis (Incubating) 1.1.1-RC1

Posted by ShaoFeng Shi <sh...@apache.org>.
+1 binding

I checked:
- signed by IPMC member;
- LICENSE and NOTICE are presented;
- SHA512 is good;
- compile is successful with JDK8 and Maven 3.6.3 in my local;

While there is a small suggestion: a guide about how to compile the source
package is needed on the "Download" page. I get that on the "how-to-verify"
page which is not easy to find.

Best regards,

Shaofeng Shi 史少锋
Apache Kylin PMC,
Apache Incubator PMC,
Email: shaofengshi@apache.org

Apache Kylin FAQ: https://kylin.apache.org/docs/gettingstarted/faq.html
Join Kylin user mail group: user-subscribe@kylin.apache.org
Join Kylin dev mail group: dev-subscribe@kylin.apache.org




peacewong <pe...@apache.org> 于2022年5月13日周五 10:39写道:

> Dear IPMC,
>
> We still need two more votes from IPMC members for this new release.
> Please kindly help to review and vote, thanks you very much!
>
> Peace wong
> Best Regards.
>
> casion@apache.org <ca...@apache.org> 于2022年5月12日周四 19:58写道:
>
> > Copy my +1 from dev@linkis (non-binding)
> >
> > Best Regards!
> >
> > Chen Xia
> >
> >
> > peacewong <pe...@apache.org> 于2022年5月11日周三 15:13写道:
> >
> > > Hello Incubator Community,
> > >
> > >     This is a call for a vote to release Apache Linkis(Incubating)
> > version
> > > 1.1.1-RC1
> > >
> > >     The Apache Linkis community has voted on and approved a proposal to
> > > release
> > >     Apache Linkis(Incubating) version  1.1.1-RC1
> > >
> > >     We now kindly request the Incubator PMC members review and vote on
> > this
> > >     incubator release.
> > >
> > >     Linkis community vote thread:
> > >         •
> > https://lists.apache.org/thread/2dfjxbslwtftmo151wx4zrrs78zctk5t
> > > <https://lists.apache.org/thread/2dfjxbslwtftmo151wx4zrrs78zctk5t>
> > >
> > >     Vote result thread:
> > >         •
> > https://lists.apache.org/thread/xlndh0p9bk4w5v72nmbjqoqmt6sbwtf0
> > >
> > >     The release candidate:
> > >         •
> > > https://dist.apache.org/repos/dist/dev/incubator/linkis/1.1.1-RC1/
> > > <https://dist.apache.org/repos/dist/dev/incubator/linkis/1.1.1-RC1/>
> > >
> > >     Git tag for the release:
> > >         •
> > >
> >
> https://github.com/apache/incubator-linkis/releases/tag/release-1.1.1-rc1
> > >
> > >     Release notes:
> > >         •  https://linkis.apache.org/docs/1.1.1/release-notes-1.1.1/
> > >
> > >     The artifacts signed with PGP key [ 38C76105 ], corresponding to [
> > > peacewong@apache.com], that can be found in keys file:
> > >         • https://downloads.apache.org/incubator/linkis/KEYS
> > >
> > >
> > >
> > > This is the first non DISCLAIMER-WIP version after joining the ASF
> > > incubator
> > >
> > >
> > >     The vote will be open for at least 72 hours or until necessary
> > > number of votes are reached.
> > >
> > >     Please vote accordingly:
> > >
> > >     [ ] +1 approve
> > >     [ ] +0 no opinion
> > >     [ ] -1 disapprove with the reason
> > >
> > >     More detail checklist  please refer:
> > >         •
> > >
> > >
> >
> https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist
> > >
> > >     Steps to validate the release,Please refer to:
> > >         • https://linkis.apache.org/community/how-to-verify
> > >
> > > Thanks,
> > > On behalf of Apache Linkis(Incubating) community
> > >
> >
>

Re: [VOTE] Release Apache Linkis (Incubating) 1.1.1-RC1

Posted by "casion@apache.org" <ca...@apache.org>.
 Hi Justin,

Thanks for your reminder,

About "how contributions to the project are licensed",I found some
useful information:

According to py4j CONTRIBUTING.rst[1]:
"Py4J does not have an official Contributor License Agreement (CLA),
but it is assumed that as soon as you make a contribution (patch, code
suggestion through any medium, pull requests) to Py4J, you accept that
your code will be redistributed under the current license used by
Py4J, i.e., the new BSD license. This is an irrevocable right to
ensure that developers can use Py4J without the fear of seeing parts
removed in the future."

All code file will be redistributed under the new BSD license.

By the way, we have upgraded the py4j version to py4j-0.10.7-src.zip, and
the backport.py file is removed.

According to the requirements of py4j's LICENSE[2],
We have added the license description of py4j[3] and the license
file[4] in the project source code.

[1]https://github.com/py4j/py4j/blob/master/CONTRIBUTING.rst
[2]https://github.com/py4j/py4j/blob/master/LICENSE.txt
[3]https://github.com/apache/incubator-linkis/blob/dev-1.1.1/LICENSE
[4]
https://github.com/apache/incubator-linkis/blob/dev-1.1.1/licenses/LICENSE-py4j-0.10.9.5-src.txt


Best Regards!

Chen Xia


Justin Mclean <ju...@classsoftware.com> 于2022年5月17日周二 06:04写道:

> Hi,
>
> > But the py file is still missing license headers and have different
> > authors[2]. We don't know how to solve this problem.
>
> You may need to look at the history f the files to see if that provide
> some clues or how contributions to the project are licensed. You could also
> contact the project and ask them how the files are licensed.
>
> Kind Regards,
> Justin
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
>

Re: [VOTE] Release Apache Linkis (Incubating) 1.1.1-RC1

Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,

> But the py file is still missing license headers and have different
> authors[2]. We don't know how to solve this problem.

You may need to look at the history f the files to see if that provide some clues or how contributions to the project are licensed. You could also contact the project and ask them how the files are licensed.

Kind Regards,
Justin


---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org


Re: [VOTE] Release Apache Linkis (Incubating) 1.1.1-RC1

Posted by "casion@apache.org" <ca...@apache.org>.
Hi Justin

We found that the new version of py4j has removed the backport.py file, so
after our evaluation, we upgraded the py4j version to
py4j-0.10.7-src.zip[1].

But the py file is still missing license headers and have different
authors[2]. We don't know how to solve this problem.

[1] https://github.com/apache/incubator-linkis/pull/2113
[2] https://github.com/py4j/py4j/tree/0.10.9.5/py4j-python/src/py4j



Best Regards!
Casion


Justin Mclean <ju...@classsoftware.com> 于2022年5月13日周五 17:05写道:

> Hi,
>
> >> I confirmed in the py4j-0.10.7-src.zip file, and the backport.py file
> >> clearly states that it is all licensed under the PSF License.
> >>
> >> So can it be considered that py4j-0.10.7-src.zip is licensed under
> >> BDS license, except that backport.py is under PSF license
>
> I would double check the license of the other files as they are missing
> headers and have different authors.
>
> Kind Regards,
> Justin
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
>

Re: [VOTE] Release Apache Linkis (Incubating) 1.1.1-RC1

Posted by "casion@apache.org" <ca...@apache.org>.
Hi  Justin

I also find that other projects also have this issue such as spark[1] ,
flink[2] and so on.
Is it necessary to start a new thread email to discuss this?
Looking forward to your further reply.

[1]
https://github.com/apache/spark/blob/master/python/lib/py4j-0.10.9.5-src.zip
[2]
https://github.com/apache/flink/tree/99c2a415e9eeefafacf70762b6f54070f7911ceb/flink-python/lib

Best Regards!
Casion


Justin Mclean <ju...@classsoftware.com> 于2022年5月13日周五 17:05写道:

> Hi,
>
> >> I confirmed in the py4j-0.10.7-src.zip file, and the backport.py file
> >> clearly states that it is all licensed under the PSF License.
> >>
> >> So can it be considered that py4j-0.10.7-src.zip is licensed under
> >> BDS license, except that backport.py is under PSF license
>
> I would double check the license of the other files as they are missing
> headers and have different authors.
>
> Kind Regards,
> Justin
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
Best Regards!

Chen Xia


Justin Mclean <ju...@classsoftware.com> 于2022年5月13日周五 17:05写道:

> Hi,
>
> >> I confirmed in the py4j-0.10.7-src.zip file, and the backport.py file
> >> clearly states that it is all licensed under the PSF License.
> >>
> >> So can it be considered that py4j-0.10.7-src.zip is licensed under
> >> BDS license, except that backport.py is under PSF license
>
> I would double check the license of the other files as they are missing
> headers and have different authors.
>
> Kind Regards,
> Justin
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
>

Re: [VOTE] Release Apache Linkis (Incubating) 1.1.1-RC1

Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,

>> I confirmed in the py4j-0.10.7-src.zip file, and the backport.py file
>> clearly states that it is all licensed under the PSF License.
>> 
>> So can it be considered that py4j-0.10.7-src.zip is licensed under
>> BDS license, except that backport.py is under PSF license

I would double check the license of the other files as they are missing headers and have different authors.

Kind Regards,
Justin
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org


Re: [VOTE] Release Apache Linkis (Incubating) 1.1.1-RC1

Posted by "casion@apache.org" <ca...@apache.org>.
>
> Hi  Justin
>


> I confirmed in the py4j-0.10.7-src.zip file, and the backport.py file
> clearly states that it is all licensed under the PSF License.
>
> So can it be considered that py4j-0.10.7-src.zip is licensed under
> BDS license, except that backport.py is under PSF license
>
> In this case, is it okay to have a separate description for the license of
> the backport.py file?
>
> Best Regards!
>
> Casion
>
>
> Justin Mclean <ju...@classsoftware.com> 于2022年5月13日周五 16:05写道:
>
>> Hi,
>>
>> > 2. LICENSE is missing license from files in this zip It’s looks like
>> > they are under the PSF License not the BSD license.
>> > The license of the file py4j-0.10.7-src.zip does specify the BSD
>> > license on their official website [1]
>> > We specify py4j-0.10.7-src.zip in the LICENSE file under BSD licenses
>> [2][3]
>>
>> The header of backport.py states:
>> "Backported functions from later versions of python (mostly 2.7) These
>> functions are all licensed under the PSF License."
>>
>> Kind Regards,
>> Justin
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
>> For additional commands, e-mail: general-help@incubator.apache.org
>>
>

Re: [VOTE] Release Apache Linkis (Incubating) 1.1.1-RC1

Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,

> 2. LICENSE is missing license from files in this zip It’s looks like
> they are under the PSF License not the BSD license.
> The license of the file py4j-0.10.7-src.zip does specify the BSD
> license on their official website [1]
> We specify py4j-0.10.7-src.zip in the LICENSE file under BSD licenses [2][3]

The header of backport.py states:
"Backported functions from later versions of python (mostly 2.7) These functions are all licensed under the PSF License."

Kind Regards,
Justin
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org


Re: [VOTE] Release Apache Linkis (Incubating) 1.1.1-RC1

Posted by peacewong <pe...@apache.org>.
Hi  Justin
Thanks for the checking and guidances. I'd cancel this vote here, will
re-initiate a vote after solved the problems you indicated.
Thanks again for helping Linkis become a better, more Apache Way compliant
project :)

Regarding the issue you mentioned, we will make the following improvements:

1. I also notice you have 5 mentors, have you asked them to check the release?
Yes, we have request mentors to check the 1.1.1-RC1 version.
2. LICENSE is missing license from files in this zip It’s looks like
they are under the PSF License not the BSD license.
The license of the file py4j-0.10.7-src.zip does specify the BSD
license on their official website [1]
We specify py4j-0.10.7-src.zip in the LICENSE file under BSD licenses [2][3]

3. A binary file containing compelled code exists in the source release
Referring to the "the case of the maven wrapper" mail discussed[4],We
will remove the maven-wrapper.jar file from the source release

4. BTW Also looks like mvnw has the wrong line endings.
Thanks, we will fix this encoding issue

Kind Regards,
PeaceWong

1. https://github.com/py4j/py4j/tree/0.10.7
2. https://github.com/apache/incubator-linkis/blob/release-1.1.1-rc1/LICENSE
3.
https://github.com/apache/incubator-linkis/blob/release-1.1.1-rc1/linkis-engineconn-plugins/engineconn-plugins/python/src/main/py4j/LICENSE-py4j-0.10.7-src.txt
4. https://lists.apache.org/thread/rwzlx5l0046rcl4zz92m0q8p3mn1xc6r

Justin Mclean <ju...@classsoftware.com> 于2022年5月13日周五 12:07写道:

> Hi,
>
> Sorry but it’s -1 binding from me as there a binary in the source release.
> There’s also a minor license issue.
>
> I also notice you have 5 mentors, have you asked them to check the release?
>
> It also looks like to me that the binary license and notice file are
> listing all dependancies rather than only what is included in those
> releases but I didn’t do a detailed check.
>
> I checked:
> - incubating in release name
> - DISCLAIMER exits
> - LICENSE is missing license from files in this zip [2] It’s looks like
> they are under the PSF License not the BSD license.
> - NOTICE is fine
> - All files have ASF headers except where noted
> - A binary file containing compelled code exists in the source release [1]
> - I was able to compile from source
>
> It would be nice to see some instruction on compiling in the README.
> Putting a link to a webpage may not work in the future as the contents of
> that page are likely to change over time.
>
> BTW Also looks like mvnw has the wrong line endings.
> ./mvnw
> -bash: ./mvnw: /bin/sh^M: bad interpreter: No such file or directory
>
> Kind Regards,
> Justin
>
> 1. ./.mvn/wrapper/maven-wrapper.jar
> 2.
> ./linkis-engineconn-plugins/engineconn-plugins/python/src/main/py4j/py4j-0.10.7-src.zip
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
>

Re: [VOTE] Release Apache Linkis (Incubating) 1.1.1-RC1

Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,

Sorry but it’s -1 binding from me as there a binary in the source release. There’s also a minor license issue.

I also notice you have 5 mentors, have you asked them to check the release?

It also looks like to me that the binary license and notice file are listing all dependancies rather than only what is included in those releases but I didn’t do a detailed check.

I checked:
- incubating in release name
- DISCLAIMER exits
- LICENSE is missing license from files in this zip [2] It’s looks like they are under the PSF License not the BSD license.
- NOTICE is fine
- All files have ASF headers except where noted
- A binary file containing compelled code exists in the source release [1]
- I was able to compile from source

It would be nice to see some instruction on compiling in the README. Putting a link to a webpage may not work in the future as the contents of that page are likely to change over time.

BTW Also looks like mvnw has the wrong line endings.
./mvnw 
-bash: ./mvnw: /bin/sh^M: bad interpreter: No such file or directory

Kind Regards,
Justin

1. ./.mvn/wrapper/maven-wrapper.jar
2.  ./linkis-engineconn-plugins/engineconn-plugins/python/src/main/py4j/py4j-0.10.7-src.zip


---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org


Re: [VOTE] Release Apache Linkis (Incubating) 1.1.1-RC1

Posted by peacewong <pe...@apache.org>.
Dear IPMC,

We still need two more votes from IPMC members for this new release.
Please kindly help to review and vote, thanks you very much!

Peace wong
Best Regards.

casion@apache.org <ca...@apache.org> 于2022年5月12日周四 19:58写道:

> Copy my +1 from dev@linkis (non-binding)
>
> Best Regards!
>
> Chen Xia
>
>
> peacewong <pe...@apache.org> 于2022年5月11日周三 15:13写道:
>
> > Hello Incubator Community,
> >
> >     This is a call for a vote to release Apache Linkis(Incubating)
> version
> > 1.1.1-RC1
> >
> >     The Apache Linkis community has voted on and approved a proposal to
> > release
> >     Apache Linkis(Incubating) version  1.1.1-RC1
> >
> >     We now kindly request the Incubator PMC members review and vote on
> this
> >     incubator release.
> >
> >     Linkis community vote thread:
> >         •
> https://lists.apache.org/thread/2dfjxbslwtftmo151wx4zrrs78zctk5t
> > <https://lists.apache.org/thread/2dfjxbslwtftmo151wx4zrrs78zctk5t>
> >
> >     Vote result thread:
> >         •
> https://lists.apache.org/thread/xlndh0p9bk4w5v72nmbjqoqmt6sbwtf0
> >
> >     The release candidate:
> >         •
> > https://dist.apache.org/repos/dist/dev/incubator/linkis/1.1.1-RC1/
> > <https://dist.apache.org/repos/dist/dev/incubator/linkis/1.1.1-RC1/>
> >
> >     Git tag for the release:
> >         •
> >
> https://github.com/apache/incubator-linkis/releases/tag/release-1.1.1-rc1
> >
> >     Release notes:
> >         •  https://linkis.apache.org/docs/1.1.1/release-notes-1.1.1/
> >
> >     The artifacts signed with PGP key [ 38C76105 ], corresponding to [
> > peacewong@apache.com], that can be found in keys file:
> >         • https://downloads.apache.org/incubator/linkis/KEYS
> >
> >
> >
> > This is the first non DISCLAIMER-WIP version after joining the ASF
> > incubator
> >
> >
> >     The vote will be open for at least 72 hours or until necessary
> > number of votes are reached.
> >
> >     Please vote accordingly:
> >
> >     [ ] +1 approve
> >     [ ] +0 no opinion
> >     [ ] -1 disapprove with the reason
> >
> >     More detail checklist  please refer:
> >         •
> >
> >
> https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist
> >
> >     Steps to validate the release,Please refer to:
> >         • https://linkis.apache.org/community/how-to-verify
> >
> > Thanks,
> > On behalf of Apache Linkis(Incubating) community
> >
>

Re: [VOTE] Release Apache Linkis (Incubating) 1.1.1-RC1

Posted by "casion@apache.org" <ca...@apache.org>.
Copy my +1 from dev@linkis (non-binding)

Best Regards!

Chen Xia


peacewong <pe...@apache.org> 于2022年5月11日周三 15:13写道:

> Hello Incubator Community,
>
>     This is a call for a vote to release Apache Linkis(Incubating) version
> 1.1.1-RC1
>
>     The Apache Linkis community has voted on and approved a proposal to
> release
>     Apache Linkis(Incubating) version  1.1.1-RC1
>
>     We now kindly request the Incubator PMC members review and vote on this
>     incubator release.
>
>     Linkis community vote thread:
>         • https://lists.apache.org/thread/2dfjxbslwtftmo151wx4zrrs78zctk5t
> <https://lists.apache.org/thread/2dfjxbslwtftmo151wx4zrrs78zctk5t>
>
>     Vote result thread:
>         • https://lists.apache.org/thread/xlndh0p9bk4w5v72nmbjqoqmt6sbwtf0
>
>     The release candidate:
>         •
> https://dist.apache.org/repos/dist/dev/incubator/linkis/1.1.1-RC1/
> <https://dist.apache.org/repos/dist/dev/incubator/linkis/1.1.1-RC1/>
>
>     Git tag for the release:
>         •
> https://github.com/apache/incubator-linkis/releases/tag/release-1.1.1-rc1
>
>     Release notes:
>         •  https://linkis.apache.org/docs/1.1.1/release-notes-1.1.1/
>
>     The artifacts signed with PGP key [ 38C76105 ], corresponding to [
> peacewong@apache.com], that can be found in keys file:
>         • https://downloads.apache.org/incubator/linkis/KEYS
>
>
>
> This is the first non DISCLAIMER-WIP version after joining the ASF
> incubator
>
>
>     The vote will be open for at least 72 hours or until necessary
> number of votes are reached.
>
>     Please vote accordingly:
>
>     [ ] +1 approve
>     [ ] +0 no opinion
>     [ ] -1 disapprove with the reason
>
>     More detail checklist  please refer:
>         •
>
> https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist
>
>     Steps to validate the release,Please refer to:
>         • https://linkis.apache.org/community/how-to-verify
>
> Thanks,
> On behalf of Apache Linkis(Incubating) community
>