You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "sarthaksin1857 (via GitHub)" <gi...@apache.org> on 2026/05/20 15:03:35 UTC

[PR] Add custom error handling to SupportsBulkOperations [iceberg]

sarthaksin1857 opened a new pull request, #16444:
URL: https://github.com/apache/iceberg/pull/16444

   ## What
   If you use the FileIo interface, and call a function which throws `SupportsBulkOperations` you are often left with a stack trace without any meaningful information to act on. 
   
   This PR adds 
   
   1. FailureHandler interface which all exceptions during bulk operations go into. Custom implementations can build their own way to classify and handle errors during bulk operations
   2. FailureCategory as a cloud agnostic "buckets" errors can be put into 
   3. AWS, Azure, GCP classifications based on their documentation
   
   
   The point of this is to not "force" any classification on errors but give callers all the information they need to be able to figure out what an error means in their context


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Core, AWS, Azure, GCP: Add per-file failure handler for bulk deletes [iceberg]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #16444: Core, AWS, Azure, GCP: Add per-file failure handler for bulk deletes
URL: https://github.com/apache/iceberg/pull/16444


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Core, AWS, Azure, GCP: Add per-file failure handler for bulk deletes [iceberg]

Posted by "sarthaksin1857 (via GitHub)" <gi...@apache.org>.
sarthaksin1857 commented on code in PR #16444:
URL: https://github.com/apache/iceberg/pull/16444#discussion_r3345119392


##########
azure/src/main/java/org/apache/iceberg/azure/adlsv2/ADLSFileIO.java:
##########
@@ -204,14 +218,26 @@ public void deleteFiles(Iterable<String> pathsToDelete) throws BulkDeletionFailu
             (file, exc) -> {
               failureCount.incrementAndGet();
               LOG.warn("Failed to delete file {}", file, exc);
+              FailureCategory category = ADLSErrorInterpreter.categorize(exc);
+              String rawCode = ADLSErrorInterpreter.rawErrorCode(exc);
+              notify(handler, new FileFailure(file, category, rawCode, exc));
             })
-        .run(this::deleteFile);
+        .run(this::deleteFileThrowing);

Review Comment:
   Old deleteFile swallowed exceptions and therefore were never caught 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Core, AWS, Azure, GCP: Add per-file failure handler for bulk deletes [iceberg]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #16444:
URL: https://github.com/apache/iceberg/pull/16444#issuecomment-5017932864

   This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Core, AWS, Azure, GCP: Add per-file failure handler for bulk deletes [iceberg]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #16444:
URL: https://github.com/apache/iceberg/pull/16444#issuecomment-5098429915

   This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org