[GitHub] [superset] kgabryje commented on a change in pull request #16323: fix: Return original document title when leaving a dashboard

[GitBox <gi...@apache.org>]

kgabryje commented on a change in pull request #16323:
URL: https://github.com/apache/superset/pull/16323#discussion_r691237597



##########
File path: superset-frontend/src/dashboard/containers/DashboardPage.tsx
##########
@@ -42,6 +42,8 @@ const DashboardContainer = React.lazy(
     ),
 );
 
+const documentTitle = document.title;

Review comment:
       Can we rename it to something like `originalDocumentTitle` or `prevDocumentTitle` to make the intention more clear?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org