[royale-asjs] branch feature/rename updated: Prevent multiple listeners and remove used listeners

[ha...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

harbs pushed a commit to branch feature/rename
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git


The following commit(s) were added to refs/heads/feature/rename by this push:
     new e7a84d9  Prevent multiple listeners and remove used listeners
e7a84d9 is described below

commit e7a84d923842b0baab16f2c57ca7f2a09ff8acc2
Author: Harbs <ha...@in-tools.com>
AuthorDate: Sat Oct 7 22:26:08 2017 +0300

    Prevent multiple listeners and remove used listeners
---
 .../main/royale/org/apache/royale/core/ImageViewBase.as | 17 ++++++++++++-----
 1 file changed, 12 insertions(+), 5 deletions(-)

diff --git a/frameworks/projects/Core/src/main/royale/org/apache/royale/core/ImageViewBase.as b/frameworks/projects/Core/src/main/royale/org/apache/royale/core/ImageViewBase.as
index 082a512..32e9a8a 100644
--- a/frameworks/projects/Core/src/main/royale/org/apache/royale/core/ImageViewBase.as
+++ b/frameworks/projects/Core/src/main/royale/org/apache/royale/core/ImageViewBase.as
@@ -142,15 +142,20 @@ package org.apache.royale.core
 		{
 			return (_strand as IImage).imageElement;
 		}
-			
+		
+        COMPILE::JS
+        private var _sizeHandlerSet:Boolean;
         COMPILE::JS
 		public function setupLoader():void
         {
             var host:IUIBase = _strand as IUIBase;
-            imageElement.addEventListener('load',
-                loadHandler, false);
-            host.addEventListener('sizeChanged',
-                sizeChangedHandler);
+            imageElement.addEventListener('load', loadHandler);
+            //only do this once. We don't want multiple event listeners
+            if(!_sizeHandlerSet)
+            {
+                host.addEventListener('sizeChanged', sizeChangedHandler);
+                _sizeHandlerSet = true;
+            }
         }
 		
 		/**
@@ -159,6 +164,7 @@ package org.apache.royale.core
         COMPILE::SWF
 		private function onComplete(event:Object):void
 		{
+            loader.contentLoaderInfo.removeEventListener("complete",onComplete);
             var host:ILayoutChild = ILayoutChild(_strand);
 			var hostSprite:Sprite = (host as IRenderedObject).$displayObject as Sprite;
 			
@@ -208,6 +214,7 @@ package org.apache.royale.core
         COMPILE::JS
         protected function loadHandler(event:Object):void
         {
+            imageElement.removeEventListener('load', loadHandler);
             var host:IUIBase = _strand as IUIBase;
 			host.dispatchEvent(new Event("layoutNeeded"));
         }

-- 
To stop receiving notification emails like this one, please contact
['"commits@royale.apache.org" <co...@royale.apache.org>'].