You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by kenshalo <gi...@git.apache.org> on 2016/11/18 01:10:37 UTC
[GitHub] zeppelin pull request #1653: Relative path on windows getAbsolutePath() and ...
GitHub user kenshalo opened a pull request:
https://github.com/apache/zeppelin/pull/1653
Relative path on windows getAbsolutePath() and new URI causes excepti\u2026
### What is this PR for?
Relative path on windows getAbsolutePath() and new URI causes exception and most test cases to fail. Switched to create new File() and use f.toURI() so that test cases pass on windows
### What type of PR is it?
Bug Fix
### Todos
* [ ] - Task
### What is the Jira issue?
* Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN/
* Put link here, and add [ZEPPELIN-*Jira number*] in PR title, eg. [ZEPPELIN-533]
### How should this be tested?
Run zengine JUnit test cases in on windows with relative path
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update?
No
* Is there breaking changes for older versions?
No
* Does this needs documentation?
No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kenshalo/zeppelin master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1653.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1653
----
commit c3aceb188126ff5322339e73a62b688544fb0cb7
Author: kenshalo <um...@yahoo.com>
Date: 2016-11-18T01:01:22Z
Relative path on windows getAbsolutePath() and new URI causes exception and most test cases to fail. Switched to create new File() and use f.toURI() so that test cases pass on windows
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1653: Relative path on windows getAbsolutePath() and new URI...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1653
merge to master if there're no further discussions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1653: Relative path on windows getAbsolutePath() and new URI...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1653
Thanks @kenshalo for the fix.
LGTM. If you can create an issue, it will help people track when this problem has been fixed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1653: Relative path on windows getAbsolutePath() and ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1653
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---