You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/10/26 08:07:00 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #2116: arch/sim: Enable SIM_WALLTIME option by default

xiaoxiang781216 commented on a change in pull request #2116:
URL: https://github.com/apache/incubator-nuttx/pull/2116#discussion_r511743209



##########
File path: arch/sim/Kconfig
##########
@@ -99,7 +99,7 @@ endchoice
 
 config SIM_WALLTIME
 	bool "Run the simulation at a fixed cadence in near real-time"
-	default n
+	default y

Review comment:
       even we change SIM_WALLTIME default to y, we still need to select SIM_WALLTIME for SIM_HCISOCKET. Otherwise the user can generate the wrong combination by:
   CONFIG_SIM_WALLTIME=n
   CONFIG_SIM_HCISOCKET=y
   That's why I think the default value change can't give any real help here.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org