You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "Lee-W (via GitHub)" <gi...@apache.org> on 2025/04/09 09:31:02 UTC
[PR] feat(task-sdk): add get_asset, get_asset_alias to event accessors [airflow]
Lee-W opened a new pull request, #48999:
URL: https://github.com/apache/airflow/pull/48999
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(task-sdk): add get_through_asset, get_through_asset_alias to event accessors [airflow]
Posted by "Lee-W (via GitHub)" <gi...@apache.org>.
Lee-W commented on PR #48999:
URL: https://github.com/apache/airflow/pull/48999#issuecomment-2789311922
> How about one of these?
>
> `{{ inlet_events.via_asset(name="name")] }}`
>
> or
>
> `{{ inlet_events.for_asset(name="name")] }}`
Let's go with `for_asset`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(task-sdk): add get_through_asset, get_through_asset_alias to event accessors [airflow]
Posted by "phanikumv (via GitHub)" <gi...@apache.org>.
phanikumv merged PR #48999:
URL: https://github.com/apache/airflow/pull/48999
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(task-sdk): add get_through_asset, get_through_asset_alias to event accessors [airflow]
Posted by "ashb (via GitHub)" <gi...@apache.org>.
ashb commented on PR #48999:
URL: https://github.com/apache/airflow/pull/48999#issuecomment-2789283339
How about one of these?
`{{ inlet_events.via_asset(name="name")] }}`
or
`{{ inlet_events.for_asset(name="name")] }}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(task-sdk): add get_through_asset, get_through_asset_alias to event accessors [airflow]
Posted by "Lee-W (via GitHub)" <gi...@apache.org>.
Lee-W commented on PR #48999:
URL: https://github.com/apache/airflow/pull/48999#issuecomment-2789188311
the `get_through...` sounds a bit long, but get_... is not accurate. suggestion is welcome 🙂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(task-sdk): add get_through_asset, get_through_asset_alias to event accessors [airflow]
Posted by "ashb (via GitHub)" <gi...@apache.org>.
ashb commented on code in PR #48999:
URL: https://github.com/apache/airflow/pull/48999#discussion_r2035148161
##########
task-sdk/src/airflow/sdk/execution_time/context.py:
##########
@@ -397,7 +399,29 @@ def add(self, asset: Asset | AssetRef, extra: dict[str, Any] | None = None) -> N
self.asset_alias_events.append(event)
-class OutletEventAccessors(_AssetRefResolutionMixin, Mapping[Union[Asset, AssetAlias], OutletEventAccessor]):
+class _AssetEventAccessorsMixin(Generic[T]):
+ def for_asset(self, *, name: str | None = None, uri: str | None = None) -> T:
+ if name and uri:
+ return self[Asset(name=name, uri=uri)]
+ elif name:
+ return self[Asset.ref(name=name)]
+ elif uri:
+ return self[Asset.ref(uri=uri)]
+
+ raise ValueError("name and uri cannot both be None")
+
+ def for_asset_alias(self, *, name: str) -> T:
+ return self[AssetAlias(name=name)]
+
+ def __getitem__(self, key: Asset | AssetAlias | AssetRef) -> T:
+ raise NotImplementedError
Review Comment:
Not sure if matters, but should this include a message to say `use for_asset/for_asset_alias`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(task-sdk): add get_through_asset, get_through_asset_alias to event accessors [airflow]
Posted by "Lee-W (via GitHub)" <gi...@apache.org>.
Lee-W commented on code in PR #48999:
URL: https://github.com/apache/airflow/pull/48999#discussion_r2035152249
##########
task-sdk/src/airflow/sdk/execution_time/context.py:
##########
@@ -397,7 +399,29 @@ def add(self, asset: Asset | AssetRef, extra: dict[str, Any] | None = None) -> N
self.asset_alias_events.append(event)
-class OutletEventAccessors(_AssetRefResolutionMixin, Mapping[Union[Asset, AssetAlias], OutletEventAccessor]):
+class _AssetEventAccessorsMixin(Generic[T]):
+ def for_asset(self, *, name: str | None = None, uri: str | None = None) -> T:
+ if name and uri:
+ return self[Asset(name=name, uri=uri)]
+ elif name:
+ return self[Asset.ref(name=name)]
+ elif uri:
+ return self[Asset.ref(uri=uri)]
+
+ raise ValueError("name and uri cannot both be None")
+
+ def for_asset_alias(self, *, name: str) -> T:
+ return self[AssetAlias(name=name)]
+
+ def __getitem__(self, key: Asset | AssetAlias | AssetRef) -> T:
+ raise NotImplementedError
Review Comment:
yep, it's for typing. Without it, mypy raises lots of warnings 😱
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(task-sdk): add get_through_asset, get_through_asset_alias to event accessors [airflow]
Posted by "ashb (via GitHub)" <gi...@apache.org>.
ashb commented on code in PR #48999:
URL: https://github.com/apache/airflow/pull/48999#discussion_r2035149419
##########
task-sdk/src/airflow/sdk/execution_time/context.py:
##########
@@ -397,7 +399,29 @@ def add(self, asset: Asset | AssetRef, extra: dict[str, Any] | None = None) -> N
self.asset_alias_events.append(event)
-class OutletEventAccessors(_AssetRefResolutionMixin, Mapping[Union[Asset, AssetAlias], OutletEventAccessor]):
+class _AssetEventAccessorsMixin(Generic[T]):
+ def for_asset(self, *, name: str | None = None, uri: str | None = None) -> T:
+ if name and uri:
+ return self[Asset(name=name, uri=uri)]
+ elif name:
+ return self[Asset.ref(name=name)]
+ elif uri:
+ return self[Asset.ref(uri=uri)]
+
+ raise ValueError("name and uri cannot both be None")
+
+ def for_asset_alias(self, *, name: str) -> T:
+ return self[AssetAlias(name=name)]
+
+ def __getitem__(self, key: Asset | AssetAlias | AssetRef) -> T:
+ raise NotImplementedError
Review Comment:
Oh, this is just for typing essentially isn't it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org