You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/03/02 15:14:00 UTC
[GitHub] [ozone] adoroszlai opened a new pull request #1983: HDDS-4891. Avoid latest/master in Github Actions
adoroszlai opened a new pull request #1983:
URL: https://github.com/apache/ozone/pull/1983
## What changes were proposed in this pull request?
Avoid versions `latest` (for runners) and `master` (for actions) in Github Actions workflows.
https://issues.apache.org/jira/browse/HDDS-4891
## How was this patch tested?
Tested a command comment on my fork:
https://github.com/adoroszlai/hadoop-ozone/pull/8#issuecomment-788974590
https://github.com/adoroszlai/hadoop-ozone/runs/2014250387
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ayushtkn commented on a change in pull request #1983: HDDS-4891. Avoid latest/master in Github Actions
Posted by GitBox <gi...@apache.org>.
ayushtkn commented on a change in pull request #1983:
URL: https://github.com/apache/ozone/pull/1983#discussion_r586681250
##########
File path: .github/workflows/close-pending.yaml
##########
@@ -21,10 +21,10 @@ on:
jobs:
close-pending:
name: close-pending
- runs-on: ubuntu-latest
+ runs-on: ubuntu-18.04
Review comment:
makes sense
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ayushtkn commented on a change in pull request #1983: HDDS-4891. Avoid latest/master in Github Actions
Posted by GitBox <gi...@apache.org>.
ayushtkn commented on a change in pull request #1983:
URL: https://github.com/apache/ozone/pull/1983#discussion_r586224626
##########
File path: .github/workflows/close-pending.yaml
##########
@@ -21,10 +21,10 @@ on:
jobs:
close-pending:
name: close-pending
- runs-on: ubuntu-latest
+ runs-on: ubuntu-18.04
Review comment:
Any specific reason for using 18.04? I guess 20.04 is also LTS
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #1983: HDDS-4891. Avoid latest/master in Github Actions
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #1983:
URL: https://github.com/apache/ozone/pull/1983#issuecomment-795189377
Thanks @elek for reviewing and committing it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ayushtkn commented on a change in pull request #1983: HDDS-4891. Avoid latest/master in Github Actions
Posted by GitBox <gi...@apache.org>.
ayushtkn commented on a change in pull request #1983:
URL: https://github.com/apache/ozone/pull/1983#discussion_r586681250
##########
File path: .github/workflows/close-pending.yaml
##########
@@ -21,10 +21,10 @@ on:
jobs:
close-pending:
name: close-pending
- runs-on: ubuntu-latest
+ runs-on: ubuntu-18.04
Review comment:
makes sense, Seems the build is failing for some reason, should be fine once the build is green. :-)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] elek merged pull request #1983: HDDS-4891. Avoid latest/master in Github Actions
Posted by GitBox <gi...@apache.org>.
elek merged pull request #1983:
URL: https://github.com/apache/ozone/pull/1983
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on a change in pull request #1983: HDDS-4891. Avoid latest/master in Github Actions
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on a change in pull request #1983:
URL: https://github.com/apache/ozone/pull/1983#discussion_r586251507
##########
File path: .github/workflows/close-pending.yaml
##########
@@ -21,10 +21,10 @@ on:
jobs:
close-pending:
name: close-pending
- runs-on: ubuntu-latest
+ runs-on: ubuntu-18.04
Review comment:
`latest` [is currently 18.04](https://github.com/apache/ozone/runs/2020674273?check_suite_focus=true#step:1:4), but [will be updated to 20.04](https://github.com/actions/virtual-environments/issues/1816) sometime soon. I don't expect any problem from the update. But changing to a more specific version lets us make the upgrade when required in a controlled way, instead of getting it unsolicitedly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org