You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mahout.apache.org by "julien nioche (JIRA)" <ji...@apache.org> on 2008/04/17 18:07:21 UTC
[jira] Created: (MAHOUT-44) Override zSum and dot for SparseVector
Override zSum and dot for SparseVector
--------------------------------------
Key: MAHOUT-44
URL: https://issues.apache.org/jira/browse/MAHOUT-44
Project: Mahout
Issue Type: Improvement
Components: Matrix
Affects Versions: 0.1
Reporter: julien nioche
Priority: Minor
Fix For: 0.1
revision 649163
The patch attached overrides the zSum() and dot() methods in SparseVector. This is more efficient than relying on the methods from AbstractVector which iterate on all the indices of the Vectors.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (MAHOUT-44) Override zSum and dot for SparseVector
Posted by "julien nioche (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-44?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
julien nioche closed MAHOUT-44.
-------------------------------
My pleasure. Thank you for committing it
> Override zSum and dot for SparseVector
> --------------------------------------
>
> Key: MAHOUT-44
> URL: https://issues.apache.org/jira/browse/MAHOUT-44
> Project: Mahout
> Issue Type: Improvement
> Components: Matrix
> Affects Versions: 0.1
> Reporter: julien nioche
> Assignee: Grant Ingersoll
> Priority: Minor
> Fix For: 0.1
>
> Attachments: SparseVector.diff
>
>
> revision 649163
> The patch attached overrides the zSum() and dot() methods in SparseVector. This is more efficient than relying on the methods from AbstractVector which iterate on all the indices of the Vectors.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Commented: (MAHOUT-44) Override zSum and dot for SparseVector
Posted by Grant Ingersoll <gs...@apache.org>.
OK, my first step when checking a patch is to see if there is unit
tests included and than flag it immediately, so no worries.
-Grant
On Apr 20, 2008, at 10:22 AM, julien nioche (JIRA) wrote:
>
> [ https://issues.apache.org/jira/browse/MAHOUT-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12590766
> #action_12590766 ]
>
> julien nioche commented on MAHOUT-44:
> -------------------------------------
>
> I think the existing tests in TestSparseVector (testDot and
> testZSum) cover that already.
>
>> Override zSum and dot for SparseVector
>> --------------------------------------
>>
>> Key: MAHOUT-44
>> URL: https://issues.apache.org/jira/browse/MAHOUT-44
>> Project: Mahout
>> Issue Type: Improvement
>> Components: Matrix
>> Affects Versions: 0.1
>> Reporter: julien nioche
>> Assignee: Grant Ingersoll
>> Priority: Minor
>> Fix For: 0.1
>>
>> Attachments: SparseVector.diff
>>
>>
>> revision 649163
>> The patch attached overrides the zSum() and dot() methods in
>> SparseVector. This is more efficient than relying on the methods
>> from AbstractVector which iterate on all the indices of the Vectors.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
[jira] Commented: (MAHOUT-44) Override zSum and dot for
SparseVector
Posted by "julien nioche (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12590766#action_12590766 ]
julien nioche commented on MAHOUT-44:
-------------------------------------
I think the existing tests in TestSparseVector (testDot and testZSum) cover that already.
> Override zSum and dot for SparseVector
> --------------------------------------
>
> Key: MAHOUT-44
> URL: https://issues.apache.org/jira/browse/MAHOUT-44
> Project: Mahout
> Issue Type: Improvement
> Components: Matrix
> Affects Versions: 0.1
> Reporter: julien nioche
> Assignee: Grant Ingersoll
> Priority: Minor
> Fix For: 0.1
>
> Attachments: SparseVector.diff
>
>
> revision 649163
> The patch attached overrides the zSum() and dot() methods in SparseVector. This is more efficient than relying on the methods from AbstractVector which iterate on all the indices of the Vectors.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (MAHOUT-44) Override zSum and dot for SparseVector
Posted by "Grant Ingersoll (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-44?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Grant Ingersoll resolved MAHOUT-44.
-----------------------------------
Resolution: Fixed
Committed revision 649933.
Thanks Julien!
> Override zSum and dot for SparseVector
> --------------------------------------
>
> Key: MAHOUT-44
> URL: https://issues.apache.org/jira/browse/MAHOUT-44
> Project: Mahout
> Issue Type: Improvement
> Components: Matrix
> Affects Versions: 0.1
> Reporter: julien nioche
> Assignee: Grant Ingersoll
> Priority: Minor
> Fix For: 0.1
>
> Attachments: SparseVector.diff
>
>
> revision 649163
> The patch attached overrides the zSum() and dot() methods in SparseVector. This is more efficient than relying on the methods from AbstractVector which iterate on all the indices of the Vectors.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (MAHOUT-44) Override zSum and dot for SparseVector
Posted by "Grant Ingersoll (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-44?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Grant Ingersoll reassigned MAHOUT-44:
-------------------------------------
Assignee: Grant Ingersoll
> Override zSum and dot for SparseVector
> --------------------------------------
>
> Key: MAHOUT-44
> URL: https://issues.apache.org/jira/browse/MAHOUT-44
> Project: Mahout
> Issue Type: Improvement
> Components: Matrix
> Affects Versions: 0.1
> Reporter: julien nioche
> Assignee: Grant Ingersoll
> Priority: Minor
> Fix For: 0.1
>
> Attachments: SparseVector.diff
>
>
> revision 649163
> The patch attached overrides the zSum() and dot() methods in SparseVector. This is more efficient than relying on the methods from AbstractVector which iterate on all the indices of the Vectors.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAHOUT-44) Override zSum and dot for SparseVector
Posted by "julien nioche (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-44?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
julien nioche updated MAHOUT-44:
--------------------------------
Attachment: SparseVector.diff
diff file which adds implementation of zSum and dot to SparseVectors
> Override zSum and dot for SparseVector
> --------------------------------------
>
> Key: MAHOUT-44
> URL: https://issues.apache.org/jira/browse/MAHOUT-44
> Project: Mahout
> Issue Type: Improvement
> Components: Matrix
> Affects Versions: 0.1
> Reporter: julien nioche
> Priority: Minor
> Fix For: 0.1
>
> Attachments: SparseVector.diff
>
>
> revision 649163
> The patch attached overrides the zSum() and dot() methods in SparseVector. This is more efficient than relying on the methods from AbstractVector which iterate on all the indices of the Vectors.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAHOUT-44) Override zSum and dot for
SparseVector
Posted by "Grant Ingersoll (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12590763#action_12590763 ]
Grant Ingersoll commented on MAHOUT-44:
---------------------------------------
Just for completeness, can you add Unit tests?
> Override zSum and dot for SparseVector
> --------------------------------------
>
> Key: MAHOUT-44
> URL: https://issues.apache.org/jira/browse/MAHOUT-44
> Project: Mahout
> Issue Type: Improvement
> Components: Matrix
> Affects Versions: 0.1
> Reporter: julien nioche
> Assignee: Grant Ingersoll
> Priority: Minor
> Fix For: 0.1
>
> Attachments: SparseVector.diff
>
>
> revision 649163
> The patch attached overrides the zSum() and dot() methods in SparseVector. This is more efficient than relying on the methods from AbstractVector which iterate on all the indices of the Vectors.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.