You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2022/03/20 12:08:45 UTC

svn commit: r1899086 - in /pdfbox/trunk/examples/src/main/java/org/apache/pdfbox/examples/signature: CreateSignature.java CreateVisibleSignature.java CreateVisibleSignature2.java

Author: tilman
Date: Sun Mar 20 12:08:45 2022
New Revision: 1899086

URL: http://svn.apache.org/viewvc?rev=1899086&view=rev
Log:
PDFBOX-5382: revert, but keep a comment for now

Modified:
    pdfbox/trunk/examples/src/main/java/org/apache/pdfbox/examples/signature/CreateSignature.java
    pdfbox/trunk/examples/src/main/java/org/apache/pdfbox/examples/signature/CreateVisibleSignature.java
    pdfbox/trunk/examples/src/main/java/org/apache/pdfbox/examples/signature/CreateVisibleSignature2.java

Modified: pdfbox/trunk/examples/src/main/java/org/apache/pdfbox/examples/signature/CreateSignature.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/examples/src/main/java/org/apache/pdfbox/examples/signature/CreateSignature.java?rev=1899086&r1=1899085&r2=1899086&view=diff
==============================================================================
--- pdfbox/trunk/examples/src/main/java/org/apache/pdfbox/examples/signature/CreateSignature.java (original)
+++ pdfbox/trunk/examples/src/main/java/org/apache/pdfbox/examples/signature/CreateSignature.java Sun Mar 20 12:08:45 2022
@@ -116,7 +116,9 @@ public class CreateSignature extends Cre
     public void signDetached(PDDocument document, OutputStream output)
             throws IOException
     {
-        SigUtils.checkCrossReferenceTable(document);
+        // call SigUtils.checkCrossReferenceTable(document) if Adobe complains
+        // and read https://stackoverflow.com/a/71293901/535646
+        // and https://issues.apache.org/jira/browse/PDFBOX-5382
 
         int accessPermissions = SigUtils.getMDPPermission(document);
         if (accessPermissions == 1)

Modified: pdfbox/trunk/examples/src/main/java/org/apache/pdfbox/examples/signature/CreateVisibleSignature.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/examples/src/main/java/org/apache/pdfbox/examples/signature/CreateVisibleSignature.java?rev=1899086&r1=1899085&r2=1899086&view=diff
==============================================================================
--- pdfbox/trunk/examples/src/main/java/org/apache/pdfbox/examples/signature/CreateVisibleSignature.java (original)
+++ pdfbox/trunk/examples/src/main/java/org/apache/pdfbox/examples/signature/CreateVisibleSignature.java Sun Mar 20 12:08:45 2022
@@ -219,8 +219,10 @@ public class CreateVisibleSignature exte
             doc = Loader.loadPDF(inputFile, memoryUsageSetting);
         }
 
-        SigUtils.checkCrossReferenceTable(doc);
-        
+        // call SigUtils.checkCrossReferenceTable(doc) if Adobe complains
+        // and read https://stackoverflow.com/a/71293901/535646
+        // and https://issues.apache.org/jira/browse/PDFBOX-5382
+
         try (FileOutputStream fos = new FileOutputStream(signedFile))
         {
             int accessPermissions = SigUtils.getMDPPermission(doc);

Modified: pdfbox/trunk/examples/src/main/java/org/apache/pdfbox/examples/signature/CreateVisibleSignature2.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/examples/src/main/java/org/apache/pdfbox/examples/signature/CreateVisibleSignature2.java?rev=1899086&r1=1899085&r2=1899086&view=diff
==============================================================================
--- pdfbox/trunk/examples/src/main/java/org/apache/pdfbox/examples/signature/CreateVisibleSignature2.java (original)
+++ pdfbox/trunk/examples/src/main/java/org/apache/pdfbox/examples/signature/CreateVisibleSignature2.java Sun Mar 20 12:08:45 2022
@@ -167,7 +167,9 @@ public class CreateVisibleSignature2 ext
         try (FileOutputStream fos = new FileOutputStream(signedFile);
                 PDDocument doc = Loader.loadPDF(inputFile))
         {
-            SigUtils.checkCrossReferenceTable(doc);
+            // call SigUtils.checkCrossReferenceTable(doc) if Adobe complains
+            // and read https://stackoverflow.com/a/71293901/535646
+            // and https://issues.apache.org/jira/browse/PDFBOX-5382
 
             int accessPermissions = SigUtils.getMDPPermission(doc);
             if (accessPermissions == 1)