You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2014/05/08 23:09:41 UTC
Review Request 21236: Fixed tasks reconciliation and added tests.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21236/
-----------------------------------------------------------
Review request for mesos, Ben Mahler and Dominic Hamon.
Bugs: MESOS-1320
https://issues.apache.org/jira/browse/MESOS-1320
Repository: mesos-git
Description
-------
Fixed reconciliation so that status updates are always sent.
Diffs
-----
src/master/master.hpp 0a350b0b402edb3ca648c91c920043f66c08fe0e
src/master/master.cpp 87ea77aa19e482a20f081061e81acc89582eacdd
src/tests/reconciliation_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/21236/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 21236: Fixed tasks reconciliation and added tests.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21236/#review42540
-----------------------------------------------------------
Ship it!
Glad we found this bug!
src/master/master.cpp
<https://reviews.apache.org/r/21236/#comment76348>
Can you s/best-effort// before you commit this?
src/master/master.cpp
<https://reviews.apache.org/r/21236/#comment76339>
Should this say unknown as well?
src/tests/reconciliation_tests.cpp
<https://reviews.apache.org/r/21236/#comment76344>
Hm.. status and status2 are a bit confusing, maybe s/status/update/ and s/status2/status/?
Ditto below
src/tests/reconciliation_tests.cpp
<https://reviews.apache.org/r/21236/#comment76345>
s/strict/non-strict/
src/tests/reconciliation_tests.cpp
<https://reviews.apache.org/r/21236/#comment76347>
Could you also add a similar TODO at _reregisterSlave in master.hpp? I just want to make sure it's clear what could be done to move it back to private :)
- Ben Mahler
On May 8, 2014, 9:09 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21236/
> -----------------------------------------------------------
>
> (Updated May 8, 2014, 9:09 p.m.)
>
>
> Review request for mesos, Ben Mahler and Dominic Hamon.
>
>
> Bugs: MESOS-1320
> https://issues.apache.org/jira/browse/MESOS-1320
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Fixed reconciliation so that status updates are always sent.
>
>
> Diffs
> -----
>
> src/master/master.hpp 0a350b0b402edb3ca648c91c920043f66c08fe0e
> src/master/master.cpp 87ea77aa19e482a20f081061e81acc89582eacdd
> src/tests/reconciliation_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/21236/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 21236: Fixed tasks reconciliation and added tests.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21236/#review42731
-----------------------------------------------------------
Ship it!
Ship It!
- Ben Mahler
On May 12, 2014, 5:26 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21236/
> -----------------------------------------------------------
>
> (Updated May 12, 2014, 5:26 p.m.)
>
>
> Review request for mesos, Ben Mahler and Dominic Hamon.
>
>
> Bugs: MESOS-1320
> https://issues.apache.org/jira/browse/MESOS-1320
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Fixed reconciliation so that status updates are always sent.
>
>
> Diffs
> -----
>
> src/master/master.hpp 0a350b0b402edb3ca648c91c920043f66c08fe0e
> src/master/master.cpp d851a7291acce950ea9391ddfb8813a432aeda34
> src/tests/reconciliation_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/21236/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 21236: Fixed tasks reconciliation and added tests.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21236/
-----------------------------------------------------------
(Updated May 12, 2014, 5:26 p.m.)
Review request for mesos, Ben Mahler and Dominic Hamon.
Changes
-------
rebased. PTAL.
Bugs: MESOS-1320
https://issues.apache.org/jira/browse/MESOS-1320
Repository: mesos-git
Description
-------
Fixed reconciliation so that status updates are always sent.
Diffs (updated)
-----
src/master/master.hpp 0a350b0b402edb3ca648c91c920043f66c08fe0e
src/master/master.cpp d851a7291acce950ea9391ddfb8813a432aeda34
src/tests/reconciliation_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/21236/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 21236: Fixed tasks reconciliation and added tests.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21236/
-----------------------------------------------------------
(Updated May 9, 2014, 8:07 p.m.)
Review request for mesos, Ben Mahler and Dominic Hamon.
Changes
-------
benm's. added another test to fix a TODO. PTAL.
Bugs: MESOS-1320
https://issues.apache.org/jira/browse/MESOS-1320
Repository: mesos-git
Description
-------
Fixed reconciliation so that status updates are always sent.
Diffs (updated)
-----
src/master/master.hpp 0a350b0b402edb3ca648c91c920043f66c08fe0e
src/master/master.cpp 87ea77aa19e482a20f081061e81acc89582eacdd
src/tests/reconciliation_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/21236/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 21236: Fixed tasks reconciliation and added tests.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21236/#review42553
-----------------------------------------------------------
Patch looks great!
Reviews applied: [21175, 21236]
All tests passed.
- Mesos ReviewBot
On May 8, 2014, 9:09 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21236/
> -----------------------------------------------------------
>
> (Updated May 8, 2014, 9:09 p.m.)
>
>
> Review request for mesos, Ben Mahler and Dominic Hamon.
>
>
> Bugs: MESOS-1320
> https://issues.apache.org/jira/browse/MESOS-1320
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Fixed reconciliation so that status updates are always sent.
>
>
> Diffs
> -----
>
> src/master/master.hpp 0a350b0b402edb3ca648c91c920043f66c08fe0e
> src/master/master.cpp 87ea77aa19e482a20f081061e81acc89582eacdd
> src/tests/reconciliation_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/21236/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>