You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/05/19 10:47:24 UTC
[GitHub] [incubator-nuttx] Ouss4 commented on a diff in pull request #6283: pthread/spinlock: Call up_testsest directly in the flat build
Ouss4 commented on code in PR #6283:
URL: https://github.com/apache/incubator-nuttx/pull/6283#discussion_r876905523
##########
include/nuttx/spinlock.h:
##########
@@ -107,28 +107,7 @@ typedef struct
*
****************************************************************************/
-#if defined(CONFIG_ARCH_HAVE_TESTSET)
spinlock_t up_testset(volatile FAR spinlock_t *lock);
-#elif !defined(CONFIG_SMP)
Review Comment:
I don't think so. The condition is `#if defined(CONFIG_SPINLOCK) && !defined(CONFIG_ARCH_HAVE_TESTSET)` and SMP depends on `CONFIG_ARCH_HAVE_TESTSET`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org