You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kvrocks.apache.org by GitBox <gi...@apache.org> on 2022/05/28 15:26:20 UTC
[GitHub] [incubator-kvrocks] git-hulk opened a new issue, #612: Change the unit of the rocksdb options
git-hulk opened a new issue, #612:
URL: https://github.com/apache/incubator-kvrocks/issues/612
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/incubator-kvrocks/issues) and found no similar issues.
### Motivation
PR https://github.com/apache/incubator-kvrocks/pull/497,https://github.com/apache/incubator-kvrocks/pull/503 allowed changing the rocksdb options `blob_file_size` and `max_bytes_for_level_base` in-flight. But from the literal, we would think that the unit of these two configurations should be bytes(like `max_bytes_for_level_base`), but in fact was MiB. So it should be a good idea to change them with the right unit, this will NOT break the behavior since we didn't release those features yet.
### Solution
_No response_
### Are you willing to submit a PR?
- [ ] I'm willing to submit a PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kvrocks.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] WyattJia commented on issue #612: Change the unit of the rocksdb options
Posted by GitBox <gi...@apache.org>.
WyattJia commented on issue #612:
URL: https://github.com/apache/incubator-kvrocks/issues/612#issuecomment-1140487680
And about max_bytes_for_level configuration's change, I opened another PR on #610 ,please review and thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] git-hulk closed issue #612: Change the unit of the rocksdb options
Posted by GitBox <gi...@apache.org>.
git-hulk closed issue #612: Change the unit of the rocksdb options
URL: https://github.com/apache/incubator-kvrocks/issues/612
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org