You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/10/05 20:06:18 UTC
[GitHub] [airflow] Taragolis opened a new pull request, #26845: Fix Slack Connections created in the UI
Taragolis opened a new pull request, #26845:
URL: https://github.com/apache/airflow/pull/26845
Follow up: [Status of testing Providers that were prepared on September 28, 2022: Provider slack: 6.0.0rc1](https://github.com/apache/airflow/issues/26752#issuecomment-1263625826)
During the test found different issues with connections created in the UI.
---
### Case 1. Extra fields which use `wtforms.IntegerField` should have `wtforms.validators.Optional` validator
**Timeout** is optional field, however if try to save connection without specified value in this field that selected error happen
**Fixed**: Add validators `[Optional(strip_whitespace=True), NumberRange(min=1)]`
---
### Case 2. Extra fields which use `wtforms.StringField` in Airflow 2.2 create empty value if user not specified anything
#### Airflow 2.2.0 and 2.2.5
```
id: slack_api. Host: , Port: None, Schema: , Login: , Password: ***, extra: {'extra__slack__base_url': '', 'extra__slack__proxy': '', 'extra__slack__timeout': None}
```
#### Airflow 2.3.0, 2.3.1, 2.3.4, 2.4.0
```
id: slack_api. Host: , Port: None, Schema: , Login: , Password: ***, extra: {'extra__slack__timeout': None}
```
**Fixed**: Ignore empty string and None values for prefixed extra
---
### Case 3. Extra fields which use `wtforms.IntegerField` create None value if user not specified anything
See, Case 2
---
### Case 4. In Airflow 2.2 if user specify anything in extra fields than test connection from the UI failed with bad request
Connections created in the UI work fine, only test connections won't work.
I don't think it is possible to do anything with this except:
1. Do not use `get_connection_form_widgets` and user should specified in extra as a dictionary
2. Additional logic which create different output for `get_connection_form_widgets` and `get_ui_field_behaviour` depend on Airflow version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #26845: Fix Slack Connections created in the UI
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #26845:
URL: https://github.com/apache/airflow/pull/26845
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Taragolis commented on pull request #26845: Fix Slack Connections created in the UI
Posted by GitBox <gi...@apache.org>.
Taragolis commented on PR #26845:
URL: https://github.com/apache/airflow/pull/26845#issuecomment-1265610340
cc: @potiuk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org