You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@groovy.apache.org by "Paul King (Jira)" <ji...@apache.org> on 2022/04/27 08:34:00 UTC
[jira] [Closed] (GROOVY-10585) `@AutoFinal` does not use annotation parameters when used with `ASTTransformationCustomizer`
[ https://issues.apache.org/jira/browse/GROOVY-10585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul King closed GROOVY-10585.
------------------------------
> `@AutoFinal` does not use annotation parameters when used with `ASTTransformationCustomizer`
> --------------------------------------------------------------------------------------------
>
> Key: GROOVY-10585
> URL: https://issues.apache.org/jira/browse/GROOVY-10585
> Project: Groovy
> Issue Type: Bug
> Affects Versions: 4.0.1
> Reporter: V
> Assignee: Eric Milles
> Priority: Major
> Fix For: 5.0.0-alpha-1, 2.5.17, 3.0.11, 4.0.2
>
>
> When used with `ASTTransformationCustomizer` (like below) or in a configscript (`ast(AutoFinal)`, which I think is also using an `ASTTransformationCustomizer`), `@AutoFinal` does not seem to take the annotation parameters. Applying it individually seems to be fine. A test case to demonstrate this:
> {code:groovy}
> class AnnotationParameterTest {
> private static GroovyShell getLoggerShell() {
> final CompilerConfiguration configuration = new CompilerConfiguration()
> configuration.addCompilationCustomizers(
> new ASTTransformationCustomizer(Log, value: 'logger'),
> new ASTTransformationCustomizer(AutoFinal, enabled: false))
> return new GroovyShell(configuration)
> }
> @Test
> void testAnnotationParameters() {
> getLoggerShell().run('''
> @groovy.transform.AutoFinal(enabled = false) // Removing this line would fail the test.
> class Foo {
> void testMutation(int i) {
> i = 1
> logger.severe("i = $i")
> }
> }
> new Foo().testMutation(2)''', 'Test')
> }
> }
> {code}
> If the `AutoFinal` annotation *in the script* is removed, the test will fail. In which case, `AutoFinal` is applied, but not with the annotation parameters. I added a `Log` AST transformation just to make sure I used the right way to apply an AST transformation with annotation parameters.
> Not so related:
> Why do I want `AutoFinal(enabled = false)` via `ASTTransformationCustomizer`? I was trying to apply `AutoFinal` on all possible types. However `AutoFinal` would throw an exception when applied on an interface. And I was testing whether I could use `SourceAwareCustomizer` to disable `AutoFinal` for interfaces.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)