You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@sling.apache.org by GitBox <gi...@apache.org> on 2019/12/20 15:37:07 UTC
[GitHub] [sling-org-apache-sling-distribution-journal] cschneider opened a
new pull request #19: SLING-8944 - Systemready check for idle subscriber
cschneider opened a new pull request #19: SLING-8944 - Systemready check for idle subscriber
URL: https://github.com/apache/sling-org-apache-sling-distribution-journal/pull/19
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [sling-org-apache-sling-distribution-journal] tmaret commented on
issue #19: SLING-8944 - Systemready check for idle subscriber
Posted by GitBox <gi...@apache.org>.
tmaret commented on issue #19: SLING-8944 - Systemready check for idle subscriber
URL: https://github.com/apache/sling-org-apache-sling-distribution-journal/pull/19#issuecomment-568463194
The new hooks make sense to me. However, I think that there's a bug in the code. I may be mistaken since I looked at it quickly. The schedule is currently canceled with
```
schedule.cancel(false);
```
which allows it to complete when started.
If we keep scheduling task per import, we should cancel it with
```
schedule.cancel(true);
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [sling-org-apache-sling-distribution-journal] cschneider commented
on issue #19: SLING-8944 - Systemready check for idle subscriber
Posted by GitBox <gi...@apache.org>.
cschneider commented on issue #19: SLING-8944 - Systemready check for idle subscriber
URL: https://github.com/apache/sling-org-apache-sling-distribution-journal/pull/19#issuecomment-568165200
Makes sense. I have change the logic to use and busy() and idle() method. Those are simply called when package processing starts and ends. I hope this does it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [sling-org-apache-sling-distribution-journal] cschneider commented
on issue #19: SLING-8944 - Systemready check for idle subscriber
Posted by GitBox <gi...@apache.org>.
cschneider commented on issue #19: SLING-8944 - Systemready check for idle subscriber
URL: https://github.com/apache/sling-org-apache-sling-distribution-journal/pull/19#issuecomment-568467045
Makes sense to not schedule when ready.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [sling-org-apache-sling-distribution-journal] tmaret edited a
comment on issue #19: SLING-8944 - Systemready check for idle subscriber
Posted by GitBox <gi...@apache.org>.
tmaret edited a comment on issue #19: SLING-8944 - Systemready check for idle subscriber
URL: https://github.com/apache/sling-org-apache-sling-distribution-journal/pull/19#issuecomment-568463194
The new hooks make sense to me. However, I think that there's a bug in the code. I may be mistaken since I looked at it quickly. The schedule is currently canceled with
```
schedule.cancel(false);
```
which allows it to complete a schedule when started.
If we keep submitting a schedule per import, we should cancel it with
```
schedule.cancel(true);
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [sling-org-apache-sling-distribution-journal] cschneider commented
on issue #19: SLING-8944 - Systemready check for idle subscriber
Posted by GitBox <gi...@apache.org>.
cschneider commented on issue #19: SLING-8944 - Systemready check for idle subscriber
URL: https://github.com/apache/sling-org-apache-sling-distribution-journal/pull/19#issuecomment-568465103
I think true or false only makes a difference if the task is currently running. As executing the task takes virtually no time I think it does not make sense to try to interrupt it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [sling-org-apache-sling-distribution-journal] tmaret commented on
issue #19: SLING-8944 - Systemready check for idle subscriber
Posted by GitBox <gi...@apache.org>.
tmaret commented on issue #19: SLING-8944 - Systemready check for idle subscriber
URL: https://github.com/apache/sling-org-apache-sling-distribution-journal/pull/19#issuecomment-568466727
One suggestion, when the service is ready, it is no longer necessary to schedule tasks for each import.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [sling-org-apache-sling-distribution-journal] tmaret commented on
issue #19: SLING-8944 - Systemready check for idle subscriber
Posted by GitBox <gi...@apache.org>.
tmaret commented on issue #19: SLING-8944 - Systemready check for idle subscriber
URL: https://github.com/apache/sling-org-apache-sling-distribution-journal/pull/19#issuecomment-568466467
I think you are correct.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [sling-org-apache-sling-distribution-journal] cschneider merged
pull request #19: SLING-8944 - Systemready check for idle subscriber
Posted by GitBox <gi...@apache.org>.
cschneider merged pull request #19: SLING-8944 - Systemready check for idle subscriber
URL: https://github.com/apache/sling-org-apache-sling-distribution-journal/pull/19
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services