[GitHub] [avro] steven-aerts commented on pull request #1708: AVRO-3527: Generated equals() and hashCode() for SpecificRecords

[GitBox <gi...@apache.org>]

steven-aerts commented on PR #1708:
URL: https://github.com/apache/avro/pull/1708#issuecomment-1149496779

   @RyanSkraba there is one small corner case, which let me doubt.
   
   When using `CharSequence` as `stringType`, the `equals` method uses a newly introduced `Utf8#compareSequences`.  As we could not use `java.lang.CharSequence#compare` which is only [available since java 11](https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/lang/CharSequence.html#compare(java.lang.CharSequence,java.lang.CharSequence)).
   
   If we choose to introduce this change as a minor version.  It would mean that for the `Charsequence` `stringType`, the code generated by an 1.11.1 compiler is incompatible with a 1.11.0 avro library.  Everything else should work in that constellation.
   
   Do you see that as a reason to introduce it in a major version only?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org