You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Anand Mazumdar <an...@apache.org> on 2017/01/25 19:47:18 UTC

Review Request 55938: Renamed `streamingRequest` to `streamingMediaType`.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55938/
-----------------------------------------------------------

Review request for mesos and Vinod Kone.


Bugs: MESOS-6936
    https://issues.apache.org/jira/browse/MESOS-6936


Repository: mesos


Description
-------

This allows the method to be used both for detecting if the
media type can be used for streaming requests and responses.
Also, the method now returns true for `ContentType::RECORDIO`
media type.


Diffs
-----

  src/common/http.hpp fc2ac148744bb819944044540fe7274bac0d60ba 
  src/common/http.cpp c65c79e3f689b32fb9e62062fbc297b10501dcfe 

Diff: https://reviews.apache.org/r/55938/diff/


Testing
-------

make check


Thanks,

Anand Mazumdar

Re: Review Request 55938: Renamed `streamingRequest` to `streamingMediaType`.

Posted by Vinod Kone <vi...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55938/#review163052
-----------------------------------------------------------


Ship it!




Ship It!

- Vinod Kone


On Jan. 25, 2017, 7:47 p.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55938/
> -----------------------------------------------------------
> 
> (Updated Jan. 25, 2017, 7:47 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-6936
>     https://issues.apache.org/jira/browse/MESOS-6936
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This allows the method to be used both for detecting if the
> media type can be used for streaming requests and responses.
> Also, the method now returns true for `ContentType::RECORDIO`
> media type.
> 
> 
> Diffs
> -----
> 
>   src/common/http.hpp fc2ac148744bb819944044540fe7274bac0d60ba 
>   src/common/http.cpp c65c79e3f689b32fb9e62062fbc297b10501dcfe 
> 
> Diff: https://reviews.apache.org/r/55938/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>