[jira] [Commented] (OMID-223) Refactor Omid to use HBase 2 APIs internally.

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OMID-223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17580252#comment-17580252 ] 

ASF GitHub Bot commented on OMID-223:
-------------------------------------

Aarchy commented on code in PR #109:
URL: https://github.com/apache/phoenix-omid/pull/109#discussion_r946647852


##########
hbase-coprocessor/src/main/java/org/apache/omid/transaction/CellSkipFilterBase.java:
##########
@@ -53,21 +53,21 @@ public CellSkipFilterBase(Filter filter) {
      */
     private boolean skipCellVersion(Cell cell) {
         return skipColumn != null
-        && CellUtil.matchingRow(cell, skipColumn.getRowArray(), skipColumn.getRowOffset(),
+        && PrivateCellUtil.matchingRows(cell, skipColumn.getRowArray(), skipColumn.getRowOffset(),

Review Comment:
   With @stoty we came up with the solution to duplicate the FirstOnRowCell class (and createFirstOnRow function) from PrivateCellUtil to the Omid codebase. However, this class has several IA.Private base classes. Could it be derived directly from Cell or are the base classes also necessary in Omid? Or is there anything we missed in CellUtil to replace the KeyValueUtil.createFirstOnRow call?





> Refactor Omid to use HBase 2 APIs internally.
> ---------------------------------------------
>
>                 Key: OMID-223
>                 URL: https://issues.apache.org/jira/browse/OMID-223
>             Project: Phoenix Omid
>          Issue Type: Improvement
>            Reporter: Istvan Toth
>            Assignee: Aron Attila Meszaros
>            Priority: Major
>         Attachments: OMID-223-wip.patch
>
>
> Omid currently uses HBase 1 APIs everywhere. 
> This made sense when HBase 1 and 2 had to be supported from the same codebase.
> However, as we're dropping HBase 1 support, this is a liability now.
> Doing this is also going to eventually make supporting HBase 3 much easier.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)