You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2013/03/02 23:08:46 UTC
Re: Review Request: More user-friendly cgroups OOM messages.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9121/
-----------------------------------------------------------
(Updated March 2, 2013, 10:08 p.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Changes
-------
Rebased off trunk.
Description
-------
This is to make the OOM messages friendlier to the end-users of mesos.
Diffs (updated)
-----
src/slave/cgroups_isolation_module.cpp a779de80d13c67e507d7d2ee788fcdaa5e71daca
Diff: https://reviews.apache.org/r/9121/diff/
Testing
-------
make check
ran balloon framework to verify OOM messages:
I0128 19:50:11.577399 49752 hierarchical_allocator_process.hpp:542] Recovered mem=32 (total allocatable: cpus=1; mem=32) on slave 201301281950-2081170186-5432-49731-0 from framework 201301281950-2081170186-5432-49731-0000
Task in state TASK_FAILED
Reason: Memory limit exceeded: Requested: 96MB Used: 96MB
MEMORY STATISTICS:
cache 249856
rss 100413440
mapped_file 24576
pgpgin 7872
pgpgout 6802
inactive_anon 0
active_anon 1761280
inactive_file 192512
active_file 57344
unevictable 98652160
hierarchical_memory_limit 100663296
total_cache 249856
total_rss 100413440
total_mapped_file 24576
total_pgpgin 7872
total_pgpgout 6802
total_inactive_anon 0
total_active_anon 1761280
total_inactive_file 192512
total_active_file 57344
total_unevictable 98652160
Thanks,
Ben Mahler
Re: Review Request: More user-friendly cgroups OOM messages.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9121/#review17401
-----------------------------------------------------------
Ship it!
src/slave/cgroups_isolation_module.cpp
<https://reviews.apache.org/r/9121/#comment36928>
I think we've been putting cgroup file names in single quotes, i.e., 'memory.limit_in_bytes' (below too for 'memory.usage_in_bytes').
- Benjamin Hindman
On March 2, 2013, 10:08 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9121/
> -----------------------------------------------------------
>
> (Updated March 2, 2013, 10:08 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> This is to make the OOM messages friendlier to the end-users of mesos.
>
>
> Diffs
> -----
>
> src/slave/cgroups_isolation_module.cpp a779de80d13c67e507d7d2ee788fcdaa5e71daca
>
> Diff: https://reviews.apache.org/r/9121/diff/
>
>
> Testing
> -------
>
> make check
>
> ran balloon framework to verify OOM messages:
>
> I0128 19:50:11.577399 49752 hierarchical_allocator_process.hpp:542] Recovered mem=32 (total allocatable: cpus=1; mem=32) on slave 201301281950-2081170186-5432-49731-0 from framework 201301281950-2081170186-5432-49731-0000
> Task in state TASK_FAILED
> Reason: Memory limit exceeded: Requested: 96MB Used: 96MB
>
> MEMORY STATISTICS:
> cache 249856
> rss 100413440
> mapped_file 24576
> pgpgin 7872
> pgpgout 6802
> inactive_anon 0
> active_anon 1761280
> inactive_file 192512
> active_file 57344
> unevictable 98652160
> hierarchical_memory_limit 100663296
> total_cache 249856
> total_rss 100413440
> total_mapped_file 24576
> total_pgpgin 7872
> total_pgpgout 6802
> total_inactive_anon 0
> total_active_anon 1761280
> total_inactive_file 192512
> total_active_file 57344
> total_unevictable 98652160
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: More user-friendly cgroups OOM messages.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9121/
-----------------------------------------------------------
(Updated March 5, 2013, 7:24 p.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Changes
-------
Updated to trunk + benh review.
Description
-------
This is to make the OOM messages friendlier to the end-users of mesos.
Diffs (updated)
-----
src/slave/cgroups_isolation_module.cpp ea3e1d31a504425c4d32bbcf975cb3d26ffea87e
Diff: https://reviews.apache.org/r/9121/diff/
Testing
-------
make check
ran balloon framework to verify OOM messages:
I0128 19:50:11.577399 49752 hierarchical_allocator_process.hpp:542] Recovered mem=32 (total allocatable: cpus=1; mem=32) on slave 201301281950-2081170186-5432-49731-0 from framework 201301281950-2081170186-5432-49731-0000
Task in state TASK_FAILED
Reason: Memory limit exceeded: Requested: 96MB Used: 96MB
MEMORY STATISTICS:
cache 249856
rss 100413440
mapped_file 24576
pgpgin 7872
pgpgout 6802
inactive_anon 0
active_anon 1761280
inactive_file 192512
active_file 57344
unevictable 98652160
hierarchical_memory_limit 100663296
total_cache 249856
total_rss 100413440
total_mapped_file 24576
total_pgpgin 7872
total_pgpgout 6802
total_inactive_anon 0
total_active_anon 1761280
total_inactive_file 192512
total_active_file 57344
total_unevictable 98652160
Thanks,
Ben Mahler