You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Anonymous Coward (Code Review)" <ge...@cloudera.org> on 2022/07/26 02:26:31 UTC
[Impala-ASF-CR] IMPALA-11454: part-1: use standard binaries path to start kudu test cluster
yx91490@126.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18777
Change subject: IMPALA-11454: part-1: use standard binaries path to start kudu test cluster
......................................................................
IMPALA-11454: part-1: use standard binaries path to start kudu test cluster
The standard apache kudu binaries (kudu-master and kudu-tserver) only
exists in /sbin, however the toolchain packaging script will also copy
them to /bin, leading to larger package size.
This patch use /sbin/kudu-(master|tserver) to start kudu test cluster,
then we can drop /bin/kudu-(master|tserver) in toolchain package later.
Testing:
run existing CI jobs.
Change-Id: I2276ee3e1650532770b856443f1087ad5036dc7a
---
M testdata/cluster/node_templates/common/etc/init.d/kudu-common
M testdata/cluster/node_templates/common/etc/init.d/kudu-master
M testdata/cluster/node_templates/common/etc/init.d/kudu-tserver
3 files changed, 7 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/77/18777/3
--
To view, visit http://gerrit.cloudera.org:8080/18777
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2276ee3e1650532770b856443f1087ad5036dc7a
Gerrit-Change-Number: 18777
Gerrit-PatchSet: 3
Gerrit-Owner: Anonymous Coward <yx...@126.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-11454: part-1: use standard binaries path to start kudu test cluster
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18777 )
Change subject: IMPALA-11454: part-1: use standard binaries path to start kudu test cluster
......................................................................
Patch Set 4: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/18777
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2276ee3e1650532770b856443f1087ad5036dc7a
Gerrit-Change-Number: 18777
Gerrit-PatchSet: 4
Gerrit-Owner: Xiang Yang <yx...@126.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Xiang Yang <yx...@126.com>
Gerrit-Comment-Date: Wed, 03 Aug 2022 13:01:48 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11454: part-1: use standard binaries path to start kudu test cluster
Posted by "Xiang Yang (Code Review)" <ge...@cloudera.org>.
Xiang Yang has removed Wenzhe Zhou from this change. ( http://gerrit.cloudera.org:8080/18777 )
Change subject: IMPALA-11454: part-1: use standard binaries path to start kudu test cluster
......................................................................
Removed reviewer Wenzhe Zhou.
--
To view, visit http://gerrit.cloudera.org:8080/18777
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: I2276ee3e1650532770b856443f1087ad5036dc7a
Gerrit-Change-Number: 18777
Gerrit-PatchSet: 4
Gerrit-Owner: Xiang Yang <yx...@126.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Xiang Yang <yx...@126.com>
[Impala-ASF-CR] IMPALA-11454: part-1: use standard binaries path to start kudu test cluster
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18777 )
Change subject: IMPALA-11454: part-1: use standard binaries path to start kudu test cluster
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18777
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2276ee3e1650532770b856443f1087ad5036dc7a
Gerrit-Change-Number: 18777
Gerrit-PatchSet: 4
Gerrit-Owner: Xiang Yang <yx...@126.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Xiang Yang <yx...@126.com>
Gerrit-Comment-Date: Wed, 03 Aug 2022 08:00:51 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11454: part-1: use standard binaries path to start kudu test cluster
Posted by "Xiang Yang (Code Review)" <ge...@cloudera.org>.
Xiang Yang has removed Joe McDonnell from this change. ( http://gerrit.cloudera.org:8080/18777 )
Change subject: IMPALA-11454: part-1: use standard binaries path to start kudu test cluster
......................................................................
Removed reviewer Joe McDonnell.
--
To view, visit http://gerrit.cloudera.org:8080/18777
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: I2276ee3e1650532770b856443f1087ad5036dc7a
Gerrit-Change-Number: 18777
Gerrit-PatchSet: 4
Gerrit-Owner: Xiang Yang <yx...@126.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Xiang Yang <yx...@126.com>
[Impala-ASF-CR] IMPALA-11454: part-1: use standard binaries path to start kudu test cluster
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18777 )
Change subject: IMPALA-11454: part-1: use standard binaries path to start kudu test cluster
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18777
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2276ee3e1650532770b856443f1087ad5036dc7a
Gerrit-Change-Number: 18777
Gerrit-PatchSet: 4
Gerrit-Owner: Xiang Yang <yx...@126.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Xiang Yang <yx...@126.com>
Gerrit-Comment-Date: Wed, 03 Aug 2022 08:19:47 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11454: part-1: use standard binaries path to start kudu test cluster
Posted by "Xiang Yang (Code Review)" <ge...@cloudera.org>.
Xiang Yang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18777 )
Change subject: IMPALA-11454: part-1: use standard binaries path to start kudu test cluster
......................................................................
Patch Set 3:
> Patch Set 3:
>
> > Patch Set 3:
> >
> > > Patch Set 3: Code-Review+1
> > >
> > > This makes sense to me. I think a simpler fix is modifying the toolchain build script to create symlinks pointing to sbin instead of copying binaries directly, as you mentioned in the JIRA: https://github.com/cloudera/native-toolchain/blob/2008e0658c1785ab7a78866e6f46ee6d9214c446/source/kudu/build.sh#L170-L176
> > >
> > > Either way is ok for me. I'll see if other reviews have more comments.
> >
> > Hi quanlong, the symlinks way also can achive the goal that reduce toolchain package's size; but when users don't want to use the cdp edition kudu, they may meet the lacking of '/bin/kudu-master' problem.
>
> The symlink is something like 'bin/kudu-master' -> 'sbin/kudu-master'. Why users will meet the lacking of '/bin/kudu-master' problem?
Sorry what I mean of 'cdp edition kudu' is the toolchain builtin kudu. I mean If user don't use native-toolchain build script to build kudu, they may meet the lacking problem.
--
To view, visit http://gerrit.cloudera.org:8080/18777
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2276ee3e1650532770b856443f1087ad5036dc7a
Gerrit-Change-Number: 18777
Gerrit-PatchSet: 3
Gerrit-Owner: Xiang Yang <yx...@126.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Xiang Yang <yx...@126.com>
Gerrit-Comment-Date: Wed, 03 Aug 2022 08:07:47 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11454: part-1: use standard binaries path to start kudu test cluster
Posted by "Xiang Yang (Code Review)" <ge...@cloudera.org>.
Xiang Yang has removed Impala Public Jenkins from this change. ( http://gerrit.cloudera.org:8080/18777 )
Change subject: IMPALA-11454: part-1: use standard binaries path to start kudu test cluster
......................................................................
Removed reviewer Impala Public Jenkins with the following votes:
* Code-Review+2 by Impala Public Jenkins <im...@cloudera.com>
--
To view, visit http://gerrit.cloudera.org:8080/18777
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: I2276ee3e1650532770b856443f1087ad5036dc7a
Gerrit-Change-Number: 18777
Gerrit-PatchSet: 4
Gerrit-Owner: Xiang Yang <yx...@126.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Xiang Yang <yx...@126.com>
[Impala-ASF-CR] IMPALA-11454: part-1: use standard binaries path to start kudu test cluster
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18777 )
Change subject: IMPALA-11454: part-1: use standard binaries path to start kudu test cluster
......................................................................
Patch Set 3:
> Patch Set 3:
>
> > Patch Set 3: Code-Review+1
> >
> > This makes sense to me. I think a simpler fix is modifying the toolchain build script to create symlinks pointing to sbin instead of copying binaries directly, as you mentioned in the JIRA: https://github.com/cloudera/native-toolchain/blob/2008e0658c1785ab7a78866e6f46ee6d9214c446/source/kudu/build.sh#L170-L176
> >
> > Either way is ok for me. I'll see if other reviews have more comments.
>
> Hi quanlong, the symlinks way also can achive the goal that reduce toolchain package's size; but when users don't want to use the cdp edition kudu, they may meet the lacking of '/bin/kudu-master' problem.
The symlink is something like 'bin/kudu-master' -> 'sbin/kudu-master'. Why users will meet the lacking of '/bin/kudu-master' problem?
--
To view, visit http://gerrit.cloudera.org:8080/18777
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2276ee3e1650532770b856443f1087ad5036dc7a
Gerrit-Change-Number: 18777
Gerrit-PatchSet: 3
Gerrit-Owner: Xiang Yang <yx...@126.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Xiang Yang <yx...@126.com>
Gerrit-Comment-Date: Wed, 03 Aug 2022 03:02:05 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11454: part-1: use standard binaries path to start kudu test cluster
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18777 )
Change subject: IMPALA-11454: part-1: use standard binaries path to start kudu test cluster
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/18777
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2276ee3e1650532770b856443f1087ad5036dc7a
Gerrit-Change-Number: 18777
Gerrit-PatchSet: 3
Gerrit-Owner: Anonymous Coward <yx...@126.com>
Gerrit-Reviewer: Anonymous Coward <yx...@126.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 29 Jul 2022 04:16:19 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11454: part-1: use standard binaries path to start kudu test cluster
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18777 )
Change subject: IMPALA-11454: part-1: use standard binaries path to start kudu test cluster
......................................................................
IMPALA-11454: part-1: use standard binaries path to start kudu test cluster
The standard apache kudu binaries (kudu-master and kudu-tserver) only
exists in /sbin, however the toolchain packaging script will also copy
them to /bin, leading to larger package size.
This patch use /sbin/kudu-(master|tserver) to start kudu test cluster,
then we can drop /bin/kudu-(master|tserver) in toolchain package later.
Testing:
run existing CI jobs.
Change-Id: I2276ee3e1650532770b856443f1087ad5036dc7a
Reviewed-on: http://gerrit.cloudera.org:8080/18777
Reviewed-by: Quanlong Huang <hu...@gmail.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M testdata/cluster/node_templates/common/etc/init.d/kudu-common
M testdata/cluster/node_templates/common/etc/init.d/kudu-master
M testdata/cluster/node_templates/common/etc/init.d/kudu-tserver
3 files changed, 7 insertions(+), 7 deletions(-)
Approvals:
Quanlong Huang: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/18777
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I2276ee3e1650532770b856443f1087ad5036dc7a
Gerrit-Change-Number: 18777
Gerrit-PatchSet: 5
Gerrit-Owner: Xiang Yang <yx...@126.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Xiang Yang <yx...@126.com>
[Impala-ASF-CR] IMPALA-11454: part-1: use standard binaries path to start kudu test cluster
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18777 )
Change subject: IMPALA-11454: part-1: use standard binaries path to start kudu test cluster
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8390/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/18777
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2276ee3e1650532770b856443f1087ad5036dc7a
Gerrit-Change-Number: 18777
Gerrit-PatchSet: 4
Gerrit-Owner: Xiang Yang <yx...@126.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Xiang Yang <yx...@126.com>
Gerrit-Comment-Date: Wed, 03 Aug 2022 08:00:51 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11454: part-1: use standard binaries path to start kudu test cluster
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
yx91490@126.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/18777 )
Change subject: IMPALA-11454: part-1: use standard binaries path to start kudu test cluster
......................................................................
Patch Set 3:
Hi Quanlong, can you help me to review this issue?
--
To view, visit http://gerrit.cloudera.org:8080/18777
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2276ee3e1650532770b856443f1087ad5036dc7a
Gerrit-Change-Number: 18777
Gerrit-PatchSet: 3
Gerrit-Owner: Anonymous Coward <yx...@126.com>
Gerrit-Reviewer: Anonymous Coward <yx...@126.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 26 Jul 2022 02:27:46 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11454: part-1: use standard binaries path to start kudu test cluster
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18777 )
Change subject: IMPALA-11454: part-1: use standard binaries path to start kudu test cluster
......................................................................
Patch Set 3: Code-Review+1
This makes sense to me. I think a simpler fix is modifying the toolchain build script to create symlinks pointing to sbin instead of copying binaries directly, as you mentioned in the JIRA: https://github.com/cloudera/native-toolchain/blob/2008e0658c1785ab7a78866e6f46ee6d9214c446/source/kudu/build.sh#L170-L176
Either way is ok for me. I'll see if other reviews have more comments.
--
To view, visit http://gerrit.cloudera.org:8080/18777
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2276ee3e1650532770b856443f1087ad5036dc7a
Gerrit-Change-Number: 18777
Gerrit-PatchSet: 3
Gerrit-Owner: Anonymous Coward <yx...@126.com>
Gerrit-Reviewer: Anonymous Coward <yx...@126.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 29 Jul 2022 01:42:47 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11454: part-1: use standard binaries path to start kudu test cluster
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18777 )
Change subject: IMPALA-11454: part-1: use standard binaries path to start kudu test cluster
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/11038/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18777
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2276ee3e1650532770b856443f1087ad5036dc7a
Gerrit-Change-Number: 18777
Gerrit-PatchSet: 3
Gerrit-Owner: Anonymous Coward <yx...@126.com>
Gerrit-Reviewer: Anonymous Coward <yx...@126.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 26 Jul 2022 02:47:27 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11454: part-1: use standard binaries path to start kudu test cluster
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
yx91490@126.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/18777 )
Change subject: IMPALA-11454: part-1: use standard binaries path to start kudu test cluster
......................................................................
Patch Set 3:
> Patch Set 3: Code-Review+1
>
> This makes sense to me. I think a simpler fix is modifying the toolchain build script to create symlinks pointing to sbin instead of copying binaries directly, as you mentioned in the JIRA: https://github.com/cloudera/native-toolchain/blob/2008e0658c1785ab7a78866e6f46ee6d9214c446/source/kudu/build.sh#L170-L176
>
> Either way is ok for me. I'll see if other reviews have more comments.
Hi quanlong, the symlinks way also can achive the goal that reduce toolchain package's size; but when users don't want to use the cdp edition kudu, they may meet the lacking of '/bin/kudu-master' problem.
--
To view, visit http://gerrit.cloudera.org:8080/18777
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2276ee3e1650532770b856443f1087ad5036dc7a
Gerrit-Change-Number: 18777
Gerrit-PatchSet: 3
Gerrit-Owner: Anonymous Coward <yx...@126.com>
Gerrit-Reviewer: Anonymous Coward <yx...@126.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 29 Jul 2022 06:35:05 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11454: part-1: use standard binaries path to start kudu test cluster
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18777 )
Change subject: IMPALA-11454: part-1: use standard binaries path to start kudu test cluster
......................................................................
Patch Set 3: Code-Review+2
> Patch Set 3:
>
> > Patch Set 3:
> >
> > > Patch Set 3: Code-Review+1
> > >
> > > This makes sense to me. I think a simpler fix is modifying the toolchain build script to create symlinks pointing to sbin instead of copying binaries directly, as you mentioned in the JIRA: https://github.com/cloudera/native-toolchain/blob/2008e0658c1785ab7a78866e6f46ee6d9214c446/source/kudu/build.sh#L170-L176
> > >
> > > Either way is ok for me. I'll see if other reviews have more comments.
> >
> > Hi quanlong, the symlinks way also can achive the goal that reduce toolchain package's size; but when users don't want to use the cdp edition kudu, they may meet the lacking of '/bin/kudu-master' problem.
>
> The symlink is something like 'bin/kudu-master' -> 'sbin/kudu-master'. Why users will meet the lacking of '/bin/kudu-master' problem?
I get clear with some offline discussion. 'bin/kudu-master' is a file generated by native-toolchain build script. If users want to compile Impala with their customized kudu artifacts, 'bin/kudu-master' will be missing.
Carry Wenzhe's +1 to +2.
--
To view, visit http://gerrit.cloudera.org:8080/18777
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2276ee3e1650532770b856443f1087ad5036dc7a
Gerrit-Change-Number: 18777
Gerrit-PatchSet: 3
Gerrit-Owner: Xiang Yang <yx...@126.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Xiang Yang <yx...@126.com>
Gerrit-Comment-Date: Wed, 03 Aug 2022 08:00:12 +0000
Gerrit-HasComments: No