You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2017/03/01 00:30:24 UTC

[kudu-CR] spark: send authentication credentials to tasks

Todd Lipcon has posted comments on this change.

Change subject: spark: send authentication credentials to tasks
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/6081/3/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala
File java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala:

Line 62:   private[kudu] var authnCredentials : Array[Byte] =
> Not sure I fully understand.  To me this code looks a little suspicious bec
oh, my mistake, it can be a val. I had tried val in a previous iteration of the patch and it didn't work, but must have reorganized some stuff since then.


-- 
To view, visit http://gerrit.cloudera.org:8080/6081
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7be2c72eb801c3ee10e576ce8705c3b5997dffd9
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Chris George <ch...@rms.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes