You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by mgaido91 <gi...@git.apache.org> on 2018/05/07 07:14:18 UTC

[GitHub] spark pull request #21256: [SPARK-24160][FOLLOWUP] Fix compilation failure

GitHub user mgaido91 opened a pull request:

    https://github.com/apache/spark/pull/21256

    [SPARK-24160][FOLLOWUP] Fix compilation failure

    ## What changes were proposed in this pull request?
    
    SPARK-24160 is causing a compilation failure (after SPARK-24143 was merged). This fixes the issue.
    
    ## How was this patch tested?
    
    building successfully

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mgaido91/spark SPARK-24160_FOLLOWUP

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/21256.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #21256
    
----
commit d8fecb52918dd34fd38a7d1c3989f91096411e32
Author: Marco Gaido <ma...@...>
Date:   2018-05-07T07:12:04Z

    [SPARK-24160][FOLLOWUP] Fix compilation failure

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #21256: [SPARK-24160][FOLLOWUP] Fix compilation failure

Posted by viirya <gi...@git.apache.org>.
Github user viirya commented on the issue:

    https://github.com/apache/spark/pull/21256
  
    LGTM


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #21256: [SPARK-24160][FOLLOWUP] Fix compilation failure

Posted by mgaido91 <gi...@git.apache.org>.
Github user mgaido91 commented on the issue:

    https://github.com/apache/spark/pull/21256
  
    cc @cloud-fan @JoshRosen @jinxing64 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #21256: [SPARK-24160][FOLLOWUP] Fix compilation failure

Posted by cloud-fan <gi...@git.apache.org>.
Github user cloud-fan commented on the issue:

    https://github.com/apache/spark/pull/21256
  
    thanks! I'm merging it to unblock the build, since it already passes the compilation.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #21256: [SPARK-24160][FOLLOWUP] Fix compilation failure

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/21256
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #21256: [SPARK-24160][FOLLOWUP] Fix compilation failure

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/21256
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90300/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #21256: [SPARK-24160][FOLLOWUP] Fix compilation failure

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/21256
  
    **[Test build #90300 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90300/testReport)** for PR 21256 at commit [`d8fecb5`](https://github.com/apache/spark/commit/d8fecb52918dd34fd38a7d1c3989f91096411e32).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #21256: [SPARK-24160][FOLLOWUP] Fix compilation failure

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/spark/pull/21256


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #21256: [SPARK-24160][FOLLOWUP] Fix compilation failure

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/21256
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #21256: [SPARK-24160][FOLLOWUP] Fix compilation failure

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/21256
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2983/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #21256: [SPARK-24160][FOLLOWUP] Fix compilation failure

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/21256
  
    **[Test build #90300 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90300/testReport)** for PR 21256 at commit [`d8fecb5`](https://github.com/apache/spark/commit/d8fecb52918dd34fd38a7d1c3989f91096411e32).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org