[issues] New comment: (FOR-261) no external-link icons when group-url=""

[is...@cocoondev.org]

The following comment has been added to this issue:

     Author: Johannes Schaefer
    Created: Fri, 20 Aug 2004 5:23 PM
       Body:
this seems to fix the issue:
in site2xhtml.xsl 
change

<xsl:when test="not($disable-external-link-image='true') and contains(@href, ':') and not(contains(@href, //skinconfig/group-url))   and not(contains(@href, //skinconfig/project-url)) ">

to

<xsl:when test="not($disable-external-link-image='true') and contains(@href, ':') 
  and ( //skinconfig/group-url=''   or not(contains(@href, //skinconfig/group-url))   ) 
  and ( //skinconfig/project-url='' or not(contains(@href, //skinconfig/project-url)) ) ">


(My patch doesn't work correctly, this is from patch.txt)

Index: src/core/context/skins/common/xslt/html/site2xhtml.xsl
===================================================================
--- src/core/context/skins/common/xslt/html/site2xhtml.xsl      (revision 36667)

+++ src/core/context/skins/common/xslt/html/site2xhtml.xsl      (working copy)
@@ -263,7 +263,10 @@
             <xsl:apply-templates/>
           </a>
        </xsl:when>
-       <xsl:when test="not($disable-external-link-image='true') and contains(@h
ref, ':') and not(contains(@href, //skinconfig/group-url)) and not(contains(@hre
f, //skinconfig/project-url))">
+       <xsl:when test="not($disable-external-link-image='true')
+             and contains(@href, ':')
+             and ( //skinconfig/group-url=''   or not(contains(@href, //skincon
fig/group-url))   )
+             and ( //skinconfig/project-url='' or not(contains(@href, //skincon
fig/project-url)) ) ">
           <a href="{@href}" class="external">
             <xsl:apply-templates/>
           </a>

---------------------------------------------------------------------
View the issue:

  http://issues.cocoondev.org/jira//secure/ViewIssue.jspa?key=FOR-261


Here is an overview of the issue:
---------------------------------------------------------------------
        Key: FOR-261
    Summary: no external-link icons when group-url="" 
       Type: Bug

     Status: Unassigned
   Priority: Minor

    Project: Forrest
  Component: None
   Versions:
             0.6

   Assignee: 
   Reporter: Johannes Schaefer

    Created: Fri, 20 Aug 2004 4:50 PM
    Updated: Fri, 20 Aug 2004 4:50 PM
Environment: all

Description:
When setting group-url in skinconf.xml to "" (empty string) or deleting it at all (<!-- ... -->) the icons after the external links are no longer displayed (although disable-external-link-image=false). group-url=" " suffices to show them again.


---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://issues.cocoondev.org/jira//Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira