[GitHub] [bookkeeper] eolivelli commented on pull request #2668: Fix logic in Bookkeeper forceAllowCompaction to run only when force i…

[GitBox <gi...@apache.org>]

eolivelli commented on pull request #2668:
URL: https://github.com/apache/bookkeeper/pull/2668#issuecomment-810187311


   thank you very much for this patch
   
   There are test failures, can you please check?
   
   for instance:
   ```
   Error:  org.apache.bookkeeper.bookie.CompactionByEntriesTest.testForceGarbageCollection  Time elapsed: 0.941 s  <<< FAILURE!
   java.lang.AssertionError: Minor or major compaction did not trigger even on forcing.
   	at org.junit.Assert.fail(Assert.java:88)
   	at org.junit.Assert.assertTrue(Assert.java:41)
   	at org.apache.bookkeeper.bookie.CompactionTest.lambda$testForceGarbageCollection$0(CompactionTest.java:312)
   	at org.apache.bookkeeper.meta.MetadataDrivers.lambda$runFunctionWithLedgerManagerFactory$2(MetadataDrivers.java:389)
   	at org.apache.bookkeeper.meta.MetadataDrivers.runFunctionWithMetadataBookieDriver(MetadataDrivers.java:347)
   	at org.apache.bookkeeper.meta.MetadataDrivers.runFunctionWithLedgerManagerFactory(MetadataDrivers.java:387)
   	at org.apache.bookkeeper.bookie.CompactionTest.testForceGarbageCollection(CompactionTest.java:292)
   	at org.apache.bookkeeper.bookie.CompactionTest.testForceGarbageCollection(CompactionTest.java:255)
   	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
   	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
   ```
   
   also, can you please verify if there is a test that covers your change, or add a new test case ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org