[GitHub] [hudi] danny0405 commented on a diff in pull request #7718: [HUDI-5591] HoodieSparkSqlWriter#getHiveTableNames needs to consider …

["danny0405 (via GitHub)" <gi...@apache.org>]

danny0405 commented on code in PR #7718:
URL: https://github.com/apache/hudi/pull/7718#discussion_r1095456393


##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieSparkSqlWriter.scala:
##########
@@ -879,13 +880,17 @@ object HoodieSparkSqlWriter {
     if (tableType.equals(COW_TABLE_TYPE_OPT_VAL)) {
       List(tableName)
     } else {
-      val roSuffix = if (hoodieConfig.getBooleanOrDefault(HIVE_SKIP_RO_SUFFIX_FOR_READ_OPTIMIZED_TABLE)) {
-        ""
+      if (!hoodieConfig.getStringOrDefault(HIVE_SYNC_TABLE_STRATEGY).equals(HoodieSyncTableStrategy.ALL.name())) {
+        List(tableName)
       } else {
-        HiveSyncTool.SUFFIX_READ_OPTIMIZED_TABLE
+        val roSuffix = if (hoodieConfig.getBooleanOrDefault(HIVE_SKIP_RO_SUFFIX_FOR_READ_OPTIMIZED_TABLE)) {
+          ""
+        } else {

Review Comment:
   Can we try to add some tests here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org