[GitHub] [hive] vihangk1 commented on a diff in pull request #4172: HIVE-26949: Backport HIVE-26071 to branch-3

["vihangk1 (via GitHub)" <gi...@apache.org>]

vihangk1 commented on code in PR #4172:
URL: https://github.com/apache/hive/pull/4172#discussion_r1152777492


##########
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java:
##########
@@ -552,6 +552,17 @@ public enum ConfVars {
         "hive-metastore/_HOST@EXAMPLE.COM",
         "The service principal for the metastore Thrift server. \n" +
             "The special string _HOST will be replaced automatically with the correct host name."),
+    THRIFT_METASTORE_AUTHENTICATION("metastore.authentication", "hive.metastore.authentication",
+            "NONE",
+            new StringSetValidator("NONE", "JWT"),
+            "Client authentication types. Currently, only used in HTTP mode. For using kerberos use \n" +
+                    "metastore.sasl.enabled \n" +
+                    "  NONE: no authentication check\n" +
+                    "  JWT:  JSON Web Token authentication via JWT token. Only supported in Http/Https mode"),
+    THRIFT_METASTORE_AUTHENTICATION_JWT_JWKS_URL("metastore.authentication.jwt.jwks.url",

Review Comment:
   Sorry to ask you to piggy back this on your PR, but it would be great to remove this line from this file
   `//TODO (Vihang) check if this configs are needed` for the config METASTORE_CLIENT_AUTH_MODE. I forgot to remove it in my earlier PR related to this feature.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org