You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Sun Dapeng <da...@intel.com> on 2014/09/24 08:09:53 UTC
Review Request 25987: SENTRY-427 High availability for the SENTRY
service
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25987/
-----------------------------------------------------------
Review request for sentry, Arun Suresh, Prasad Mujumdar, and Sravya Tirukkovalur.
Bugs: SENTRY-427
https://issues.apache.org/jira/browse/SENTRY-427
Repository: sentry
Description
-------
This is the main review of SENTRY HA, it contains 7 subtask
* [SENTRY-456](https://issues.apache.org/jira/browse/SENTRY-456) Service discovery for SENTRY high availability [review link](https://reviews.apache.org/r/25977/)
* [SENTRY-463](https://issues.apache.org/jira/browse/SENTRY-463) Refactor SentryServiceClientFactory: change "create SentryPolicyServiceClient" to static [review link](https://reviews.apache.org/r/25979/)
* [SENTRY-464](https://issues.apache.org/jira/browse/SENTRY-464) Add HASentryPolicyServiceClientImpl for high availability and Sentry service register [review link](https://reviews.apache.org/r/25980/)
* [SENTRY-457](https://issues.apache.org/jira/browse/SENTRY-457) Global Sequence ID support for SENTRY high availability [review link](https://reviews.apache.org/r/25981/)
* [SENTRY-458](https://issues.apache.org/jira/browse/SENTRY-458) Enable optimistic locking for SENTRY high availability [review link](https://reviews.apache.org/r/25982/)
* [SENTRY-459](https://issues.apache.org/jira/browse/SENTRY-459) Security mode (Kerberos) support for SENTRY high availability [review link](https://reviews.apache.org/r/25983/)
* [SENTRY-460](https://issues.apache.org/jira/browse/SENTRY-460) Upgrade SQL scripts for SENTRY high availability [review link](https://reviews.apache.org/r/25984/)
Diffs
-----
pom.xml e172e92
sentry-binding/sentry-binding-hive/src/main/java/org/apache/hadoop/hive/ql/exec/SentryGrantRevokeTask.java 6f33109
sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/SentryConfigTool.java 2b978d5
sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/SentryMetastorePostEventListener.java 38bf8b2
sentry-provider/sentry-provider-db/pom.xml b4167e4
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/SimpleDBProviderBackend.java b66037a
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryPrivilege.java 0667cb5
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo 9abaab8
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/CommitContextFactory.java PRE-CREATION
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/FixedJsonInstanceSerializer.java PRE-CREATION
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/HAContext.java PRE-CREATION
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java 350eb32
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/ServiceManager.java PRE-CREATION
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/ServiceRegister.java PRE-CREATION
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/HASentryPolicyServiceClientImpl.java PRE-CREATION
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyServiceClient.java 0668912
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyServiceClientDefaultImpl.java PRE-CREATION
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java e3cdfc2
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/JaasConfiguration.java PRE-CREATION
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java 40e8a0e
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryServiceClientFactory.java 11545a5
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java 52eaeed
sentry-provider/sentry-provider-db/src/main/resources/003-SENTRY-427.derby.sql PRE-CREATION
sentry-provider/sentry-provider-db/src/main/resources/003-SENTRY-427.mysql.sql PRE-CREATION
sentry-provider/sentry-provider-db/src/main/resources/003-SENTRY-427.oracle.sql PRE-CREATION
sentry-provider/sentry-provider-db/src/main/resources/003-SENTRY-427.postgres.sql PRE-CREATION
sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-1.5.0.sql 4c5ae39
sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-1.5.0.sql 4c5ae39
sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.5.0.sql bc0d0d8
sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-1.5.0.sql 5d8336c
sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-1.5.0.sql 24cac98
sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-1.4.0-to-1.5.0.sql 866b22f
sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-derby-1.4.0-to-1.5.0.sql 027f45b
sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-mysql-1.4.0-to-1.5.0.sql 95247d1
sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-oracle-1.4.0-to-1.5.0.sql 7a09d17
sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-postgres-1.4.0-to-1.5.0.sql cc78728
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestHASentryStore.java PRE-CREATION
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryDistributeCounter.java PRE-CREATION
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryServiceDiscovery.java PRE-CREATION
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java befecf4
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestHASentryServerWithoutKerberos.java PRE-CREATION
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestHASentryServiceWithKerberos.java PRE-CREATION
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceIntegration.java 38cb39b
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/HASentryServiceIntegrationBase.java PRE-CREATION
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/SentryServiceIntegrationBase.java cc12099
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/ha/AbstractTestWithHADbProvider.java PRE-CREATION
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/ha/TestPrivilegeWithHAGrantOption.java PRE-CREATION
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithStaticConfiguration.java f251ebc
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPolicyImport.java a67556b
Diff: https://reviews.apache.org/r/25987/diff/
Testing
-------
Unit Tests passed in local
Thanks,
Sun Dapeng
Re: Review Request 25987: SENTRY-427 High availability for the SENTRY
service
Posted by Sun Dapeng <da...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25987/
-----------------------------------------------------------
(Updated 十月 9, 2014, 1:44 p.m.)
Review request for sentry, Arun Suresh, Lenni Kuff, Prasad Mujumdar, and Sravya Tirukkovalur.
Changes
-------
Sorry for forget to add Lenni.
Bugs: SENTRY-427
https://issues.apache.org/jira/browse/SENTRY-427
Repository: sentry
Description
-------
This is the main review of SENTRY HA, it contains 7 subtask
* [SENTRY-456](https://issues.apache.org/jira/browse/SENTRY-456) Service discovery for SENTRY high availability [review link](https://reviews.apache.org/r/25977/)
* [SENTRY-463](https://issues.apache.org/jira/browse/SENTRY-463) Refactor SentryServiceClientFactory: change "create SentryPolicyServiceClient" to static [review link](https://reviews.apache.org/r/25979/)
* [SENTRY-464](https://issues.apache.org/jira/browse/SENTRY-464) Add HASentryPolicyServiceClientImpl for high availability and Sentry service register [review link](https://reviews.apache.org/r/25980/)
* [SENTRY-457](https://issues.apache.org/jira/browse/SENTRY-457) Global Sequence ID support for SENTRY high availability [review link](https://reviews.apache.org/r/25981/)
* [SENTRY-458](https://issues.apache.org/jira/browse/SENTRY-458) Enable optimistic locking for SENTRY high availability [review link](https://reviews.apache.org/r/25982/)
* [SENTRY-459](https://issues.apache.org/jira/browse/SENTRY-459) Security mode (Kerberos) support for SENTRY high availability [review link](https://reviews.apache.org/r/25983/)
* [SENTRY-460](https://issues.apache.org/jira/browse/SENTRY-460) Upgrade SQL scripts for SENTRY high availability [review link](https://reviews.apache.org/r/25984/)
Diffs
-----
pom.xml e172e92
sentry-binding/sentry-binding-hive/src/main/java/org/apache/hadoop/hive/ql/exec/SentryGrantRevokeTask.java 6f33109
sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/SentryConfigTool.java 2b978d5
sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/SentryMetastorePostEventListener.java 38bf8b2
sentry-provider/sentry-provider-db/pom.xml b4167e4
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/SimpleDBProviderBackend.java b66037a
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryPrivilege.java 0667cb5
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo 9abaab8
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/CommitContextFactory.java PRE-CREATION
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/FixedJsonInstanceSerializer.java PRE-CREATION
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/HAContext.java PRE-CREATION
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java 350eb32
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/ServiceManager.java PRE-CREATION
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/ServiceRegister.java PRE-CREATION
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/HASentryPolicyServiceClientImpl.java PRE-CREATION
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyServiceClient.java 0668912
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyServiceClientDefaultImpl.java PRE-CREATION
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java e3cdfc2
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/JaasConfiguration.java PRE-CREATION
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java 40e8a0e
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryServiceClientFactory.java 11545a5
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java 52eaeed
sentry-provider/sentry-provider-db/src/main/resources/003-SENTRY-427.derby.sql PRE-CREATION
sentry-provider/sentry-provider-db/src/main/resources/003-SENTRY-427.mysql.sql PRE-CREATION
sentry-provider/sentry-provider-db/src/main/resources/003-SENTRY-427.oracle.sql PRE-CREATION
sentry-provider/sentry-provider-db/src/main/resources/003-SENTRY-427.postgres.sql PRE-CREATION
sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-1.5.0.sql 4c5ae39
sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-1.5.0.sql 4c5ae39
sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.5.0.sql bc0d0d8
sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-1.5.0.sql 5d8336c
sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-1.5.0.sql 24cac98
sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-1.4.0-to-1.5.0.sql 866b22f
sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-derby-1.4.0-to-1.5.0.sql 027f45b
sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-mysql-1.4.0-to-1.5.0.sql 95247d1
sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-oracle-1.4.0-to-1.5.0.sql 7a09d17
sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-postgres-1.4.0-to-1.5.0.sql cc78728
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestHASentryStore.java PRE-CREATION
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryDistributeCounter.java PRE-CREATION
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryServiceDiscovery.java PRE-CREATION
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java befecf4
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestHASentryServerWithoutKerberos.java PRE-CREATION
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestHASentryServiceWithKerberos.java PRE-CREATION
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceIntegration.java 38cb39b
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/HASentryServiceIntegrationBase.java PRE-CREATION
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/SentryServiceIntegrationBase.java cc12099
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/ha/AbstractTestWithHADbProvider.java PRE-CREATION
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/ha/TestPrivilegeWithHAGrantOption.java PRE-CREATION
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithStaticConfiguration.java f251ebc
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPolicyImport.java a67556b
Diff: https://reviews.apache.org/r/25987/diff/
Testing
-------
Unit Tests passed in local
Thanks,
Sun Dapeng