[GitHub] [qpid-proton] jiridanek commented on a change in pull request #302: PROTON-2355: Fix build with -DPROACTOR=none

[GitBox <gi...@apache.org>]

jiridanek commented on a change in pull request #302:
URL: https://github.com/apache/qpid-proton/pull/302#discussion_r605404345



##########
File path: c/CMakeLists.txt
##########
@@ -464,7 +464,11 @@ set(qpid-proton-noncore-src
   ${qpid-proton-include-extra}
 )
 
-add_library (qpid-proton SHARED $<TARGET_OBJECTS:qpid-proton-core-objects> $<TARGET_OBJECTS:qpid-proton-platform-io-objects> $<TARGET_OBJECTS:qpid-proton-proactor-objects> ${qpid-proton-noncore-src})
+add_library (qpid-proton SHARED
+  $<TARGET_OBJECTS:qpid-proton-core-objects>
+  $<TARGET_OBJECTS:qpid-proton-platform-io-objects>
+  $<$<BOOL:${HAS_PROACTOR}>:$<TARGET_OBJECTS:qpid-proton-proactor-objects>>

Review comment:
       I considered that, but then I thought that `HAS_PROACTOR` is more directly derived from what options the user specified, whereas `$<TARGET_EXISTS` is a check for whatever the build ended up doing. So I felt that HAS_PROACTOR is safer.
   
   I'll change it to TARGET_EXISTS.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org