You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cayenne.apache.org by "Andrus Adamchik (JIRA)" <ji...@apache.org> on 2016/03/05 09:31:40 UTC
[jira] [Commented] (CAY-2050) Refactoring: ParameterBinding to
contain ExtendedType property
[ https://issues.apache.org/jira/browse/CAY-2050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15181635#comment-15181635 ]
Andrus Adamchik commented on CAY-2050:
--------------------------------------
Just applied PR #84. Thanks for the patch. Looks good!
After some thought I renamed Binding back to ParameterBinding. I guess this is a more specific name. Also noticed and fixed a missed type assignment (08fbf1e08c8034121c648dda3231dba58ac8599c).
I guess the remaining steps for this task are:
1. Align SQLParameterBinding with ParameterBinding, so that we don't have to copy it over.
2. JdbcAdapter.bindParameter is not using ExtendedType from the binding. When I tried changing that, I got a bunch of test failures. So I guess we need to make sure that ParameterBinding's ExtendedType is always initialized, then we can safely use it inside the adapter.
> Refactoring: ParameterBinding to contain ExtendedType property
> --------------------------------------------------------------
>
> Key: CAY-2050
> URL: https://issues.apache.org/jira/browse/CAY-2050
> Project: Cayenne
> Issue Type: Task
> Affects Versions: 4.0.M3
> Reporter: Andrus Adamchik
> Assignee: Andrus Adamchik
> Priority: Minor
>
> ParameterBinding is a relatively new class. We are not taking full advantage of it through the stack. Here is one enhancement: add ExtendedType property to ParameterBinding class. It is a very logical place for it and would allow us to improve CommonsJdbcEventLogger parameter logging.
> This may require refactoring of other related methods, such as DbAdapter.bindParameter(..), which will be significantly simplified. So let's do that as well.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)