You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by "vishesh92 (via GitHub)" <gi...@apache.org> on 2023/05/11 07:27:00 UTC
[GitHub] [cloudstack-go] vishesh92 opened a new pull request, #59: Add support for unmanaged kubernetes
vishesh92 opened a new pull request, #59:
URL: https://github.com/apache/cloudstack-go/pull/59
Update APIs with latest main. Depends on https://github.com/apache/cloudstack/pull/7515
`displaytext` was made not required for a couple of APIs because of which there might be some breaking changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-go] rohityadavcloud commented on pull request #59: Add support for unmanaged kubernetes
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #59:
URL: https://github.com/apache/cloudstack-go/pull/59#issuecomment-1637409061
ping @vishesh92 is this up to date?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-go] vishesh92 commented on pull request #59: Add support for unmanaged kubernetes
Posted by "vishesh92 (via GitHub)" <gi...@apache.org>.
vishesh92 commented on PR #59:
URL: https://github.com/apache/cloudstack-go/pull/59#issuecomment-1637612654
@rohityadavcloud Updated the PR. We can make an alpha release of cloudstack-go. The version would be `v2.16.0-alpha`.
>You can specify pre-release versions by appending a hyphen and dot separated identifiers (for example, v1.0.1-alpha or v2.2.2-beta.2). Normal releases are preferred by the go command over pre-release versions, so users must ask for pre-release versions explicitly (for example, go get example.com/hello@v1.0.1-alpha) if your module has any normal releases.
> Source: https://go.dev/blog/publishing-go-modules
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-go] rohityadavcloud merged pull request #59: Add support for unmanaged kubernetes
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud merged PR #59:
URL: https://github.com/apache/cloudstack-go/pull/59
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-go] weizhouapache commented on a diff in pull request #59: Add support for unmanaged kubernetes
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on code in PR #59:
URL: https://github.com/apache/cloudstack-go/pull/59#discussion_r1205329545
##########
generate/layout.go:
##########
@@ -717,6 +717,8 @@ var layout = apiInfo{
"stopKubernetesCluster",
"updateKubernetesSupportedVersion",
"upgradeKubernetesCluster",
+ "addVmsToKubernetesCluster",
Review Comment:
@vishesh92
with the API name changes in https://github.com/apache/cloudstack/pull/7515 , do we need to update the API names here ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org