You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Quanlong Huang (Code Review)" <ge...@cloudera.org> on 2026/01/02 02:22:00 UTC
[Impala-ASF-CR] IMPALA-14507: Register column-level privilege requests for INSERT
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/23569 )
Change subject: IMPALA-14507: Register column-level privilege requests for INSERT
......................................................................
Patch Set 13: Code-Review+1
(4 comments)
http://gerrit.cloudera.org:8080/#/c/23569/7/fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationChecker.java
File fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationChecker.java:
http://gerrit.cloudera.org:8080/#/c/23569/7/fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationChecker.java@731
PS7, Line 731: // rowFilterResult.isRowFilterEnabled() will return false and thus the requesting
> Yes. A test case added by https://gerrit.cloudera.org/c/17230/ (IMPALA-1055
Ack
http://gerrit.cloudera.org:8080/#/c/23569/13/fe/src/test/java/org/apache/impala/authorization/ranger/RangerAuditLogTest.java
File fe/src/test/java/org/apache/impala/authorization/ranger/RangerAuditLogTest.java:
http://gerrit.cloudera.org:8080/#/c/23569/13/fe/src/test/java/org/apache/impala/authorization/ranger/RangerAuditLogTest.java@256
PS13, Line 256: "insert into functional.alltypes (id, string_col) partition " +
: "(year, month) values (1, \"abc\", 2026, 12)"
nit: this long string can be extracted as a variable.
http://gerrit.cloudera.org:8080/#/c/23569/13/fe/src/test/java/org/apache/impala/authorization/ranger/RangerAuditLogTest.java@458
PS13, Line 458: // Log the table event even when the table does not exist.
I thought analyze will fail and no events will be generated. How about the case when a column does not exist?
http://gerrit.cloudera.org:8080/#/c/23569/7/tests/authorization/test_ranger.py
File tests/authorization/test_ranger.py:
http://gerrit.cloudera.org:8080/#/c/23569/7/tests/authorization/test_ranger.py@1496
PS7, Line 1496:
> The short answer is no.
Thanks for the explanation!
--
To view, visit http://gerrit.cloudera.org:8080/23569
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ef61801d3b394c56702b193c250492a62b111df
Gerrit-Change-Number: 23569
Gerrit-PatchSet: 13
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 02 Jan 2026 02:22:00 +0000
Gerrit-HasComments: Yes