You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@jclouds.apache.org by xingyunyang <no...@github.com> on 2018/12/12 02:25:27 UTC

[jclouds/jclouds] support aliyun oss and chinese region of aws s3 on jclouds 1.9.1 (#1263)

https://issues.apache.org/jira/projects/JCLOUDS/issues/JCLOUDS-1471?filter=reportedbyme

The pre-version's jclouds code, we find it not support aliyun oss and chinese region of aws s3, so we add code for these features on 1.9.1.
You can view, comment on, or merge this pull request online at:

  https://github.com/jclouds/jclouds/pull/1263

-- Commit Summary --

  * support aliyun oss and chinese region of aws s3 on jclouds 1.9.1
  * modify bug
  * modify bug

-- File Changes --

    M apis/s3/src/main/java/org/jclouds/s3/domain/AccessControlList.java (8)
    A apis/s3/src/main/java/org/jclouds/s3/filters/Aws4SignerBase.java (444)
    A apis/s3/src/main/java/org/jclouds/s3/filters/Aws4SignerForAuthorizationHeader.java (229)
    A apis/s3/src/main/java/org/jclouds/s3/filters/Aws4SignerForChunkedUpload.java (279)
    A apis/s3/src/main/java/org/jclouds/s3/filters/Aws4SignerForQueryString.java (156)
    A apis/s3/src/main/java/org/jclouds/s3/filters/AwsHostNameUtils.java (197)
    A apis/s3/src/main/java/org/jclouds/s3/filters/AwsSignatureV4Constants.java (163)
    A apis/s3/src/main/java/org/jclouds/s3/filters/ChunkedUploadException.java (35)
    A apis/s3/src/main/java/org/jclouds/s3/filters/ChunkedUploadPayload.java (229)
    M apis/s3/src/main/java/org/jclouds/s3/filters/RequestAuthorizeSignature.java (130)
    A apis/s3/src/main/java/org/jclouds/s3/filters/RequestAuthorizeSignatureV4.java (120)
    M apis/s3/src/main/java/org/jclouds/s3/functions/BindRegionToXmlPayload.java (21)
    M apis/s3/src/main/java/org/jclouds/s3/xml/AccessControlListHandler.java (6)
    M apis/s3/src/main/java/org/jclouds/s3/xml/ListBucketHandler.java (3)
    M apis/sts/src/main/java/org/jclouds/aws/domain/Region.java (44)
    M core/src/main/java/org/jclouds/rest/internal/RestAnnotationProcessor.java (49)
    A core/src/main/java/org/jclouds/util/RegionHandler.java (44)
    M providers/aws-ec2/src/main/java/org/jclouds/aws/ec2/AWSEC2ProviderMetadata.java (2)
    M providers/aws-s3/src/main/java/org/jclouds/aws/s3/AWSS3ProviderMetadata.java (51)

-- Patch Links --

https://github.com/jclouds/jclouds/pull/1263.patch
https://github.com/jclouds/jclouds/pull/1263.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1263

Re: [jclouds/jclouds] support aliyun oss and chinese region of aws s3 on jclouds 1.9.1 (#1263)

Posted by Andrew Gaul <no...@github.com>.

gaul requested changes on this pull request.

See above comment.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1263#pullrequestreview-201239540

Re: [jclouds/jclouds] support aliyun oss and chinese region of aws s3 on jclouds 1.9.1 (#1263)

Posted by Ignasi Barrera <no...@github.com>.

It is _very_ unlikely that we release another 1.9 version, so I'd suggest you open the pull request to the master branch, then we can cherry-pick it to 2.1.x.

This said, there are things that are fundaamentally wrong in this pull request such as hardcoding endpoint logic in jclouds-core (RestAnnotationProcessor for example) that need to be changed and redesigned in order for the PR to be mergeable.

I'll be happy to give advice and guidance if you drop an email to the jclouds dev@ list describing the use case and the fix that needs to be done. Then we'll be able to point you to the proper way of getting it done.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1263#issuecomment-447706776

Re: [jclouds/jclouds] support aliyun oss and chinese region of aws s3 on jclouds 1.9.1 (#1263)

Posted by Andrew Gaul <no...@github.com>.

Closed #1263.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1263#event-3586274118

Re: [jclouds/jclouds] support aliyun oss and chinese region of aws s3 on jclouds 1.9.1 (#1263)

Posted by Andrew Gaul <no...@github.com>.

Please reopen against apache/jclouds if this is still relevant.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1263#issuecomment-663855843

Re: [jclouds/jclouds] support aliyun oss and chinese region of aws s3 on jclouds 1.9.1 (#1263)

Posted by Andrew Gaul <no...@github.com>.

@xingyunyang This code has incorrect structure.  The s3 API is vendor-neutral which supports many providers by overriding the endpoint.  Please study the aws-s3 provider which extends the s3 API in the manner which you should structure your Aliyun pull request.  Also please study the unit tests for signing request which we will require for your new functionality.  Finally we require that all code merges first with master and we can evaluate backports to other branches.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1263#issuecomment-451692571

Re: [jclouds/jclouds] support aliyun oss and chinese region of aws s3 on jclouds 1.9.1 (#1263)

Posted by xingyunyang <no...@github.com>.

Hello, lgnasi:

 

     It is happy to receive your email.Accoding your describe, I check my code, but I don’t know how to fix.

 

     The purpose of our code is to achieve two things:

1.       Add aliyun object storage function(public cloud and private cloud). Aliyun is a subsidiary of Chinese company Alibaba, it provides cloud service. A lot of Chinese people use it. The SDK of aliyun object storage is compatible with AWS S3, except for the signature authentication. Therefore, our developers are imitating jclouds' support for aws s3 and adding relevant code of aliyun object storage cloud. 

2.       Add aws s3 AWS S3 China(cn-north-1) support.

 

On our storage device, we've tested and passed this code. However, because our developers do not understand the structure of jclouds code, the code we write does not meet your requirements. And we also didn't find a way to do unit testing, so we didn't write unit test code.

 

Do you have any Suggestions for this situation?

 

发件人: Ignasi Barrera [mailto:notifications@github.com] 
发送时间: 2018年12月17日 10:50
收件人: jclouds/jclouds <jc...@noreply.github.com>
抄送: Bruce Xing(邢云阳) <xi...@inspur.com>; Author <au...@noreply.github.com>
主题: Re: [jclouds/jclouds] support aliyun oss and chinese region of aws s3 on jclouds 1.9.1 (#1263)

 

It is very unlikely that we release another 1.9 version, so I'd suggest you open the pull request to the master branch, then we can cherry-pick it to 2.1.x.

This said, there are things that are fundaamentally wrong in this pull request such as hardcoding endpoint logic in jclouds-core (RestAnnotationProcessor for example) that need to be changed and redesigned in order for the PR to be mergeable.

I'll be happy to give advice and guidance if you drop an email to the jclouds dev@ list describing the use case and the fix that needs to be done. Then we'll be able to point you to the proper way of getting it done.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <https://github.com/jclouds/jclouds/pull/1263#issuecomment-447706776> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AriYf8MWQLEjuqIbg8-hNSnWj-rNeNu1ks5u5wZBgaJpZM4ZOnCa> .  <https://github.com/notifications/beacon/AriYfwOOyPGI_OrBRf1vB4-6ZAUqDeTRks5u5wZBgaJpZM4ZOnCa.gif> 



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1263#issuecomment-447735054