You are viewing a plain text version of this content. The canonical link for it is here.
Posted to test-dev@httpd.apache.org by Gary Benson <gb...@redhat.com> on 2001/08/10 14:59:50 UTC

Fix for php func5 test

For some reason, not all builds of PHP send output from shutdown functions
to the error log. This patch makes damn sure that the message goes there.

Gary

[ Gary Benson, Red Hat Europe ][ gbenson@redhat.com ][ GnuPG 60E8793A ]


Index: t/htdocs/php/func5.php
===================================================================
RCS file: /home/cvspublic/httpd-test/perl-framework/t/htdocs/php/func5.php,v
retrieving revision 1.1.1.1
diff -u -r1.1.1.1 func5.php
--- t/htdocs/php/func5.php	2001/07/30 19:37:14	1.1.1.1
+++ t/htdocs/php/func5.php	2001/08/10 12:55:15
@@ -2,7 +2,7 @@

 function foo()
 {
-        print "foo() has been called.\n";
+        error_log("foo() has been called.", 0);
 }

 register_shutdown_function("foo");
Index: t/php/func5.t
===================================================================
RCS file: /home/cvspublic/httpd-test/perl-framework/t/php/func5.t,v
retrieving revision 1.3
diff -u -r1.3 func5.t
--- t/php/func5.t	2001/08/09 17:24:43	1.3
+++ t/php/func5.t	2001/08/10 12:55:15
@@ -18,9 +18,6 @@

 ## open error_log and verify the last line is:
 ## foo() has been called.
-##
-## this is kind of lame and may not work...i dont know how php is
-## SUPPPOSED to work in this situation...

 my $error_log = "$env->{vars}->{t_logs}/error_log";
 open(ERROR_LOG, $error_log);


Re: Fix for php func5 test

Posted by Gary Benson <gb...@redhat.com>.
You're welcome...

On Fri, 10 Aug 2001, john sachs wrote:

> oh, cool thanks!
>
> On Fri, Aug 10, 2001 at 01:59:50PM +0100, Gary Benson wrote:
> +
> + For some reason, not all builds of PHP send output from shutdown functions
> + to the error log. This patch makes damn sure that the message goes there.
> +
> + Gary
>

[ Gary Benson, Red Hat Europe ][ gbenson@redhat.com ][ GnuPG 60E8793A ]


Re: Fix for php func5 test

Posted by john sachs <js...@covalent.net>.
oh, cool thanks!

On Fri, Aug 10, 2001 at 01:59:50PM +0100, Gary Benson wrote:
+ 
+ For some reason, not all builds of PHP send output from shutdown functions
+ to the error log. This patch makes damn sure that the message goes there.
+ 
+ Gary