You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "lewiszlw (via GitHub)" <gi...@apache.org> on 2024/08/30 02:46:09 UTC
[I] making `LexRequirement` an actual struct [datafusion]
lewiszlw opened a new issue, #12255:
URL: https://github.com/apache/datafusion/issues/12255
I have always thought that making `LexRequirement` an actual struct with methods and documentation would be even better
For example, something like
```rust
/// Describes a lexical (multi-column) sort requirement
struct LexRequirement {
inner: Vec<PhysicalSortRequirement>>
}
impl LexRequirement {
// documented methods here
...
}
```
Otherwise the rust docs just show as `Vec<PhysicalSortRequirement>` and it is unclear what operations are used
_Originally posted by @alamb in https://github.com/apache/datafusion/pull/12130#pullrequestreview-2257616876_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] making `LexRequirement` an actual struct [datafusion]
Posted by "berkaysynnada (via GitHub)" <gi...@apache.org>.
berkaysynnada commented on issue #12255:
URL: https://github.com/apache/datafusion/issues/12255#issuecomment-2324501070
Makes sense to me. It would help clarify whether the expr vector corresponds to a lex ordering or multiple global orderings. If someone is interested in working on this, I would be happy to help if needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] making `LexRequirement` an actual struct [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on issue #12255:
URL: https://github.com/apache/datafusion/issues/12255#issuecomment-2324468113
FYI @ozankabak and @mustafasrepo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] making `LexRequirement` an actual struct [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb closed issue #12255: making `LexRequirement` an actual struct
URL: https://github.com/apache/datafusion/issues/12255
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] making `LexRequirement` an actual struct [datafusion]
Posted by "ngli-me (via GitHub)" <gi...@apache.org>.
ngli-me commented on issue #12255:
URL: https://github.com/apache/datafusion/issues/12255#issuecomment-2367002756
Hi! Mind if I try taking this one up? My look-over of this is that most of the code can stay the same, we would just need Deref, and a few util functions for accessing the inner Vec on the struct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org