You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/03/03 12:18:11 UTC

[GitHub] [flink] godfreyhe opened a new pull request #11297: [FLINK-16364] [table] Deprecate the methods in TableEnvironment proposed by FLIP-84

godfreyhe opened a new pull request #11297: [FLINK-16364] [table] Deprecate the methods in TableEnvironment proposed by FLIP-84
URL: https://github.com/apache/flink/pull/11297
 
 
   
   
   ## What is the purpose of the change
   
   *[Flip-64](https://cwiki.apache.org/confluence/display/FLINK/FLIP-64%3A+Support+for+Temporary+Objects+in+Table+module) has provided `ConnectTableDescriptor#createTemporaryTable` to register TableSource in TableEnvironment. `fromTableSource(TableSource<?>)` should be deprecated.
   
   The execution semantics of `void sqlUpdate(String)` method is inconsistent. DDL will be executed immediately while `INSERT INTO` statement will be buffered. 
   `void sqlUpdate(String)` and `insertInto(String, Table)` will buffer SQLs and Tables, but the buffer behavior is unclear.  there is no a clear mechanism through TableEnvironment API to control the whole flow. `execute(String)` method and `explain(boolean)` method are buffer-related method. 
   They should be deprecated, new methods will be introduced by [FLINK-16366](https://issues.apache.org/jira/browse/FLINK-16366) and [FLINK-16367](https://issues.apache.org/jira/browse/FLINK-16367)*
   
   
   ## Brief change log
   
     - *Deprecate fromTableSource(TableSource<?>), void sqlUpdate(String), insertInto(String, Table), execute(String), explain(boolean)*
   
   
   ## Verifying this change
   
   *(Please pick either of the following options)*
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs / **not documented**)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] godfreyhe commented on issue #11297: [FLINK-16364] [table] Deprecate the methods in TableEnvironment proposed by FLIP-84

Posted by GitBox <gi...@apache.org>.
godfreyhe commented on issue #11297: [FLINK-16364] [table] Deprecate the methods in TableEnvironment proposed by FLIP-84
URL: https://github.com/apache/flink/pull/11297#issuecomment-594381659
 
 
   Thanks for the suggestion. This pr only deprecates the old methods, suggested new methods will be introduced in [FLINK-16366](https://issues.apache.org/jira/browse/FLINK-16366) and [FLINK-16367](https://issues.apache.org/jira/browse/FLINK-16367). I will start those two issues then. I think this pr is ready after those two issues are merged and I update the comments.  

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #11297: [FLINK-16364] [table] Deprecate the methods in TableEnvironment proposed by FLIP-84

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11297: [FLINK-16364] [table] Deprecate the methods in TableEnvironment proposed by FLIP-84
URL: https://github.com/apache/flink/pull/11297#issuecomment-593931358
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "71c3126025a02e575cc7475c643585c290410712",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "71c3126025a02e575cc7475c643585c290410712",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 71c3126025a02e575cc7475c643585c290410712 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #11297: [FLINK-16364] [table] Deprecate the methods in TableEnvironment proposed by FLIP-84

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11297: [FLINK-16364] [table] Deprecate the methods in TableEnvironment proposed by FLIP-84
URL: https://github.com/apache/flink/pull/11297#issuecomment-593923039
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 71c3126025a02e575cc7475c643585c290410712 (Tue Mar 03 12:20:41 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11297: [FLINK-16364] [table] Deprecate the methods in TableEnvironment proposed by FLIP-84

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11297: [FLINK-16364] [table] Deprecate the methods in TableEnvironment proposed by FLIP-84
URL: https://github.com/apache/flink/pull/11297#issuecomment-593931358
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "71c3126025a02e575cc7475c643585c290410712",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5871",
       "triggerID" : "71c3126025a02e575cc7475c643585c290410712",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71c3126025a02e575cc7475c643585c290410712",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/flink-ci/flink/builds/151537705",
       "triggerID" : "71c3126025a02e575cc7475c643585c290410712",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 71c3126025a02e575cc7475c643585c290410712 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/151537705) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5871) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11297: [FLINK-16364] [table] Deprecate the methods in TableEnvironment proposed by FLIP-84

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11297: [FLINK-16364] [table] Deprecate the methods in TableEnvironment proposed by FLIP-84
URL: https://github.com/apache/flink/pull/11297#issuecomment-593931358
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "71c3126025a02e575cc7475c643585c290410712",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5871",
       "triggerID" : "71c3126025a02e575cc7475c643585c290410712",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71c3126025a02e575cc7475c643585c290410712",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/flink-ci/flink/builds/151537705",
       "triggerID" : "71c3126025a02e575cc7475c643585c290410712",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 71c3126025a02e575cc7475c643585c290410712 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/151537705) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5871) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11297: [FLINK-16364] [table] Deprecate the methods in TableEnvironment proposed by FLIP-84

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11297: [FLINK-16364] [table] Deprecate the methods in TableEnvironment proposed by FLIP-84
URL: https://github.com/apache/flink/pull/11297#issuecomment-593931358
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "71c3126025a02e575cc7475c643585c290410712",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5871",
       "triggerID" : "71c3126025a02e575cc7475c643585c290410712",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71c3126025a02e575cc7475c643585c290410712",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/flink-ci/flink/builds/151537705",
       "triggerID" : "71c3126025a02e575cc7475c643585c290410712",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 71c3126025a02e575cc7475c643585c290410712 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/151537705) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5871) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services