You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Malcolm Taylor <ma...@semmle.com> on 2017/07/11 07:13:43 UTC
Re: Review Request 60728: HIVE-16989: fix some alerts found by
lgtm.com
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60728/
-----------------------------------------------------------
(Updated July 11, 2017, 7:13 a.m.)
Review request for hive.
Summary (updated)
-----------------
HIVE-16989: fix some alerts found by lgtm.com
Repository: hive-git
Description
-------
HIVE-16989
fix some alerts found by lgtm.com
fix TextKeyWrapper.equals and add tests
add .reviewboardrc
Diffs
-----
.reviewboardrc 49231678a72bc37efe052bf2d41006f3b595f7ab
beeline/src/java/org/apache/hive/beeline/BeeLine.java 33a65d49656c77cf0736df0c53bd32c13fea6173
llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/StaticPermanentFunctionChecker.java 15968fa95e40a17d575c546c4880440b7bd93fd0
metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreSchemaInfo.java d6d83e03ac583a5f0e6e9144595e3999786d1648
metastore/src/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java 970038dd6126732840f1a8619fcf7efaa742b956
ql/src/java/org/apache/hadoop/hive/ql/exec/KeyWrapperFactory.java 5154a5fbe99c37bd2279f991a5e286a9c04918a4
ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/FlatRowContainer.java 9b1af1bd38e694c7f670aee0508cfb832fd109b7
ql/src/java/org/apache/hadoop/hive/ql/io/parquet/convert/Repeated.java a7fad7177e39ef9112f08da0e7e6cc714ef96b8a
ql/src/java/org/apache/hadoop/hive/ql/parse/repl/load/DumpMetaData.java 2d5e3b168b7cb2c3cf323533790af4bd87a333b8
ql/src/java/org/apache/hadoop/hive/ql/plan/TezEdgeProperty.java 5d7ddc880a566e63237e4b76fd1d6e614d502974
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFMkCollectionEvaluator.java 2b5e6dd31d2b1c58d55a6e2bb1eb615748bc83e0
ql/src/test/org/apache/hadoop/hive/ql/exec/TestKeyWrapperFactory.java PRE-CREATION
Diff: https://reviews.apache.org/r/60728/diff/1/
Testing
-------
Ran tests. Some tests failed, but also appear to fail on master.
Added tests for equals() methods in KeyWrapper classes, which fail on master but pass with this patch.
Thanks,
Malcolm Taylor
Re: Review Request 60728: HIVE-16989: fix some alerts found by
lgtm.com
Posted by Malcolm Taylor <ma...@semmle.com>.
> On July 11, 2017, 7:27 a.m., Gopal V wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/plan/TezEdgeProperty.java
> > Line 63 (original)
> > <https://reviews.apache.org/r/60728/diff/1/?file=1771986#file1771986line63>
> >
> > That's probably a bug?
Thanks for the suggestion Gopal V. Looking at the file history, I think you're right. That line was originally within the constructor, and it looks like it should have stayed there. So I've made a new patch which reinstates that line, but places it within the constructor.
- Malcolm
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60728/#review180168
-----------------------------------------------------------
On July 11, 2017, 7:13 a.m., Malcolm Taylor wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60728/
> -----------------------------------------------------------
>
> (Updated July 11, 2017, 7:13 a.m.)
>
>
> Review request for hive.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-16989
> fix some alerts found by lgtm.com
>
> fix TextKeyWrapper.equals and add tests
>
>
> add .reviewboardrc
>
>
> Diffs
> -----
>
> .reviewboardrc 49231678a72bc37efe052bf2d41006f3b595f7ab
> beeline/src/java/org/apache/hive/beeline/BeeLine.java 33a65d49656c77cf0736df0c53bd32c13fea6173
> llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/StaticPermanentFunctionChecker.java 15968fa95e40a17d575c546c4880440b7bd93fd0
> metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreSchemaInfo.java d6d83e03ac583a5f0e6e9144595e3999786d1648
> metastore/src/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java 970038dd6126732840f1a8619fcf7efaa742b956
> ql/src/java/org/apache/hadoop/hive/ql/exec/KeyWrapperFactory.java 5154a5fbe99c37bd2279f991a5e286a9c04918a4
> ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/FlatRowContainer.java 9b1af1bd38e694c7f670aee0508cfb832fd109b7
> ql/src/java/org/apache/hadoop/hive/ql/io/parquet/convert/Repeated.java a7fad7177e39ef9112f08da0e7e6cc714ef96b8a
> ql/src/java/org/apache/hadoop/hive/ql/parse/repl/load/DumpMetaData.java 2d5e3b168b7cb2c3cf323533790af4bd87a333b8
> ql/src/java/org/apache/hadoop/hive/ql/plan/TezEdgeProperty.java 5d7ddc880a566e63237e4b76fd1d6e614d502974
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFMkCollectionEvaluator.java 2b5e6dd31d2b1c58d55a6e2bb1eb615748bc83e0
> ql/src/test/org/apache/hadoop/hive/ql/exec/TestKeyWrapperFactory.java PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/60728/diff/1/
>
>
> Testing
> -------
>
> Ran tests. Some tests failed, but also appear to fail on master.
> Added tests for equals() methods in KeyWrapper classes, which fail on master but pass with this patch.
>
>
> Thanks,
>
> Malcolm Taylor
>
>
Re: Review Request 60728: HIVE-16989: fix some alerts found by
lgtm.com
Posted by Gopal V <go...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60728/#review180168
-----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/plan/TezEdgeProperty.java
Line 63 (original)
<https://reviews.apache.org/r/60728/#comment255206>
That's probably a bug?
- Gopal V
On July 11, 2017, 7:13 a.m., Malcolm Taylor wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60728/
> -----------------------------------------------------------
>
> (Updated July 11, 2017, 7:13 a.m.)
>
>
> Review request for hive.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-16989
> fix some alerts found by lgtm.com
>
> fix TextKeyWrapper.equals and add tests
>
>
> add .reviewboardrc
>
>
> Diffs
> -----
>
> .reviewboardrc 49231678a72bc37efe052bf2d41006f3b595f7ab
> beeline/src/java/org/apache/hive/beeline/BeeLine.java 33a65d49656c77cf0736df0c53bd32c13fea6173
> llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/StaticPermanentFunctionChecker.java 15968fa95e40a17d575c546c4880440b7bd93fd0
> metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreSchemaInfo.java d6d83e03ac583a5f0e6e9144595e3999786d1648
> metastore/src/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java 970038dd6126732840f1a8619fcf7efaa742b956
> ql/src/java/org/apache/hadoop/hive/ql/exec/KeyWrapperFactory.java 5154a5fbe99c37bd2279f991a5e286a9c04918a4
> ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/FlatRowContainer.java 9b1af1bd38e694c7f670aee0508cfb832fd109b7
> ql/src/java/org/apache/hadoop/hive/ql/io/parquet/convert/Repeated.java a7fad7177e39ef9112f08da0e7e6cc714ef96b8a
> ql/src/java/org/apache/hadoop/hive/ql/parse/repl/load/DumpMetaData.java 2d5e3b168b7cb2c3cf323533790af4bd87a333b8
> ql/src/java/org/apache/hadoop/hive/ql/plan/TezEdgeProperty.java 5d7ddc880a566e63237e4b76fd1d6e614d502974
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFMkCollectionEvaluator.java 2b5e6dd31d2b1c58d55a6e2bb1eb615748bc83e0
> ql/src/test/org/apache/hadoop/hive/ql/exec/TestKeyWrapperFactory.java PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/60728/diff/1/
>
>
> Testing
> -------
>
> Ran tests. Some tests failed, but also appear to fail on master.
> Added tests for equals() methods in KeyWrapper classes, which fail on master but pass with this patch.
>
>
> Thanks,
>
> Malcolm Taylor
>
>
Re: Review Request 60728: HIVE-16989: fix some alerts found by
lgtm.com
Posted by Malcolm Taylor <ma...@semmle.com>.
> On July 11, 2017, 6:04 p.m., Prasanth_J wrote:
> > .reviewboardrc
> > Line 1 (original), 1 (patched)
> > <https://reviews.apache.org/r/60728/diff/2/?file=1774039#file1774039line1>
> >
> > Is this triggerring an alert? Better to leave the license as such else Apache Rat will cause failures (if not added to ignore list).
Thanks Prasanth_J. I have rebased, and dropped the change to .reviewboardrc in the latest patch. The file didn't trigger any alerts and it was my mistake to include that change in the earlier patch.
- Malcolm
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60728/#review180227
-----------------------------------------------------------
On July 12, 2017, 7:27 a.m., Malcolm Taylor wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60728/
> -----------------------------------------------------------
>
> (Updated July 12, 2017, 7:27 a.m.)
>
>
> Review request for hive.
>
>
> Bugs: HIVE-16989
> https://issues.apache.org/jira/browse/HIVE-16989
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-16989
> fix some alerts found by lgtm.com
>
> fix TextKeyWrapper.equals and add tests
>
>
> add .reviewboardrc
>
>
> Diffs
> -----
>
> .reviewboardrc 4923167
> beeline/src/java/org/apache/hive/beeline/BeeLine.java 33a65d4
> llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/StaticPermanentFunctionChecker.java 15968fa
> metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreSchemaInfo.java d6d83e0
> metastore/src/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java 970038d
> ql/src/java/org/apache/hadoop/hive/ql/exec/KeyWrapperFactory.java 5154a5f
> ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/FlatRowContainer.java 9b1af1b
> ql/src/java/org/apache/hadoop/hive/ql/io/parquet/convert/Repeated.java a7fad71
> ql/src/java/org/apache/hadoop/hive/ql/parse/repl/load/DumpMetaData.java 2d5e3b1
> ql/src/java/org/apache/hadoop/hive/ql/plan/TezEdgeProperty.java 5d7ddc8
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFMkCollectionEvaluator.java 2b5e6dd
> ql/src/test/org/apache/hadoop/hive/ql/exec/TestKeyWrapperFactory.java PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/60728/diff/2/
>
>
> Testing
> -------
>
> Ran tests. Some tests failed, but also appear to fail on master.
> Added tests for equals() methods in KeyWrapper classes, which fail on master but pass with this patch.
>
>
> File Attachments
> ----------------
>
> HIVE-16989.4.patch
> https://reviews.apache.org/media/uploaded/files/2017/07/12/eebaa7c1-a348-4e8f-a880-4e69e20bdee0__HIVE-16989.4.patch
>
>
> Thanks,
>
> Malcolm Taylor
>
>
Re: Review Request 60728: HIVE-16989: fix some alerts found by
lgtm.com
Posted by j....@gmail.com.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60728/#review180227
-----------------------------------------------------------
.reviewboardrc
Line 1 (original), 1 (patched)
<https://reviews.apache.org/r/60728/#comment255296>
Is this triggerring an alert? Better to leave the license as such else Apache Rat will cause failures (if not added to ignore list).
- Prasanth_J
On July 11, 2017, 10:05 a.m., Malcolm Taylor wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60728/
> -----------------------------------------------------------
>
> (Updated July 11, 2017, 10:05 a.m.)
>
>
> Review request for hive.
>
>
> Bugs: HIVE-16989
> https://issues.apache.org/jira/browse/HIVE-16989
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-16989
> fix some alerts found by lgtm.com
>
> fix TextKeyWrapper.equals and add tests
>
>
> add .reviewboardrc
>
>
> Diffs
> -----
>
> .reviewboardrc 4923167
> beeline/src/java/org/apache/hive/beeline/BeeLine.java 33a65d4
> llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/StaticPermanentFunctionChecker.java 15968fa
> metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreSchemaInfo.java d6d83e0
> metastore/src/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java 970038d
> ql/src/java/org/apache/hadoop/hive/ql/exec/KeyWrapperFactory.java 5154a5f
> ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/FlatRowContainer.java 9b1af1b
> ql/src/java/org/apache/hadoop/hive/ql/io/parquet/convert/Repeated.java a7fad71
> ql/src/java/org/apache/hadoop/hive/ql/parse/repl/load/DumpMetaData.java 2d5e3b1
> ql/src/java/org/apache/hadoop/hive/ql/plan/TezEdgeProperty.java 5d7ddc8
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFMkCollectionEvaluator.java 2b5e6dd
> ql/src/test/org/apache/hadoop/hive/ql/exec/TestKeyWrapperFactory.java PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/60728/diff/2/
>
>
> Testing
> -------
>
> Ran tests. Some tests failed, but also appear to fail on master.
> Added tests for equals() methods in KeyWrapper classes, which fail on master but pass with this patch.
>
>
> Thanks,
>
> Malcolm Taylor
>
>
Re: Review Request 60728: HIVE-16989: fix some alerts found by
lgtm.com
Posted by Malcolm Taylor <ma...@semmle.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60728/
-----------------------------------------------------------
(Updated July 13, 2017, 8 a.m.)
Review request for hive.
Changes
-------
rebased, removed surplus whitespace and added license
Bugs: HIVE-16989
https://issues.apache.org/jira/browse/HIVE-16989
Repository: hive-git
Description (updated)
-------
HIVE-16989
fix some alerts found by lgtm.com
fix TextKeyWrapper.equals and add tests
Diffs (updated)
-----
beeline/src/java/org/apache/hive/beeline/BeeLine.java 33a65d4
llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/StaticPermanentFunctionChecker.java 15968fa
metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreSchemaInfo.java d6d83e0
metastore/src/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java 970038d
ql/src/java/org/apache/hadoop/hive/ql/exec/KeyWrapperFactory.java 5154a5f
ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/FlatRowContainer.java 9b1af1b
ql/src/java/org/apache/hadoop/hive/ql/io/parquet/convert/Repeated.java a7fad71
ql/src/java/org/apache/hadoop/hive/ql/parse/repl/load/DumpMetaData.java 2d5e3b1
ql/src/java/org/apache/hadoop/hive/ql/plan/TezEdgeProperty.java 5d7ddc8
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFMkCollectionEvaluator.java 2b5e6dd
ql/src/test/org/apache/hadoop/hive/ql/exec/TestKeyWrapperFactory.java PRE-CREATION
Diff: https://reviews.apache.org/r/60728/diff/4/
Changes: https://reviews.apache.org/r/60728/diff/3-4/
Testing
-------
Ran tests. Some tests failed, but also appear to fail on master.
Added tests for equals() methods in KeyWrapper classes, which fail on master but pass with this patch.
File Attachments
----------------
HIVE-16989.4.patch
https://reviews.apache.org/media/uploaded/files/2017/07/12/eebaa7c1-a348-4e8f-a880-4e69e20bdee0__HIVE-16989.4.patch
Thanks,
Malcolm Taylor
Re: Review Request 60728: HIVE-16989: fix some alerts found by
lgtm.com
Posted by Malcolm Taylor <ma...@semmle.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60728/
-----------------------------------------------------------
(Updated July 12, 2017, 7:29 a.m.)
Review request for hive.
Bugs: HIVE-16989
https://issues.apache.org/jira/browse/HIVE-16989
Repository: hive-git
Description
-------
HIVE-16989
fix some alerts found by lgtm.com
fix TextKeyWrapper.equals and add tests
add .reviewboardrc
Diffs (updated)
-----
beeline/src/java/org/apache/hive/beeline/BeeLine.java 33a65d4
llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/StaticPermanentFunctionChecker.java 15968fa
metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreSchemaInfo.java d6d83e0
metastore/src/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java 970038d
ql/src/java/org/apache/hadoop/hive/ql/exec/KeyWrapperFactory.java 5154a5f
ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/FlatRowContainer.java 9b1af1b
ql/src/java/org/apache/hadoop/hive/ql/io/parquet/convert/Repeated.java a7fad71
ql/src/java/org/apache/hadoop/hive/ql/parse/repl/load/DumpMetaData.java 2d5e3b1
ql/src/java/org/apache/hadoop/hive/ql/plan/TezEdgeProperty.java 5d7ddc8
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFMkCollectionEvaluator.java 2b5e6dd
ql/src/test/org/apache/hadoop/hive/ql/exec/TestKeyWrapperFactory.java PRE-CREATION
Diff: https://reviews.apache.org/r/60728/diff/3/
Changes: https://reviews.apache.org/r/60728/diff/2-3/
Testing
-------
Ran tests. Some tests failed, but also appear to fail on master.
Added tests for equals() methods in KeyWrapper classes, which fail on master but pass with this patch.
File Attachments
----------------
HIVE-16989.4.patch
https://reviews.apache.org/media/uploaded/files/2017/07/12/eebaa7c1-a348-4e8f-a880-4e69e20bdee0__HIVE-16989.4.patch
Thanks,
Malcolm Taylor
Re: Review Request 60728: HIVE-16989: fix some alerts found by
lgtm.com
Posted by Malcolm Taylor <ma...@semmle.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60728/
-----------------------------------------------------------
(Updated July 12, 2017, 7:27 a.m.)
Review request for hive.
Changes
-------
rebased and dropped change to .reviewboardrc
Bugs: HIVE-16989
https://issues.apache.org/jira/browse/HIVE-16989
Repository: hive-git
Description
-------
HIVE-16989
fix some alerts found by lgtm.com
fix TextKeyWrapper.equals and add tests
add .reviewboardrc
Diffs
-----
.reviewboardrc 4923167
beeline/src/java/org/apache/hive/beeline/BeeLine.java 33a65d4
llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/StaticPermanentFunctionChecker.java 15968fa
metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreSchemaInfo.java d6d83e0
metastore/src/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java 970038d
ql/src/java/org/apache/hadoop/hive/ql/exec/KeyWrapperFactory.java 5154a5f
ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/FlatRowContainer.java 9b1af1b
ql/src/java/org/apache/hadoop/hive/ql/io/parquet/convert/Repeated.java a7fad71
ql/src/java/org/apache/hadoop/hive/ql/parse/repl/load/DumpMetaData.java 2d5e3b1
ql/src/java/org/apache/hadoop/hive/ql/plan/TezEdgeProperty.java 5d7ddc8
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFMkCollectionEvaluator.java 2b5e6dd
ql/src/test/org/apache/hadoop/hive/ql/exec/TestKeyWrapperFactory.java PRE-CREATION
Diff: https://reviews.apache.org/r/60728/diff/2/
Testing
-------
Ran tests. Some tests failed, but also appear to fail on master.
Added tests for equals() methods in KeyWrapper classes, which fail on master but pass with this patch.
File Attachments (updated)
----------------
HIVE-16989.4.patch
https://reviews.apache.org/media/uploaded/files/2017/07/12/eebaa7c1-a348-4e8f-a880-4e69e20bdee0__HIVE-16989.4.patch
Thanks,
Malcolm Taylor
Re: Review Request 60728: HIVE-16989: fix some alerts found by
lgtm.com
Posted by Malcolm Taylor <ma...@semmle.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60728/
-----------------------------------------------------------
(Updated July 11, 2017, 10:05 a.m.)
Review request for hive.
Bugs: HIVE-16989
https://issues.apache.org/jira/browse/HIVE-16989
Repository: hive-git
Description
-------
HIVE-16989
fix some alerts found by lgtm.com
fix TextKeyWrapper.equals and add tests
add .reviewboardrc
Diffs (updated)
-----
.reviewboardrc 4923167
beeline/src/java/org/apache/hive/beeline/BeeLine.java 33a65d4
llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/StaticPermanentFunctionChecker.java 15968fa
metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreSchemaInfo.java d6d83e0
metastore/src/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java 970038d
ql/src/java/org/apache/hadoop/hive/ql/exec/KeyWrapperFactory.java 5154a5f
ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/FlatRowContainer.java 9b1af1b
ql/src/java/org/apache/hadoop/hive/ql/io/parquet/convert/Repeated.java a7fad71
ql/src/java/org/apache/hadoop/hive/ql/parse/repl/load/DumpMetaData.java 2d5e3b1
ql/src/java/org/apache/hadoop/hive/ql/plan/TezEdgeProperty.java 5d7ddc8
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFMkCollectionEvaluator.java 2b5e6dd
ql/src/test/org/apache/hadoop/hive/ql/exec/TestKeyWrapperFactory.java PRE-CREATION
Diff: https://reviews.apache.org/r/60728/diff/2/
Changes: https://reviews.apache.org/r/60728/diff/1-2/
Testing
-------
Ran tests. Some tests failed, but also appear to fail on master.
Added tests for equals() methods in KeyWrapper classes, which fail on master but pass with this patch.
Thanks,
Malcolm Taylor