You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "DerGut (via GitHub)" <gi...@apache.org> on 2026/07/16 20:45:57 UTC
[PR] Session catalog [iceberg-rust]
DerGut opened a new pull request, #2836:
URL: https://github.com/apache/iceberg-rust/pull/2836
## Which issue does this PR close?
- This is a first of ~3 PRs to close https://github.com/apache/iceberg-rust/issues/2774
## What changes are included in this PR?
This PR introduces a new session-aware catalog trait `SessionCatalog` and its implementation `RestSessionCatalog`.
A `SessionCatalog` is a session-aware catalog variant that accepts a new struct `SessionContext` with every catalog method. It is otherwise identical to the regular `Catalog` trait.
The `RestSessionCatalog` now acts as the core implementation of the `RestCatalog`, which simply delegates all its methods to an inner `RestSessionCatalog` by passing an internal `SessionContext` that defaults to an empty one, preserving session unaware behavior.
## Are these changes tested?
<!--
Specify what test covers (unit test, integration test, etc.).
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
The existing test suite passes on the refactor that moves logic from the `RestCatalog` to the `RestSessionCatalog` (first commit). I've included some additional tests to assert the RestCatalogBuilder's output when passed an explicit session.
I'm adding a commit to refactor the test suit, to have it operate on the `RestSessionCatalog` instead, as it now contains the load-bearing logic.
---
Logic that uses the sessions to modify requests isn't implemented yet, so tests at this point are only structural. My 2nd PR will address this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Add SessionCatalog trait [iceberg-rust]
Posted by "plusplusjiajia (via GitHub)" <gi...@apache.org>.
plusplusjiajia commented on code in PR #2836:
URL: https://github.com/apache/iceberg-rust/pull/2836#discussion_r3680909574
##########
crates/iceberg/src/catalog/session.rs:
##########
@@ -0,0 +1,264 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+//! Session catalog API for Apache Iceberg.
+
+use std::collections::HashMap;
+use std::fmt::Debug;
+use std::future::Future;
+use std::sync::Arc;
+
+use async_trait::async_trait;
+use typed_builder::TypedBuilder;
+use uuid::Uuid;
+use zeroize::Zeroizing;
+
+use crate::io::StorageFactory;
+use crate::runtime::Runtime;
+use crate::table::Table;
+use crate::{Namespace, NamespaceIdent, Result, TableCommit, TableCreation, TableIdent};
+
+/// Context for a session.
+#[derive(Debug, Clone, TypedBuilder)]
+pub struct SessionContext {
+ /// The unique identifier for this session.
+ ///
+ /// Note that the session_id may be used for caching session-scoped state
+ /// and re-use of a session_id with different session context may result in
+ /// unexpected behavior.
+ session_id: String,
+
+ /// An optional user or principal associated with the session.
+ #[builder(default, setter(strip_option))]
+ identity: Option<String>,
+
+ #[builder(default)]
+ properties: HashMap<String, String>,
+
+ #[builder(default)]
+ credentials: HashMap<String, Credential>,
+}
+
+impl SessionContext {
+ /// Creates a new unique but empty session.
+ pub fn empty() -> Self {
+ Self {
+ session_id: Uuid::new_v4().to_string(),
+ identity: None,
+ properties: HashMap::new(),
+ credentials: HashMap::new(),
+ }
+ }
+
+ /// Returns the identifier for this session.
+ ///
+ /// The identifier may be used for caching state within a session.
+ pub fn session_id(&self) -> &str {
+ &self.session_id
+ }
+
+ /// Returns a string that identifies the current user or principal.
+ pub fn identity(&self) -> Option<&str> {
+ self.identity.as_deref()
+ }
+
+ /// Returns a map of properties currently set for the session.
+ pub fn properties(&self) -> &HashMap<String, String> {
+ &self.properties
+ }
+
+ /// Returns the session's credential map.
+ pub fn credentials(&self) -> &HashMap<String, Credential> {
+ &self.credentials
+ }
+}
+
+/// A string-like type containing sensitive information such as passwords or tokens.
+///
+/// It is redacted from logs and automatically zeroized.
+#[derive(Clone)]
+pub struct Credential(Zeroizing<String>);
Review Comment:
This is structurally identical to the SensitiveString I added in #2838 (per your suggestion there) — once this lands I'm happy to swap #2838 over to iceberg::Credential so we end up with one type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Add SessionCatalog trait [iceberg-rust]
Posted by "DerGut (via GitHub)" <gi...@apache.org>.
DerGut commented on code in PR #2836:
URL: https://github.com/apache/iceberg-rust/pull/2836#discussion_r3682334341
##########
crates/iceberg/src/catalog/session.rs:
##########
@@ -0,0 +1,264 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+//! Session catalog API for Apache Iceberg.
+
+use std::collections::HashMap;
+use std::fmt::Debug;
+use std::future::Future;
+use std::sync::Arc;
+
+use async_trait::async_trait;
+use typed_builder::TypedBuilder;
+use uuid::Uuid;
+use zeroize::Zeroizing;
+
+use crate::io::StorageFactory;
+use crate::runtime::Runtime;
+use crate::table::Table;
+use crate::{Namespace, NamespaceIdent, Result, TableCommit, TableCreation, TableIdent};
+
+/// Context for a session.
+#[derive(Debug, Clone, TypedBuilder)]
+pub struct SessionContext {
+ /// The unique identifier for this session.
+ ///
+ /// Note that the session_id may be used for caching session-scoped state
+ /// and re-use of a session_id with different session context may result in
+ /// unexpected behavior.
+ session_id: String,
Review Comment:
This is a great idea! Will do 🙇
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Add SessionCatalog trait [iceberg-rust]
Posted by "CTTY (via GitHub)" <gi...@apache.org>.
CTTY commented on code in PR #2836:
URL: https://github.com/apache/iceberg-rust/pull/2836#discussion_r3708145084
##########
crates/iceberg/src/catalog/session.rs:
##########
@@ -0,0 +1,334 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+//! Session catalog API for Apache Iceberg.
+
+use std::collections::HashMap;
+use std::fmt::Debug;
+use std::future::Future;
+use std::sync::Arc;
+
+use async_trait::async_trait;
+#[cfg(test)]
+use mockall::automock;
+use typed_builder::TypedBuilder;
+use uuid::Uuid;
+use zeroize::Zeroizing;
+
+use crate::io::StorageFactory;
+use crate::runtime::Runtime;
+use crate::table::Table;
+use crate::{Namespace, NamespaceIdent, Result, TableCommit, TableCreation, TableIdent};
+
+/// Context for a session.
+///
+/// # Example
+/// ```rust
+/// use iceberg::SessionContext;
+///
+/// let session = SessionContext::builder()
+/// .identity("user123".to_string())
+/// .build();
+///
+/// assert_eq!(session.identity(), Some("user123"));
+/// assert!(!session.session_id().is_empty());
+/// ```
+#[derive(Debug, Clone, TypedBuilder)]
+pub struct SessionContext {
+ /// The unique identifier for this session.
+ ///
+ /// Note that the session_id may be used for caching session-scoped state
+ /// and re-use of a session_id with different session context may result in
+ /// unexpected behavior.
+ #[builder(default=Uuid::new_v4().to_string())]
+ session_id: String,
+
+ /// An optional user or principal associated with the session.
+ #[builder(default, setter(strip_option))]
+ identity: Option<String>,
+
+ #[builder(default)]
+ properties: HashMap<String, String>,
+
+ #[builder(default)]
+ credentials: HashMap<String, Credential>,
+}
+
+impl SessionContext {
+ /// Creates a new unique but empty session.
+ pub fn empty() -> Self {
+ Self::builder().build()
+ }
+
+ /// Returns the identifier for this session.
+ ///
+ /// The identifier may be used for caching state within a session.
+ pub fn session_id(&self) -> &str {
+ &self.session_id
+ }
+
+ /// Returns a string that identifies the current user or principal.
+ pub fn identity(&self) -> Option<&str> {
+ self.identity.as_deref()
+ }
+
+ /// Returns a map of properties currently set for the session.
+ pub fn properties(&self) -> &HashMap<String, String> {
+ &self.properties
+ }
+
+ /// Returns the session's credential map.
+ pub fn credentials(&self) -> &HashMap<String, Credential> {
+ &self.credentials
+ }
+}
+
+/// A string-like type containing sensitive information such as passwords or tokens.
+///
+/// It is redacted from logs and automatically zeroized.
+///
+/// # Example
+/// ```rust
+/// use iceberg::Credential;
+///
+/// let sensitive_value = "my-pw-12345";
+/// let credential = Credential::from(sensitive_value.to_string());
+///
+/// // Not contained in debug logs.
+/// assert!(!format!("{:?}", credential).contains(sensitive_value));
+/// ```
+#[derive(Clone)]
+pub struct Credential(Zeroizing<String>);
+
+impl Credential {
+ /// Returns the raw value of the credential.
+ pub fn expose(&self) -> &str {
+ &self.0
+ }
+}
+
+impl Debug for Credential {
+ fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
+ f.write_str("Credential([REDACTED])")
+ }
+}
+
+impl From<String> for Credential {
+ fn from(value: String) -> Self {
+ Self(Zeroizing::new(value))
+ }
+}
+
+/// The catalog API for Iceberg Rust that includes session handling.
+#[async_trait]
+#[cfg_attr(test, automock)]
+pub trait SessionCatalog: Debug + Send + Sync {
+ /// List namespaces inside the catalog.
+ async fn list_namespaces(
+ &self,
+ context: &SessionContext,
+ parent: Option<&NamespaceIdent>,
+ ) -> Result<Vec<NamespaceIdent>>;
+
+ /// Create a new namespace inside the catalog.
+ async fn create_namespace(
+ &self,
+ context: &SessionContext,
+ namespace: &NamespaceIdent,
+ properties: HashMap<String, String>,
+ ) -> Result<Namespace>;
+
+ /// Get a namespace information from the catalog.
+ async fn get_namespace(
+ &self,
+ context: &SessionContext,
+ namespace: &NamespaceIdent,
+ ) -> Result<Namespace>;
+
+ /// Check if namespace exists in catalog.
+ async fn namespace_exists(
+ &self,
+ context: &SessionContext,
+ namespace: &NamespaceIdent,
+ ) -> Result<bool>;
+
+ /// Update a namespace inside the catalog.
+ ///
+ /// # Behavior
+ ///
+ /// The properties must be the full set of namespace.
+ async fn update_namespace(
+ &self,
+ context: &SessionContext,
+ namespace: &NamespaceIdent,
+ properties: HashMap<String, String>,
+ ) -> Result<()>;
+
+ /// Drop a namespace from the catalog, or returns error if it doesn't exist.
+ async fn drop_namespace(
+ &self,
+ context: &SessionContext,
+ namespace: &NamespaceIdent,
+ ) -> Result<()>;
+
+ /// List tables from namespace.
+ async fn list_tables(
+ &self,
+ context: &SessionContext,
+ namespace: &NamespaceIdent,
+ ) -> Result<Vec<TableIdent>>;
+
+ /// Create a new table inside the namespace.
+ async fn create_table(
+ &self,
+ context: &SessionContext,
+ namespace: &NamespaceIdent,
+ creation: TableCreation,
+ ) -> Result<Table>;
+
+ /// Load table from the catalog.
+ async fn load_table(&self, context: &SessionContext, table: &TableIdent) -> Result<Table>;
+
+ /// Drop a table from the catalog, or returns error if it doesn't exist.
+ async fn drop_table(&self, context: &SessionContext, table: &TableIdent) -> Result<()>;
+
+ /// Drop a table from the catalog and delete the underlying table data.
+ ///
+ /// Implementations should load the table metadata, drop the table
+ /// from the catalog, then delete all associated data and metadata files.
+ /// The [`drop_table_data`](super::utils::drop_table_data) utility function can
+ /// be used for the file cleanup step.
+ async fn purge_table(&self, context: &SessionContext, table: &TableIdent) -> Result<()>;
+
+ /// Check if a table exists in the catalog.
+ async fn table_exists(&self, context: &SessionContext, table: &TableIdent) -> Result<bool>;
+
+ /// Rename a table in the catalog.
+ async fn rename_table(
+ &self,
+ context: &SessionContext,
+ src: &TableIdent,
+ dest: &TableIdent,
+ ) -> Result<()>;
+
+ /// Register an existing table to the catalog.
+ async fn register_table(
+ &self,
+ context: &SessionContext,
+ table: &TableIdent,
+ metadata_location: String,
+ ) -> Result<Table>;
+
+ /// Update a table to the catalog.
+ async fn update_table(&self, context: &SessionContext, commit: TableCommit) -> Result<Table>;
+}
+
+/// Common interface for all session catalog builders.
+pub trait SessionCatalogBuilder: Default + Debug + Send + Sync {
Review Comment:
Is the trait actually needed?
We currently have `trait CatalogBuilder` because we want users to be able to load catalogs using a type string. But for session catalog I don't see such use case for now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Add SessionCatalog trait [iceberg-rust]
Posted by "DerGut (via GitHub)" <gi...@apache.org>.
DerGut commented on code in PR #2836:
URL: https://github.com/apache/iceberg-rust/pull/2836#discussion_r3684663264
##########
crates/iceberg/src/catalog/session.rs:
##########
@@ -0,0 +1,264 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+//! Session catalog API for Apache Iceberg.
+
+use std::collections::HashMap;
+use std::fmt::Debug;
+use std::future::Future;
+use std::sync::Arc;
+
+use async_trait::async_trait;
+use typed_builder::TypedBuilder;
+use uuid::Uuid;
+use zeroize::Zeroizing;
+
+use crate::io::StorageFactory;
+use crate::runtime::Runtime;
+use crate::table::Table;
+use crate::{Namespace, NamespaceIdent, Result, TableCommit, TableCreation, TableIdent};
+
+/// Context for a session.
+#[derive(Debug, Clone, TypedBuilder)]
+pub struct SessionContext {
+ /// The unique identifier for this session.
+ ///
+ /// Note that the session_id may be used for caching session-scoped state
+ /// and re-use of a session_id with different session context may result in
+ /// unexpected behavior.
+ session_id: String,
+
+ /// An optional user or principal associated with the session.
+ #[builder(default, setter(strip_option))]
+ identity: Option<String>,
+
+ #[builder(default)]
+ properties: HashMap<String, String>,
+
+ #[builder(default)]
+ credentials: HashMap<String, Credential>,
+}
+
+impl SessionContext {
+ /// Creates a new unique but empty session.
+ pub fn empty() -> Self {
+ Self {
+ session_id: Uuid::new_v4().to_string(),
+ identity: None,
+ properties: HashMap::new(),
+ credentials: HashMap::new(),
+ }
+ }
+
+ /// Returns the identifier for this session.
+ ///
+ /// The identifier may be used for caching state within a session.
+ pub fn session_id(&self) -> &str {
+ &self.session_id
+ }
+
+ /// Returns a string that identifies the current user or principal.
+ pub fn identity(&self) -> Option<&str> {
+ self.identity.as_deref()
+ }
+
+ /// Returns a map of properties currently set for the session.
+ pub fn properties(&self) -> &HashMap<String, String> {
+ &self.properties
+ }
+
+ /// Returns the session's credential map.
+ pub fn credentials(&self) -> &HashMap<String, Credential> {
+ &self.credentials
+ }
+}
+
+/// A string-like type containing sensitive information such as passwords or tokens.
+///
+/// It is redacted from logs and automatically zeroized.
+#[derive(Clone)]
+pub struct Credential(Zeroizing<String>);
Review Comment:
Yes, this is dual use! Sounds good to me. If you have a preference on the naming, `SensitiveString` is definitely the more generally plausible name. `Credential` works better in the current state where we're only dealing with credentials.
I'll take a look through the Java codebase to see whether there's other places where sensitive strings could be handled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Add SessionCatalog trait [iceberg-rust]
Posted by "CTTY (via GitHub)" <gi...@apache.org>.
CTTY merged PR #2836:
URL: https://github.com/apache/iceberg-rust/pull/2836
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Add SessionCatalog trait [iceberg-rust]
Posted by "DerGut (via GitHub)" <gi...@apache.org>.
DerGut commented on code in PR #2836:
URL: https://github.com/apache/iceberg-rust/pull/2836#discussion_r3711102612
##########
crates/iceberg/src/catalog/session.rs:
##########
@@ -0,0 +1,334 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+//! Session catalog API for Apache Iceberg.
+
+use std::collections::HashMap;
+use std::fmt::Debug;
+use std::future::Future;
+use std::sync::Arc;
+
+use async_trait::async_trait;
+#[cfg(test)]
+use mockall::automock;
+use typed_builder::TypedBuilder;
+use uuid::Uuid;
+use zeroize::Zeroizing;
+
+use crate::io::StorageFactory;
+use crate::runtime::Runtime;
+use crate::table::Table;
+use crate::{Namespace, NamespaceIdent, Result, TableCommit, TableCreation, TableIdent};
+
+/// Context for a session.
+///
+/// # Example
+/// ```rust
+/// use iceberg::SessionContext;
+///
+/// let session = SessionContext::builder()
+/// .identity("user123".to_string())
+/// .build();
+///
+/// assert_eq!(session.identity(), Some("user123"));
+/// assert!(!session.session_id().is_empty());
+/// ```
+#[derive(Debug, Clone, TypedBuilder)]
+pub struct SessionContext {
+ /// The unique identifier for this session.
+ ///
+ /// Note that the session_id may be used for caching session-scoped state
+ /// and re-use of a session_id with different session context may result in
+ /// unexpected behavior.
+ #[builder(default=Uuid::new_v4().to_string())]
+ session_id: String,
+
+ /// An optional user or principal associated with the session.
+ #[builder(default, setter(strip_option))]
+ identity: Option<String>,
+
+ #[builder(default)]
+ properties: HashMap<String, String>,
+
+ #[builder(default)]
+ credentials: HashMap<String, Credential>,
+}
+
+impl SessionContext {
+ /// Creates a new unique but empty session.
+ pub fn empty() -> Self {
+ Self::builder().build()
+ }
+
+ /// Returns the identifier for this session.
+ ///
+ /// The identifier may be used for caching state within a session.
+ pub fn session_id(&self) -> &str {
+ &self.session_id
+ }
+
+ /// Returns a string that identifies the current user or principal.
+ pub fn identity(&self) -> Option<&str> {
+ self.identity.as_deref()
+ }
+
+ /// Returns a map of properties currently set for the session.
+ pub fn properties(&self) -> &HashMap<String, String> {
+ &self.properties
+ }
+
+ /// Returns the session's credential map.
+ pub fn credentials(&self) -> &HashMap<String, Credential> {
+ &self.credentials
+ }
+}
+
+/// A string-like type containing sensitive information such as passwords or tokens.
+///
+/// It is redacted from logs and automatically zeroized.
+///
+/// # Example
+/// ```rust
+/// use iceberg::Credential;
+///
+/// let sensitive_value = "my-pw-12345";
+/// let credential = Credential::from(sensitive_value.to_string());
+///
+/// // Not contained in debug logs.
+/// assert!(!format!("{:?}", credential).contains(sensitive_value));
+/// ```
+#[derive(Clone)]
+pub struct Credential(Zeroizing<String>);
+
+impl Credential {
+ /// Returns the raw value of the credential.
+ pub fn expose(&self) -> &str {
+ &self.0
+ }
+}
+
+impl Debug for Credential {
+ fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
+ f.write_str("Credential([REDACTED])")
+ }
+}
+
+impl From<String> for Credential {
+ fn from(value: String) -> Self {
+ Self(Zeroizing::new(value))
+ }
+}
+
+/// The catalog API for Iceberg Rust that includes session handling.
+#[async_trait]
+#[cfg_attr(test, automock)]
+pub trait SessionCatalog: Debug + Send + Sync {
+ /// List namespaces inside the catalog.
+ async fn list_namespaces(
+ &self,
+ context: &SessionContext,
+ parent: Option<&NamespaceIdent>,
+ ) -> Result<Vec<NamespaceIdent>>;
+
+ /// Create a new namespace inside the catalog.
+ async fn create_namespace(
+ &self,
+ context: &SessionContext,
+ namespace: &NamespaceIdent,
+ properties: HashMap<String, String>,
+ ) -> Result<Namespace>;
+
+ /// Get a namespace information from the catalog.
+ async fn get_namespace(
+ &self,
+ context: &SessionContext,
+ namespace: &NamespaceIdent,
+ ) -> Result<Namespace>;
+
+ /// Check if namespace exists in catalog.
+ async fn namespace_exists(
+ &self,
+ context: &SessionContext,
+ namespace: &NamespaceIdent,
+ ) -> Result<bool>;
+
+ /// Update a namespace inside the catalog.
+ ///
+ /// # Behavior
+ ///
+ /// The properties must be the full set of namespace.
+ async fn update_namespace(
+ &self,
+ context: &SessionContext,
+ namespace: &NamespaceIdent,
+ properties: HashMap<String, String>,
+ ) -> Result<()>;
+
+ /// Drop a namespace from the catalog, or returns error if it doesn't exist.
+ async fn drop_namespace(
+ &self,
+ context: &SessionContext,
+ namespace: &NamespaceIdent,
+ ) -> Result<()>;
+
+ /// List tables from namespace.
+ async fn list_tables(
+ &self,
+ context: &SessionContext,
+ namespace: &NamespaceIdent,
+ ) -> Result<Vec<TableIdent>>;
+
+ /// Create a new table inside the namespace.
+ async fn create_table(
+ &self,
+ context: &SessionContext,
+ namespace: &NamespaceIdent,
+ creation: TableCreation,
+ ) -> Result<Table>;
+
+ /// Load table from the catalog.
+ async fn load_table(&self, context: &SessionContext, table: &TableIdent) -> Result<Table>;
+
+ /// Drop a table from the catalog, or returns error if it doesn't exist.
+ async fn drop_table(&self, context: &SessionContext, table: &TableIdent) -> Result<()>;
+
+ /// Drop a table from the catalog and delete the underlying table data.
+ ///
+ /// Implementations should load the table metadata, drop the table
+ /// from the catalog, then delete all associated data and metadata files.
+ /// The [`drop_table_data`](super::utils::drop_table_data) utility function can
+ /// be used for the file cleanup step.
+ async fn purge_table(&self, context: &SessionContext, table: &TableIdent) -> Result<()>;
+
+ /// Check if a table exists in the catalog.
+ async fn table_exists(&self, context: &SessionContext, table: &TableIdent) -> Result<bool>;
+
+ /// Rename a table in the catalog.
+ async fn rename_table(
+ &self,
+ context: &SessionContext,
+ src: &TableIdent,
+ dest: &TableIdent,
+ ) -> Result<()>;
+
+ /// Register an existing table to the catalog.
+ async fn register_table(
+ &self,
+ context: &SessionContext,
+ table: &TableIdent,
+ metadata_location: String,
+ ) -> Result<Table>;
+
+ /// Update a table to the catalog.
+ async fn update_table(&self, context: &SessionContext, commit: TableCommit) -> Result<Table>;
+}
+
+/// Common interface for all session catalog builders.
+pub trait SessionCatalogBuilder: Default + Debug + Send + Sync {
Review Comment:
Dropped it in 464fd1cca98c803f41246f3589d7394f145044ee
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Session catalog [iceberg-rust]
Posted by "DerGut (via GitHub)" <gi...@apache.org>.
DerGut commented on PR #2836:
URL: https://github.com/apache/iceberg-rust/pull/2836#issuecomment-5000484718
@CTTY What a coincidence! I was planning to attend myself to push for it, so thanks for covering the topic! 🙏
On https://github.com/apache/iceberg-rust/pull/2815, this is perfect timing too. I was about to start some work on the AuthManager (according to https://github.com/apache/iceberg-rust/issues/2774#issuecomment-4996531825) but that doesn't seem necessary anymore 👏
Let me take a look at the PR to watch out for integration issues with the SessionCatalog work :)
They're 100% related, but it already looks like a reasonable split to contribute them sequentially.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Add SessionCatalog trait [iceberg-rust]
Posted by "DerGut (via GitHub)" <gi...@apache.org>.
DerGut commented on code in PR #2836:
URL: https://github.com/apache/iceberg-rust/pull/2836#discussion_r3735278821
##########
crates/iceberg/src/catalog/session.rs:
##########
@@ -0,0 +1,264 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+//! Session catalog API for Apache Iceberg.
+
+use std::collections::HashMap;
+use std::fmt::Debug;
+use std::future::Future;
+use std::sync::Arc;
+
+use async_trait::async_trait;
+use typed_builder::TypedBuilder;
+use uuid::Uuid;
+use zeroize::Zeroizing;
+
+use crate::io::StorageFactory;
+use crate::runtime::Runtime;
+use crate::table::Table;
+use crate::{Namespace, NamespaceIdent, Result, TableCommit, TableCreation, TableIdent};
+
+/// Context for a session.
+#[derive(Debug, Clone, TypedBuilder)]
+pub struct SessionContext {
+ /// The unique identifier for this session.
+ ///
+ /// Note that the session_id may be used for caching session-scoped state
+ /// and re-use of a session_id with different session context may result in
+ /// unexpected behavior.
+ session_id: String,
+
+ /// An optional user or principal associated with the session.
+ #[builder(default, setter(strip_option))]
+ identity: Option<String>,
+
+ #[builder(default)]
+ properties: HashMap<String, String>,
+
+ #[builder(default)]
+ credentials: HashMap<String, Credential>,
+}
+
+impl SessionContext {
+ /// Creates a new unique but empty session.
+ pub fn empty() -> Self {
+ Self {
+ session_id: Uuid::new_v4().to_string(),
+ identity: None,
+ properties: HashMap::new(),
+ credentials: HashMap::new(),
+ }
+ }
+
+ /// Returns the identifier for this session.
+ ///
+ /// The identifier may be used for caching state within a session.
+ pub fn session_id(&self) -> &str {
+ &self.session_id
+ }
+
+ /// Returns a string that identifies the current user or principal.
+ pub fn identity(&self) -> Option<&str> {
+ self.identity.as_deref()
+ }
+
+ /// Returns a map of properties currently set for the session.
+ pub fn properties(&self) -> &HashMap<String, String> {
+ &self.properties
+ }
+
+ /// Returns the session's credential map.
+ pub fn credentials(&self) -> &HashMap<String, Credential> {
+ &self.credentials
+ }
+}
+
+/// A string-like type containing sensitive information such as passwords or tokens.
+///
+/// It is redacted from logs and automatically zeroized.
+#[derive(Clone)]
+pub struct Credential(Zeroizing<String>);
Review Comment:
Follow-up: https://github.com/apache/iceberg-rust/pull/2971
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Session catalog [iceberg-rust]
Posted by "CTTY (via GitHub)" <gi...@apache.org>.
CTTY commented on PR #2836:
URL: https://github.com/apache/iceberg-rust/pull/2836#issuecomment-4997003568
I literally just proposed this idea last week in the rust community sync, and very happy to see some actual work already!
There are some existing work on AuthManager/Session, maybe we should merge the effort? https://github.com/apache/iceberg-rust/pull/2815
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Add SessionCatalog trait [iceberg-rust]
Posted by "DerGut (via GitHub)" <gi...@apache.org>.
DerGut commented on code in PR #2836:
URL: https://github.com/apache/iceberg-rust/pull/2836#discussion_r3711066092
##########
crates/iceberg/src/catalog/session.rs:
##########
@@ -0,0 +1,334 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+//! Session catalog API for Apache Iceberg.
+
+use std::collections::HashMap;
+use std::fmt::Debug;
+use std::future::Future;
+use std::sync::Arc;
+
+use async_trait::async_trait;
+#[cfg(test)]
+use mockall::automock;
+use typed_builder::TypedBuilder;
+use uuid::Uuid;
+use zeroize::Zeroizing;
+
+use crate::io::StorageFactory;
+use crate::runtime::Runtime;
+use crate::table::Table;
+use crate::{Namespace, NamespaceIdent, Result, TableCommit, TableCreation, TableIdent};
+
+/// Context for a session.
+///
+/// # Example
+/// ```rust
+/// use iceberg::SessionContext;
+///
+/// let session = SessionContext::builder()
+/// .identity("user123".to_string())
+/// .build();
+///
+/// assert_eq!(session.identity(), Some("user123"));
+/// assert!(!session.session_id().is_empty());
+/// ```
+#[derive(Debug, Clone, TypedBuilder)]
+pub struct SessionContext {
+ /// The unique identifier for this session.
+ ///
+ /// Note that the session_id may be used for caching session-scoped state
+ /// and re-use of a session_id with different session context may result in
+ /// unexpected behavior.
+ #[builder(default=Uuid::new_v4().to_string())]
+ session_id: String,
+
+ /// An optional user or principal associated with the session.
+ #[builder(default, setter(strip_option))]
+ identity: Option<String>,
+
+ #[builder(default)]
+ properties: HashMap<String, String>,
+
+ #[builder(default)]
+ credentials: HashMap<String, Credential>,
+}
+
+impl SessionContext {
+ /// Creates a new unique but empty session.
+ pub fn empty() -> Self {
+ Self::builder().build()
+ }
+
+ /// Returns the identifier for this session.
+ ///
+ /// The identifier may be used for caching state within a session.
+ pub fn session_id(&self) -> &str {
+ &self.session_id
+ }
+
+ /// Returns a string that identifies the current user or principal.
+ pub fn identity(&self) -> Option<&str> {
+ self.identity.as_deref()
+ }
+
+ /// Returns a map of properties currently set for the session.
+ pub fn properties(&self) -> &HashMap<String, String> {
+ &self.properties
+ }
+
+ /// Returns the session's credential map.
+ pub fn credentials(&self) -> &HashMap<String, Credential> {
+ &self.credentials
+ }
+}
+
+/// A string-like type containing sensitive information such as passwords or tokens.
+///
+/// It is redacted from logs and automatically zeroized.
+///
+/// # Example
+/// ```rust
+/// use iceberg::Credential;
+///
+/// let sensitive_value = "my-pw-12345";
+/// let credential = Credential::from(sensitive_value.to_string());
+///
+/// // Not contained in debug logs.
+/// assert!(!format!("{:?}", credential).contains(sensitive_value));
+/// ```
+#[derive(Clone)]
+pub struct Credential(Zeroizing<String>);
+
+impl Credential {
+ /// Returns the raw value of the credential.
+ pub fn expose(&self) -> &str {
+ &self.0
+ }
+}
+
+impl Debug for Credential {
+ fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
+ f.write_str("Credential([REDACTED])")
+ }
+}
+
+impl From<String> for Credential {
+ fn from(value: String) -> Self {
+ Self(Zeroizing::new(value))
+ }
+}
+
+/// The catalog API for Iceberg Rust that includes session handling.
+#[async_trait]
+#[cfg_attr(test, automock)]
+pub trait SessionCatalog: Debug + Send + Sync {
+ /// List namespaces inside the catalog.
+ async fn list_namespaces(
+ &self,
+ context: &SessionContext,
+ parent: Option<&NamespaceIdent>,
+ ) -> Result<Vec<NamespaceIdent>>;
+
+ /// Create a new namespace inside the catalog.
+ async fn create_namespace(
+ &self,
+ context: &SessionContext,
+ namespace: &NamespaceIdent,
+ properties: HashMap<String, String>,
+ ) -> Result<Namespace>;
+
+ /// Get a namespace information from the catalog.
+ async fn get_namespace(
+ &self,
+ context: &SessionContext,
+ namespace: &NamespaceIdent,
+ ) -> Result<Namespace>;
+
+ /// Check if namespace exists in catalog.
+ async fn namespace_exists(
+ &self,
+ context: &SessionContext,
+ namespace: &NamespaceIdent,
+ ) -> Result<bool>;
+
+ /// Update a namespace inside the catalog.
+ ///
+ /// # Behavior
+ ///
+ /// The properties must be the full set of namespace.
+ async fn update_namespace(
+ &self,
+ context: &SessionContext,
+ namespace: &NamespaceIdent,
+ properties: HashMap<String, String>,
+ ) -> Result<()>;
+
+ /// Drop a namespace from the catalog, or returns error if it doesn't exist.
+ async fn drop_namespace(
+ &self,
+ context: &SessionContext,
+ namespace: &NamespaceIdent,
+ ) -> Result<()>;
+
+ /// List tables from namespace.
+ async fn list_tables(
+ &self,
+ context: &SessionContext,
+ namespace: &NamespaceIdent,
+ ) -> Result<Vec<TableIdent>>;
+
+ /// Create a new table inside the namespace.
+ async fn create_table(
+ &self,
+ context: &SessionContext,
+ namespace: &NamespaceIdent,
+ creation: TableCreation,
+ ) -> Result<Table>;
+
+ /// Load table from the catalog.
+ async fn load_table(&self, context: &SessionContext, table: &TableIdent) -> Result<Table>;
+
+ /// Drop a table from the catalog, or returns error if it doesn't exist.
+ async fn drop_table(&self, context: &SessionContext, table: &TableIdent) -> Result<()>;
+
+ /// Drop a table from the catalog and delete the underlying table data.
+ ///
+ /// Implementations should load the table metadata, drop the table
+ /// from the catalog, then delete all associated data and metadata files.
+ /// The [`drop_table_data`](super::utils::drop_table_data) utility function can
+ /// be used for the file cleanup step.
+ async fn purge_table(&self, context: &SessionContext, table: &TableIdent) -> Result<()>;
+
+ /// Check if a table exists in the catalog.
+ async fn table_exists(&self, context: &SessionContext, table: &TableIdent) -> Result<bool>;
+
+ /// Rename a table in the catalog.
+ async fn rename_table(
+ &self,
+ context: &SessionContext,
+ src: &TableIdent,
+ dest: &TableIdent,
+ ) -> Result<()>;
+
+ /// Register an existing table to the catalog.
+ async fn register_table(
+ &self,
+ context: &SessionContext,
+ table: &TableIdent,
+ metadata_location: String,
+ ) -> Result<Table>;
+
+ /// Update a table to the catalog.
+ async fn update_table(&self, context: &SessionContext, commit: TableCommit) -> Result<Table>;
+}
+
+/// Common interface for all session catalog builders.
+pub trait SessionCatalogBuilder: Default + Debug + Send + Sync {
Review Comment:
Oh maybe not. I was mostly following the `Catalog` example. Let me remove it then, we can always add it back 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Add SessionCatalog trait [iceberg-rust]
Posted by "DerGut (via GitHub)" <gi...@apache.org>.
DerGut commented on code in PR #2836:
URL: https://github.com/apache/iceberg-rust/pull/2836#discussion_r3687090964
##########
crates/iceberg/src/catalog/session.rs:
##########
@@ -0,0 +1,264 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+//! Session catalog API for Apache Iceberg.
+
+use std::collections::HashMap;
+use std::fmt::Debug;
+use std::future::Future;
+use std::sync::Arc;
+
+use async_trait::async_trait;
+use typed_builder::TypedBuilder;
+use uuid::Uuid;
+use zeroize::Zeroizing;
+
+use crate::io::StorageFactory;
+use crate::runtime::Runtime;
+use crate::table::Table;
+use crate::{Namespace, NamespaceIdent, Result, TableCommit, TableCreation, TableIdent};
+
+/// Context for a session.
+#[derive(Debug, Clone, TypedBuilder)]
+pub struct SessionContext {
+ /// The unique identifier for this session.
+ ///
+ /// Note that the session_id may be used for caching session-scoped state
+ /// and re-use of a session_id with different session context may result in
+ /// unexpected behavior.
+ session_id: String,
Review Comment:
Changed in https://github.com/apache/iceberg-rust/pull/2836/commits/4148500a075dc2420f0bb784b247e6962ef09160 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Add SessionCatalog trait [iceberg-rust]
Posted by "plusplusjiajia (via GitHub)" <gi...@apache.org>.
plusplusjiajia commented on code in PR #2836:
URL: https://github.com/apache/iceberg-rust/pull/2836#discussion_r3680904102
##########
crates/iceberg/src/catalog/session.rs:
##########
@@ -0,0 +1,264 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+//! Session catalog API for Apache Iceberg.
+
+use std::collections::HashMap;
+use std::fmt::Debug;
+use std::future::Future;
+use std::sync::Arc;
+
+use async_trait::async_trait;
+use typed_builder::TypedBuilder;
+use uuid::Uuid;
+use zeroize::Zeroizing;
+
+use crate::io::StorageFactory;
+use crate::runtime::Runtime;
+use crate::table::Table;
+use crate::{Namespace, NamespaceIdent, Result, TableCommit, TableCreation, TableIdent};
+
+/// Context for a session.
+#[derive(Debug, Clone, TypedBuilder)]
+pub struct SessionContext {
+ /// The unique identifier for this session.
+ ///
+ /// Note that the session_id may be used for caching session-scoped state
+ /// and re-use of a session_id with different session context may result in
+ /// unexpected behavior.
+ session_id: String,
Review Comment:
nit: since reusing a session_id across different contexts is documented as hazardous, maybe default it in the builder (#[builder(default = Uuid::new_v4().to_string())]) so the safe thing is also the default?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org