[jira] [Resolved] (BIGTOP-3358) get_roles() function should fail if a component is not in roles_map

["Masatake Iwasaki (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/BIGTOP-3358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Masatake Iwasaki resolved BIGTOP-3358.
--------------------------------------
    Fix Version/s: 1.5.0
       Resolution: Fixed

Merged this. Thanks, [~masatana].

> get_roles() function should fail if a component is not in roles_map
> -------------------------------------------------------------------
>
>                 Key: BIGTOP-3358
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-3358
>             Project: Bigtop
>          Issue Type: Improvement
>    Affects Versions: 1.4.0
>            Reporter: Masahiro Tanaka
>            Assignee: Masahiro Tanaka
>            Priority: Minor
>             Fix For: 1.5.0
>
>          Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> Puppet deploy could continue even if there is a component which is NOT in roles_map defined in [here|[https://github.com/apache/bigtop/blob/master/bigtop-deploy/puppet/manifests/cluster.pp#L36]]
>  
> IMHO that's confusing. Even if we accidentally include non-exist component in config file, we can't notice that.
> For example, we can use provisioner/docker.  If we use config.yaml like below, we should fail, or at least it should notify that there is non-exist component name in config.
> {code}
> docker:
>         memory_limit: "8g"
>         image: "bigtop/puppet:trunk-centos-7"
> repo: "http://repos.bigtop.apache.org/releases/1.4.0/centos/7/$basearch"
> distro: centos
> components: [foobar,hdfs]
> enable_local_repo: true
> smoke_test_components: []
> {code} 
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)