[GitHub] [incubator-superset] rusackas edited a comment on issue #9123: [SIP-37] Proposal to implement CSS-in-JS using Emotion 👩‍🎤

[GitBox <gi...@apache.org>]

rusackas edited a comment on issue #9123: [SIP-37] Proposal to implement CSS-in-JS using Emotion 👩‍🎤
URL: https://github.com/apache/incubator-superset/issues/9123#issuecomment-585879740
 
 
   @DiggidyDave this proposal is due largely to serve the goals of the design overhaul. That redesign will require a pretty massive revamp of the existing LESS codebase anyway. This also relates to the cleanup of LESS code we've been working on to move toward a set of variables (a theme, effectively). These efforts combined seem like the best way to
   - Have a more homogenous look and feel as we migrate new/updated components to the new design, and
   - Isolate the styling concerns of new or restyled components, so they don't bleed to other (older) components
   - Allow us to reduce reliance on the LESS codebase, which is built primarily around aging/deprecated libraries. 
   - Make it exponentially easier to style components in service of the new design direction
   
   So, while I don't disagree with your stance about fragmentation, I would suggest that it is the easiest means of migration to the new design system, and it is compatible with the existing setup (LESS still works on any/all components). It will also make styling (and comprehending existing styling) of components easier for future devs.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org